From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754977AbdKIOPY (ORCPT ); Thu, 9 Nov 2017 09:15:24 -0500 Received: from mout.web.de ([212.227.15.14]:52751 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754895AbdKIOPV (ORCPT ); Thu, 9 Nov 2017 09:15:21 -0500 To: kernel-janitors@vger.kernel.org, Alexei Starovoitov , "David S. Miller" , John Fastabend Cc: LKML From: SF Markus Elfring Subject: [PATCH] samples/sockmap: Make signal handling safer Message-ID: <8e064bc1-c762-1ca6-4a67-9d50793753f6@users.sourceforge.net> Date: Thu, 9 Nov 2017 15:15:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:swKbhm2Nt4DGqUvqy5ReOas2pVH0BIGNWRdKfSB9/uV1YkUHY60 qjOvPMs1oLBW7zXUBUolgBwOYuLngpG3v4hNlEgj94IEFsDNBLicgaKOKLwV/3IS3I/F/WF H4Shbtwwfy3bVzdq7R1bnRzWHXEsV/ANT+mYgWdW19w0/C9DcOeNAUGReuBf0Pv/Cljsv55 QhtV5lmBrRjFMkG+8nZTg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VZHnHUpDDVo=:yCAXH0yHmWAjMbBeigSPE2 TLKvwqEDHWyyllean7iuFv0tabAdE8e/+BVNVT6Y9vN8DEiZYKBkYei6e2ywdPAh2H2H29ACn tjsbcoaJWsADoUtZ7+pPduRISFobPE1BGAwJRjRlSdO/wz55pNW6H5El42VjrFyHCfQb9Wwh7 ZF4zCoFNnm0Pet5t4cCmLxABL1JwoU4QBV2uky5qiFyPIu+vuNcs2le9IlAFXU6bTLoDr3awo XTNtrpZutKqHktx2ZnUmVBt2v48ia/j1sp8KMEZHqFbxN7swH3ioYpMQPinF50v0a37CU7T6P veAkBMppk/tHtN9ElOgwvc9x+0r9AuSKS/fbE59Ew0BO46WuIztcHmyq0HW73NUN8r6H6MvMT +eelnuPfclFL6V7meILlUTVLk9ZTDqtkYbAWlXQ1vLMVEqsMfFHVte62YhjIy1+4zRRnFSWt+ vCRJ6O0WYoe4X25uM8LqxQGnQfWs5ydN0VyGrZHMFp9ydLVlV2TGXxb3EdiIF4kOWhYbVjZMX 3AofbuOjEBDAblzdXZcyc0j3u9/cfQJli6CeEmS1ne5DejUaqqwXb79lRpmoPxNJ8wizoWORm 2MNQRQs4EcGNq2ortBN2O0qHLdyImnli3JVAF6WMxzJiXhP6KpYTLzPAb/IYu4tVc7ZPaSHYi 9r+Gvb8gCq5ytyE1pyxOtcLlFnZEqq4Re2AyI29mLOmp/ZpRUEW4/3nYr7lY8gB0Crol083nP YQRAzkiDfNSCs+BxJp3ONQFBpaA9RBCVABsyIrOv5ryI2HMZGi6uk8Tu6aCoKiFSRYBwZ+F5B y2ldhTAZzMCkTBKADytkjE3fe5/6eJiGcDjEi4woQMB6JkldAQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 9 Nov 2017 15:06:16 +0100 Use the data type "sig_atomic_t" for the variable "running" so that it can be safely modified by a signal handler. Fixes: 69e8cc134bcbf0ccfcf852c400b8e6788d1d0038 ("bpf: sockmap sample program") Signed-off-by: Markus Elfring --- samples/sockmap/sockmap_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/sockmap/sockmap_user.c b/samples/sockmap/sockmap_user.c index 7cc9d228216f..6e3ebbb1f8f4 100644 --- a/samples/sockmap/sockmap_user.c +++ b/samples/sockmap/sockmap_user.c @@ -39,7 +39,7 @@ #include "../bpf/bpf_util.h" #include "../bpf/libbpf.h" -int running; +static sig_atomic_t running; void running_handler(int a); /* randomly selected ports for testing on lo */ -- 2.15.0