From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Pin-yen Lin <treapking@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Kiwi Liu <kiwi.liu@mediatek.corp-partner.google.com>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
Enric Balletbo i Serra <eballetbo@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Hsin-Te Yuan <yuanhsinte@chromium.org>,
Chen-Yu Tsai <wenst@chromium.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: Remove clock from mfg_async power domain
Date: Mon, 5 Aug 2024 13:46:22 +0200 [thread overview]
Message-ID: <8e089dc0-9342-480f-ac8a-93b5bfe1241e@collabora.com> (raw)
In-Reply-To: <20240805065051.3129354-1-treapking@chromium.org>
Il 05/08/24 08:50, Pin-yen Lin ha scritto:
> This clock dependency introduced a mutual dependency between mfg_async
> power domain and mt8183-mfgcfg clock, and Mediatek has confirmed that
> this dependency is not needed. Remove this to avoid potential deadlock.
>
Uhm, have you tested this upstream with Panfrost, or only downstream with the
proprietary Mali stack?
Regards,
Angelo
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller")
>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index fbf145639b8c..267378fa46c0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -872,8 +872,6 @@ power-domain@MT8183_POWER_DOMAIN_CONN {
>
> mfg_async: power-domain@MT8183_POWER_DOMAIN_MFG_ASYNC {
> reg = <MT8183_POWER_DOMAIN_MFG_ASYNC>;
> - clocks = <&topckgen CLK_TOP_MUX_MFG>;
> - clock-names = "mfg";
> #address-cells = <1>;
> #size-cells = <0>;
> #power-domain-cells = <1>;
next prev parent reply other threads:[~2024-08-05 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 6:50 Pin-yen Lin
2024-08-05 11:46 ` AngeloGioacchino Del Regno [this message]
2024-08-06 4:36 ` Chen-Yu Tsai
2024-08-06 8:55 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e089dc0-9342-480f-ac8a-93b5bfe1241e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@kernel.org \
--cc=kiwi.liu@mediatek.corp-partner.google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=treapking@chromium.org \
--cc=wenst@chromium.org \
--cc=yuanhsinte@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®