mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <huobean@gmail.com>, Kiwoong Kim <kwmad.kim@samsung.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, beanhuo@micron.com,
	adrian.hunter@intel.com, h10.kim@samsung.com,
	hy50.seo@samsung.com, sh425.lee@samsung.com,
	kwangwon.min@samsung.com, junwoo80.lee@samsung.com,
	wkon.kim@samsung.com
Subject: Re: [PATCH v1] scsi: ufs: core: introduce override_cqe_ocs
Date: Mon, 12 Aug 2024 10:12:01 -0700	[thread overview]
Message-ID: <8e0c2a00-1744-4cfd-b576-5efe74b21f9b@acm.org> (raw)
In-Reply-To: <f4de493e53b6d2ea543d10bc07a030b32b1e2107.camel@gmail.com>

On 8/12/24 8:41 AM, Bean Huo wrote:
> On Mon, 2024-08-12 at 16:01 +0900, Kiwoong Kim wrote:
>> +static inline enum utp_ocs ufshcd_vops_override_cqe_ocs(struct
>> ufs_hba *hba,
>> +                                                       enum utp_ocs
>> ocs)
>> +{
>> +       if (hba->vops && hba->vops->override_cqe_ocs)
>> +               return hba->vops->override_cqe_ocs(hba);
> 
> it is useless until you should introduce an usage case.

Indeed. If a new callback is introduced, a user for that callback should
be introduced in the same patch series.

Thanks,

Bart.


  reply	other threads:[~2024-08-12 17:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240812065927epcas2p4ace98e8757a76e62efa3165de719408a@epcas2p4.samsung.com>
2024-08-12  7:01 ` Kiwoong Kim
2024-08-12 15:41   ` Bean Huo
2024-08-12 17:12     ` Bart Van Assche [this message]
2024-08-12 17:29   ` kernel test robot
2024-08-13  3:24   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e0c2a00-1744-4cfd-b576-5efe74b21f9b@acm.org \
    --to=bvanassche@acm.org \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=h10.kim@samsung.com \
    --cc=huobean@gmail.com \
    --cc=hy50.seo@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=junwoo80.lee@samsung.com \
    --cc=kwangwon.min@samsung.com \
    --cc=kwmad.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sh425.lee@samsung.com \
    --cc=wkon.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®