From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2BC12F1FEF for ; Wed, 28 Jan 2026 08:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769587575; cv=none; b=RUc9KzyljO7MdFRpE9r+j8/VjZuWKq7rJK8fRIc8C7M6TTGNjSWSQeMxos3qsT3M+SxhczckGKBpKGBIrG38hGVY3O3JpaqUAKAXzPBYUXYvXIVnnGpe/yBa/OU8p8IJSaLUziPRN4z7ii5iphD5biQeMHinx3UlQXEjSj7HnOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769587575; c=relaxed/simple; bh=fySWa2YPX+zY7WKT8GRxXSqY8amUG/E8RcBOrRuwtV8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LCn5YyfvZfIV5DMVCvoxf2tZO1rhZPLgTPpcG8MBwt2sgtTghafpEFPkcVtcbfZ9bZjkIB8bPnApJL2aodcHpWkii0Df1ya3H2sCM57w4yv6wM3mPkgm6YAYjLaPFgvp72nlP52M7MhyPtMv940J7tmO/TqqberatG9aKXlgdc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mifdXvZI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yhf/i5RV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mifdXvZI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yhf/i5RV" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S53lv13353022 for ; Wed, 28 Jan 2026 08:06:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /Y/4AduHygOOr/US0JTx0tGB3z9DY7O4M+3RFP1ask4=; b=mifdXvZIYWE52xAQ PmsTx5deIpdYsR/rNxxdJ9Sj6vzGBI2S9HurbN8sljxVdYdzIwLUK80fyb/iKK0k ayt5orAwL4S9tOjn/u6nM1KelAkhsU8uVZj2zkfJmTMhA2pg2azj5Dh993DTpnJ0 DOvkh/LcRjNGK3tuaK+thOL8E2W/+3l/YP5PeKI1AwfgvFbEtFRcaomSzxXFlhM+ N99VLKg1SJSkhGgJoO4W1KxuAsUZNmL3tLHzZx43ps4PJ7KGfAsz7lWf9QMzwRGW pbf3jXXcUzjyygkTkbtZl3k+2DHRXb9hyRrjjIFLUMFWdf60R4EEkafZBv7IldRB Avg5Ig== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bybyv0h9r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 08:06:12 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-81ed3e6b917so5621743b3a.1 for ; Wed, 28 Jan 2026 00:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769587571; x=1770192371; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Y/4AduHygOOr/US0JTx0tGB3z9DY7O4M+3RFP1ask4=; b=Yhf/i5RVpL/cn7XytbGEy462bBp54gCS3vKYnfW2Vlt3duasoBLyQGG1wTJa7eeKfD Pu+HQ+Eic1SBT5iUsvIXg54m+ghppDWLNyuFwEYK4gJtvpVo7lIxrbrz5Ad6Rys4crQx wJxITqwPR0abmtto7vz2EcrUpxv6urC3pi6qE6xcbF1oi56ftnGYaR9qvv4U/cvdQX7r so2JyTu6jaEemu53QqvPArIZByvHrk9I3d8a/hi5rmzuFe7ur3f12SrE3yo4JK0x2Gx6 7fsB7JiqCNm7dVC4lyzyRyVcOVp9nMRumRS4ylfMEQAtwzWKygJdfcx/WikT5XjVNxtP siDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769587571; x=1770192371; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/Y/4AduHygOOr/US0JTx0tGB3z9DY7O4M+3RFP1ask4=; b=FMGwos3lxtism8u+6Z33hIM/ZP/QokC2HzF+O+JT6k+xnwGyvpCZ16/+zjKDyaf2Rz t9Ijtvdg1To1tkZN3FeQc2LVIRii8vu0c2EVXNguehmnqfODRwzY8rnlD2lacg159iWI Uh1buYMh8zFEgLc46k7HTrn5vNZpZO+4Wspf8we02F3DEa2yDo5mXjE2LA9VrshaykCK ek/CtFlFzg7i/L/n2q/6qwzchobXjVxfR4Ar5xxy0i2AJT1yU5wghk4TL1r9r8Zq05WD ILAu9kUM5Ee4tgVwAaGmOGZDVVd+cmXuiWL4ybpO+7zXLIHZbYoO5FCNbJXtxNnh/npr hqlw== X-Forwarded-Encrypted: i=1; AJvYcCV7/2kcqzJ4maX49rdk8nA+DdkV+EkiCMgGGWnkevkXSfHWOkJgefKIJ6bAhTn8i/QSWb2AhD8Up0HAxd0=@vger.kernel.org X-Gm-Message-State: AOJu0YxI8oRUiDljwcblAvQiyDc9Lgl+QOsdzKjeD8AIuA2j682S0Nae 2vyAxx9AfPBBLKhYmhYD/elqkLtgAy+e8dH/WymuMVb8ZEsb4l7eFdkQWXIM7B1sL5+LPLYpmJ6 75x37sCT8o0ypdvSrFCH6TCDk8bN0MiiPimNLZ8fV0ysgahEnZkgOjHM0TSpEOOn5+gc= X-Gm-Gg: AZuq6aI+NI1Bz/JHBNJQ0AfzAgfez7nXqIazxfmVdrKDKxlK5/e4u/5m1iOd2C64dmx zZq0NanHtJhbVV/I5uxEft56h5H9JeyxXCN0osZHKryU8wU1uyj+egmpDu6X/Gi4IjrvVIkKFCi LJC/+40CkhmkK09aEuch7ZX3dzl7AFMGBDwtdkPZXcIyDb/e29sewtxmdPM28gSvHJ5QFoEWwci yMQqf1jtjUsnhbge3ck/1oyyGzlYe6eqzf8Evwb/Neo/gjASsmYgRfckl1faOmqWSHNbwpgJeO7 LqjBwf7BpTqkuQdu43mdJScZqqP2Zv0x1ouqgoe46TvjhT2MrGYC5VXJjpf5zCGnY8YybIl871e 8/TaAOVKFOeUXVOkHr14I+ZUcxNQhk/eaXSpj2yZ/VA6pKmJbovT+RiQqEhBvUZyNiKco X-Received: by 2002:a05:6a00:cd3:b0:81f:4a0c:c584 with SMTP id d2e1a72fcca58-823691608cfmr4740765b3a.1.1769587571366; Wed, 28 Jan 2026 00:06:11 -0800 (PST) X-Received: by 2002:a05:6a00:cd3:b0:81f:4a0c:c584 with SMTP id d2e1a72fcca58-823691608cfmr4740725b3a.1.1769587570872; Wed, 28 Jan 2026 00:06:10 -0800 (PST) Received: from [10.133.33.20] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c54febsm1762607b3a.59.2026.01.28.00.06.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 00:06:10 -0800 (PST) Message-ID: <8e13cfba-5bc1-4588-aa79-6cf13d35dba9@oss.qualcomm.com> Date: Wed, 28 Jan 2026 16:06:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible To: Krzysztof Kozlowski , Jeff Johnson , jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jonas.gorski@gmail.com References: <20260121095055.3683957-1-miaoqing.pan@oss.qualcomm.com> <74176aab-03d4-4095-890d-7ef1739b914b@oss.qualcomm.com> <32845805-5758-4c35-8818-ebccbfd9546a@kernel.org> Content-Language: en-US From: Miaoqing Pan In-Reply-To: <32845805-5758-4c35-8818-ebccbfd9546a@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: XVpuFkfTnLDsN4FRFXeZsHkVle39rlXa X-Authority-Analysis: v=2.4 cv=ZZ4Q98VA c=1 sm=1 tr=0 ts=6979c374 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=b4L-3lD8CPRiJR5BZnEA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA2NSBTYWx0ZWRfXymkaseMsHYP0 KEyA/TDxKvKaboqD+sYwn3BdJnnyfXJikz5SQ/4IelN8ib6B66hyN33HuFZU+o4RMqjQgmByKWe durnMnjKSvRguuz1W08YlJ52r2Y/irJmzrPipbSVoEp3W2KAa787wM4UodT90uZjLOLpyzp+GaU 0l2OKIspgbRmCZGDAHwqud7xpYyn481nsvAFiwM3HVW2aBcQQGTdpnQojZqFwgEye/ARb2Dedsu SivJFPQCxy8Fb+UG/zBhUnCkNz85K5PrJxth53BhEYIBXGr+KzleeWrCDFqaWc/Vorw8/bG/3/S njx88m598poihBMOREgZ4FmFeDta6eTnG0BRV7EMtKyKkPPlLtgvrJQBXUtHJCWbqh4d/QrIy0M 1oyagwX3OfHdVkNg88qAVGmHcL/JqJzcuIyh9njto60f/o0HDt65omJ1+/Bx+hmC0NwuIhQZNh5 rrk9KTpqOnDK/deRJcg== X-Proofpoint-ORIG-GUID: XVpuFkfTnLDsN4FRFXeZsHkVle39rlXa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_01,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280065 On 1/28/2026 4:01 PM, Krzysztof Kozlowski wrote: > On 27/01/2026 18:31, Jeff Johnson wrote: >> On 1/21/2026 1:50 AM, Miaoqing Pan wrote: >>> The 'firmware-name' property was introduced to allow end-users and >>> integrators to select use-case-specific firmware for the WCN6855. >>> But for M.2 WLAN chips, there is no suitable DTS node to specify >>> the 'firmware-name' property. In addition, assigning firmware for >>> the M.2 PCIe interface causes chips that do not use use-case-specific >>> firmware to fail. Therefore, abandoning the approach of specifying >>> firmware in DTS. As an alternative, propose a static lookup table >>> mapping device compatible to firmware names. >>> >>> --- >>> v2: >>> - Drops `firmware-name` from completely. >>> - Updates the commit message to clearly state that the property is >>> obsolete and the change is ABI-breaking but safe for upstream. >>> v3: >>> - Deprecate 'firmware-name' property instead of obsolete. >>> - Keep the ABI backwards compatible. >>> v4: >>> - Use of_machine_is_compatible() to simplify the code. >>> - Add back Acked-by tag. >>> --- >>> >>> Miaoqing Pan (2): >>> wifi: ath11k: add usecase firmware handling based on device compatible >>> dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' >>> property >>> >>> .../net/wireless/qcom,ath11k-pci.yaml | 1 + >>> drivers/net/wireless/ath/ath11k/core.c | 27 +++++++++++++++++++ >>> drivers/net/wireless/ath/ath11k/core.h | 4 +++ >>> 3 files changed, 32 insertions(+) >>> >>> >>> base-commit: d8e1f4a193101a72235416f189b01131a57e26e9 >> >> Krzysztof, >> Since you previously NAKed this series, can you confirm that your review >> comments have been addressed? > > > Binding looks fine, but I did not check the driver. > > Best regards, > Krzysztof The driver has retained compatibility with the firmware-name. static inline const char *ath11k_scan_state_str(enum ath11k_scan_state state) { @@ -1346,6 +1347,9 @@ static inline void ath11k_core_create_firmware_path(struct ath11k_base *ab, of_property_read_string(ab->dev->of_node, "firmware-name", &fw_name); //here + if (!fw_name) + fw_name = ath11k_core_get_usecase_firmware(ab); +