mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [for-next][PATCH 11/11] treewide: Add missing semicolons to __assign_str uses
Date: Wed, 09 Jun 2021 19:46:16 -0700	[thread overview]
Message-ID: <8e163bf6c239ed519bbf754acac56f68897a3db3.camel@perches.com> (raw)
In-Reply-To: <20210610010158.690158686@goodmis.org>

On Wed, 2021-06-09 at 21:01 -0400, Steven Rostedt wrote:
> From: Joe Perches <joe@perches.com>
> 
> The __assign_str macro has an unusual ending semicolon but the vast
> majority of uses of the macro already have semicolon termination.
> 
> $ git grep -P '\b__assign_str\b' | wc -l
> 551
> $ git grep -P '\b__assign_str\b.*;' | wc -l
> 480
> 
> Add semicolons to the __assign_str() uses without semicolon termination
> and all the other uses without semicolon termination via additional defines
> that are equivalent to __assign_str() with the eventual goal of removing
> the semicolon from the __assign_str() macro definition.
[]
>  net/mac80211/trace.h                          |  2 +-
[]
> diff --git a/net/mac80211/trace.h b/net/mac80211/trace.h
[]
> @@ -33,7 +33,7 @@
>  			__string(vif_name, sdata->name)
>  #define VIF_ASSIGN	__entry->vif_type = sdata->vif.type; __entry->sdata = sdata;	\
>  			__entry->p2p = sdata->vif.p2p;					\
> -			__assign_str(vif_name, sdata->name)
> +			__assign_str(vif_name, sdata->name);

This one is unnecessary as every use of VIF_ASSIGN already has a semicolon
termination.



  reply	other threads:[~2021-06-10  2:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  1:01 [for-next][PATCH 00/11] tracing: Updates for 5.14 Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 01/11] tools/bootconfig: Simplify expression Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 02/11] sched/tracing: Remove the redundant success in the sched tracepoint Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 03/11] tracing: Remove redundant assignment to event_var Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 04/11] ring-buffer: Use fallthrough pseudo-keyword Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 05/11] trace: replace WB_REASON_FOREIGN_FLUSH with a string Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 06/11] tracing: Remove redundant initialization of variable ret Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 07/11] tracing: Fix set_named_trigger_data() kernel-doc comment Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 08/11] tracing: Add WARN_ON_ONCE when returned value is negative Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 09/11] tracing/boot: Add per-group/all events enablement Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 10/11] Documentation: tracing: Add per-group/all events enablement desciption Steven Rostedt
2021-06-10  1:01 ` [for-next][PATCH 11/11] treewide: Add missing semicolons to __assign_str uses Steven Rostedt
2021-06-10  2:46   ` Joe Perches [this message]
2021-06-10 14:33     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e163bf6c239ed519bbf754acac56f68897a3db3.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=jgg@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®