From: "Arnd Bergmann" <arnd@arndb.de>
To: "Anthony L Nguyen" <anthony.l.nguyen@intel.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Andrew Lunn" <andrew@lunn.ch>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] igc: fix LEDS_CLASS dependency
Date: Sat, 24 Feb 2024 08:50:49 +0100 [thread overview]
Message-ID: <8e1a3753-4707-44e7-b746-48437cac8e70@app.fastmail.com> (raw)
In-Reply-To: <95e8cc82-2e7e-bca9-16ab-3148c3183f32@intel.com>
On Sat, Feb 24, 2024, at 00:15, Tony Nguyen wrote:
> On 2/22/2024 2:02 AM, Arnd Bergmann wrote:
>>
>> diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
>> index af7fa6856707..6e7901e12699 100644
>> --- a/drivers/net/ethernet/intel/Kconfig
>> +++ b/drivers/net/ethernet/intel/Kconfig
>> @@ -372,6 +372,7 @@ config IGC
>> config IGC_LEDS
>> def_bool LEDS_TRIGGER_NETDEV
>> depends on IGC && LEDS_CLASS
>> + depends on LEDS_CLASS=y || IGC=m
>
> I don't know kbuild that well, but would this cover LEDS_CLASS=n with IGC=m?
The 'depends on LEDS_CLASS' take care of that.
> There are Similar checks in the file [1][2] that would transpose to
> depends on IGC && LEDS_CLASS && !(IGC=y && LEDS_CLASS=m)
>
> which should cover that and keep the checks in the file consistent. IMO
> a little more readable as well.
Right, that works as well. I find the negative dependencies
slightly more confusing, they should do the same thing here.
Please apply whichever version makes most sense to you then.
Arnd
prev parent reply other threads:[~2024-02-24 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 10:02 Arnd Bergmann
2024-02-22 10:18 ` Kurt Kanzenbach
2024-02-22 10:21 ` [Intel-wired-lan] " Paul Menzel
2024-02-23 23:15 ` Tony Nguyen
2024-02-24 7:50 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e1a3753-4707-44e7-b746-48437cac8e70@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®