From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966120AbdEOTMj (ORCPT ); Mon, 15 May 2017 15:12:39 -0400 Received: from mout.web.de ([212.227.15.14]:61745 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964967AbdEOTMh (ORCPT ); Mon, 15 May 2017 15:12:37 -0400 Subject: [PATCH 1/6] PNP: Delete an error message for a failed memory allocation in pnp_alloc() From: SF Markus Elfring To: "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org Cc: LKML , Wolfram Sang References: <94f6ec12-0092-e1e6-3fb1-81f9630eae1f@users.sourceforge.net> Message-ID: <8e1a8099-5f0b-d8f4-d039-7c3ecdf8b508@users.sourceforge.net> Date: Mon, 15 May 2017 21:12:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <94f6ec12-0092-e1e6-3fb1-81f9630eae1f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:iuRVeHOWszBKqSVi9COZkIWYY3vwCboK8kL0omSAEe17PSqNBph fqniBlrSbCP0TWJHx46QueB75YwI2MuEGEJ53pudW+yiiw81zLKT8iM9qzG4W2ABNRtBEr8 G9qb6AD0M0NOOlN90RJ8hOwO6sXXzCKnsZvB6v+MgYGHIncZPb/C+WNrCiBahokbkixc0hx 5Z9+KrjQly4685X4R0ZWg== X-UI-Out-Filterresults: notjunk:1;V01:K0:arwEuMxKAng=:AvyGm2A6QghF9z8xPbUQDy uyq0QLuMfMl2EHnadx5+/1zrVjPORf9iR51XvJ7SIJS+MakZGhfWkCsGFrUN+cojDyNt38z95 ObQP3cXEBf6xbg/hUAVMYWHrUEYXzeHEJJRyDpdP2gCaXiPud5M6pvsTUkGnImnAee1eXJURd R28I7dA3RxJkBQJwpUcEXPi5YU7cMOKdNNaR3/OlelrmVIKFlXFTiK2BZsgSaz+j1246gEEhM +SYlnikERQSXRT8w1M0haBLC+MI1nFX0CUGzk3h+KdZFc/iqDLh7oe8m6RPvSX95/j1D33Gvk ajgR8v6xfOFnEAQblXtVg1Mmlldi7r/JyfGba1IpJYDaUBcCOuWAc4ll1Yn2ZGraCwOfL8M1W 7IrrQrptCWbrl+aJKK44+vp0ee5yHNUEj9DKzTpFSaKL/bk/H6eSBKYcEpm1gqxBppK1BEu1D I4JB5Al/mqX+pud2GMJ9d2DcHP9nXHWzUq58SLaQUO55A2LbCSkaeSfeXh7AHdNCsHfTLYn0/ FIQuHe0DeIytCOeufByXmURbZOtHgASPkldGbS5MAi/WKuVef382vV4Cllmh87+vrRMB7dHjd bfPU0mxcLN7Bj7T/phCPu9H5xdUIzIKXiKFm7U/5cyr2XiysXGwXYewEF06b7obrI7o39nnMO RjcqneEJABow3He6zQFObq/lkaLAYzLogr6g56F+6XBjHZxsbRP60OSiUN93OnGnTdi5rFYza JUQWUTa4/oDjc/cYuKRE4FHaDliXNOBObDlYWLpRWlQDNOk0CfhXI6/bR7RfqE48dgcKSIBNt Lb5VpWa Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 15 May 2017 19:35:29 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/pnp/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c index b54620e53830..27945a2d9c4e 100644 --- a/drivers/pnp/core.c +++ b/drivers/pnp/core.c @@ -35,10 +35,8 @@ void *pnp_alloc(long size) void *result; result = kzalloc(size, GFP_KERNEL); - if (!result) { - printk(KERN_ERR "pnp: Out of Memory\n"); + if (!result) return NULL; - } return result; } -- 2.13.0