From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F492C33CA8 for ; Mon, 13 Jan 2020 09:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BFB72082E for ; Mon, 13 Jan 2020 09:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbgAMJb5 (ORCPT ); Mon, 13 Jan 2020 04:31:57 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:45266 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgAMJb5 (ORCPT ); Mon, 13 Jan 2020 04:31:57 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1iqw4W-002bnY-RN; Mon, 13 Jan 2020 10:31:44 +0100 Message-ID: <8e1acaf6529f997b939a75975e958a4cf7f58738.camel@sipsolutions.net> Subject: Re: BUG: unable to handle kernel NULL pointer dereference in cfg80211_wext_siwrts From: Johannes Berg To: Dan Carpenter , Justin Capella Cc: syzbot , "David S. Miller" , LKML , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, Cody Schuffelen Date: Mon, 13 Jan 2020 10:31:43 +0100 In-Reply-To: <20200113092820.GB9510@kadam> References: <00000000000073b469059bcde315@google.com> <20200113092820.GB9510@kadam> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-01-13 at 12:28 +0300, Dan Carpenter wrote: > That's the wrong ops struct? I think I was looking at the "previous > report" that Johannes mentioned where it was crashing because > virt_wifi doesn't implement a set_wiphy_params function. Did I say that? Had forgotten by the time I got to this email ... But thanks for the pointer (reminder?) I'll go through cfg80211 and fix it there then. johannes