From: Keerthy <j-keerthy@ti.com>
To: Eduardo Valentin <edubezval@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Zhang Rui <rui.zhang@intel.com>, <linux-pm@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal: ti-soc-thermal: remove dead code
Date: Tue, 3 Jul 2018 10:40:25 +0530 [thread overview]
Message-ID: <8e1b81d0-2ae4-90aa-b079-7bc778a2f015@ti.com> (raw)
In-Reply-To: <20180702163010.GA2380@localhost.localdomain>
On Monday 02 July 2018 10:00 PM, Eduardo Valentin wrote:
> Keerthy,
>
> On Fri, Jun 29, 2018 at 06:10:26PM +0200, Bartlomiej Zolnierkiewicz wrote:
>>
>> Hi,
>>
>> On Wednesday, May 02, 2018 03:20:35 PM Bartlomiej Zolnierkiewicz wrote:
>>> Majority of this code (i.e. functions from ti-bandgap.c) has been
>>> introduced in May 2013 by commit eb982001dbd8 ("thermal: introduce TI
>>> SoC thermal driver"). Just remove it altogether (in case it is needed
>>> it can be easily resurrected from git repo).
>>>
>>> While at it fix incorrect "not used" comments.
>>>
>>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>> ---
>>> drivers/thermal/ti-soc-thermal/dra752-bandgap.h | 68 ---
>>> drivers/thermal/ti-soc-thermal/dra752-thermal-data.c | 65 ---
>>> drivers/thermal/ti-soc-thermal/omap3-thermal-data.c | 6
>>> drivers/thermal/ti-soc-thermal/omap4-thermal-data.c | 10
>>> drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h | 10
>>> drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 46 --
>>> drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h | 41 --
>>> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 370 -------------------
>>> drivers/thermal/ti-soc-thermal/ti-bandgap.h | 43 --
>>> 9 files changed, 5 insertions(+), 654 deletions(-)
>>
>> Gentle ping.
>>
>> It would be great to see this patch in v4.19.
>
> Any objections on this removal / cleanup?
Tested the patch on dra72-EVM.
cpufreq cooling works well.
Tested-by: Keerthy <j-keerthy@ti.com>
Acked-by: Keerthy <j-keerthy@ti.com>
Thanks for the clean up Bartalomiej!
>
next prev parent reply other threads:[~2018-07-03 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180502132036eucas1p14cb3b3dfc0ef30b8c9e8e4f147a3c8a7@eucas1p1.samsung.com>
2018-05-02 13:20 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20180629161027eucas1p20846507c4f98f50d80ab58aaa1628fd1@eucas1p2.samsung.com>
2018-06-29 16:10 ` Bartlomiej Zolnierkiewicz
2018-07-02 16:30 ` Eduardo Valentin
2018-07-03 5:10 ` Keerthy [this message]
[not found] ` <CGME20180704135439eucas1p15aa9f097aba8d1f12ccb6e31ee6ab46b@eucas1p1.samsung.com>
2018-07-04 13:54 ` Bartlomiej Zolnierkiewicz
2018-07-04 16:00 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e1b81d0-2ae4-90aa-b079-7bc778a2f015@ti.com \
--to=j-keerthy@ti.com \
--cc=b.zolnierkie@samsung.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®