From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbdHNLkO (ORCPT ); Mon, 14 Aug 2017 07:40:14 -0400 Received: from mout.web.de ([212.227.17.12]:63885 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbdHNLkK (ORCPT ); Mon, 14 Aug 2017 07:40:10 -0400 Subject: Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions To: Catalin Marinas , linux-mm@kvack.org Cc: LKML , kernel-janitors@vger.kernel.org References: <301bc8c9-d9f6-87be-ce1d-dc614e82b45b@users.sourceforge.net> <986426ab-4ca9-ee56-9712-d06c25a2ed1a@users.sourceforge.net> <20170814111430.lskrrg3fygpnyx6v@armageddon.cambridge.arm.com> From: SF Markus Elfring Message-ID: <8e1d5cce-3661-44cc-ea1c-ac754513cde4@users.sourceforge.net> Date: Mon, 14 Aug 2017 13:40:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170814111430.lskrrg3fygpnyx6v@armageddon.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:nKZmYcEdl2vouCW6d4gWqBgK2ulQ0bxU5RDN5kyYNflP7jNbTrk TIekp0aUoxAUBUgt1zg5wpIqPOvk7zSZz6O5Pi5c2kWG2xg9qS4jGQWj5OcBQFk9HCWBu9C 6KmArnZXY+JhPSFudUIBDMVJnStkL7v8JJE4u3d9mJ7G/z4ooFmn5rLXsXBrHpBn1DDErSm IKRC1W9uGpJmMBqyJNMiA== X-UI-Out-Filterresults: notjunk:1;V01:K0:hCPjFS98RjA=:brMRqQMTtL1FNcDdCS9ZX6 tN4Cbua8V7kfVPy3+ZB61Nt98eX+yJhPQIVOfmsLz0IiKLzW+qZN81vJUHqgUX+7wvMGawpU2 yNHhiNkOfDF4UBH8/TV1+RXPw9oKgkEjWJ7AoOwKPhz3ZAUMjkR8VIe1czWIW5+KfnR9De6Xa Aq6RJ+7yzbGW17IX0mjNqoBLW1ued9LOOlyjHv6vY+jNcS4iZRqHFKg7bLVQ+m7ofQ5N6TJk7 Ih38IJIGq6Ae/E9ZHFTHL11hPSnsrwK7teTybToqLa0Zva1DvGefdRScThxvTUl6/Ii6pW4dF R/106libVA0Q5cjX9rTswv6o4Jeq+/MXqee1mGM+clvZl26Lw3VKdsWmv2hdnYm4+eqFKNJnW irsnmQFpSF/bPiPtR79cmpaBUqQQTsv9kLkuLmkaY7ANmrA1lSzRFeW/Fl7ZBwbc2fg9SGoz/ I2sDdVdNfFI2dRgcyWDds95KxQxqt2dfmbOOff9ICMWTZoyPLe6mVM7AIQfwvSa9chZsOqybX k5eiBR9Pbz5vl39SBS6Rx8beZTvgpHgHQv1TtM6uqDdEO2dQNzowESoVLYnfokhunLxjISU29 BX4wyahj26pvGaQKikHkS81JNoLPnwQO4wNrqhe6Rc6rgLqfZ34VdZ+k1crucT9d6hJ3mdkjs Vb2RVm4vYoEsz5CmNr15bcr7gR5/pB8aa2CsWV//RSQQRmD/BLAdKfFlD/Wt7bs9yF0MrCG6H V9Dr0PWJYAFFj8cX2AAwFB8Rdp7nE9+9Ni44Gtx0MSPgXgpNcjjRb5rRiiygsPC1uEaJthUfU sFlSafH9BRk1UCimQflxpZVO9IhV3GphOfwYtDRs/OV2O+vNRI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> +++ b/mm/kmemleak.c >> @@ -555,7 +555,6 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size, >> >> object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp)); >> if (!object) { >> - pr_warn("Cannot allocate a kmemleak_object structure\n"); >> kmemleak_disable(); > > I don't really get what this patch is trying to achieve. I suggest to reduce the code size a bit. > Given that kmemleak will be disabled after this, I have got difficulties to interpret this information. > I'd rather know why it happened. Do you find the default allocation failure report sufficient? Regards, Markus