From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Chris Healy <Chris.Healy@zii.aero>,
Jeff White <Jeff.White@zii.aero>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: pinctrl-sx150x.c broken in 4.11
Date: Thu, 11 May 2017 22:11:05 +0300 [thread overview]
Message-ID: <8e203964-064c-260d-71eb-b430df365a08@cogentembedded.com> (raw)
In-Reply-To: <20170511175106.GV3489@atomide.com>
>>> Maybe create_pinctrl() could check if the pin controller device
>>> for a potential hog points to the device itself and bail out
>>> if that's not the case?
>>
>> Well that's exactly what patch from my first mail in this thread does.
>> This indeed fixes my case, but I don't know if it is correct in generic
>> case.
>
> OK, yeah I just looked it up as I was not in cc.
>
>> Should I submit it? Do you ack?
>
> Yeah please submit a proper patch. I assume you already checked
> that this change only affects the pinctrl hogs only, not regular
> device pins? I'd assume so as it's in create_pinctrl()..
Regular device pins go via pinctrl_get() which calls create_pinctrl()
with second argument set to NULL.
next prev parent reply other threads:[~2017-05-11 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 19:32 Nikita Yushchenko
2017-05-11 7:23 ` Linus Walleij
2017-05-11 15:16 ` Tony Lindgren
2017-05-11 16:24 ` Nikita Yushchenko
2017-05-11 16:36 ` Tony Lindgren
2017-05-11 16:57 ` Nikita Yushchenko
2017-05-11 17:51 ` Tony Lindgren
2017-05-11 19:11 ` Nikita Yushchenko [this message]
2017-05-12 9:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e203964-064c-260d-71eb-b430df365a08@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=Chris.Healy@zii.aero \
--cc=Jeff.White@zii.aero \
--cc=andrew.smirnov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®