mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiabing Wan <wanjiabing@vivo.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: micrel: Fix incorret variable type in micrel
Date: Mon, 9 May 2022 21:55:42 +0800	[thread overview]
Message-ID: <8e2e3c34-1aa3-bab4-cdde-256a6eea5e44@vivo.com> (raw)
In-Reply-To: <Ynkcy0VhJ/HTfqMU@lunn.ch>


Hi, Andrew

On 2022/5/9 21:53, Andrew Lunn wrote:
> On Mon, May 09, 2022 at 09:49:51PM +0800, Wan Jiabing wrote:
>> In lanphy_read_page_reg, calling __phy_read() might return a negative
>> error code. Use 'int' to check the negative error code.
> Hi Wan
>
> As far as the code goes, this looks good.
>
> Please could you add a Fixes: tag, to indicate where the problem was
> introduced. Please also read the netdev FAQ, so you can correctly set
> the patch subject. This should be against the net tree, since it is a
> fix.
>
> Thanks
> 	Andrew

OK, I'll fix it in v2.

Thanks,
Wan Jiabing


  reply	other threads:[~2022-05-09 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 13:49 Wan Jiabing
2022-05-09 13:53 ` Andrew Lunn
2022-05-09 13:55   ` Jiabing Wan [this message]
2022-05-09 15:56 ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e2e3c34-1aa3-bab4-cdde-256a6eea5e44@vivo.com \
    --to=wanjiabing@vivo.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®