From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7526C35949 for ; Mon, 16 Feb 2026 16:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771258564; cv=none; b=LynMkY0CJxlbiNcDG4IxgKR8sUjdDUIdhd9QB/EnUHXmwG4EmLNA2/xXGaZBuVKcogjXweMTU+I8YdzrBfmN1CdqljsEDCNUwo2Mqw+TCNXGqwYBv/Jw+bRFhiM+ZPCKq7IrJX6a7rbN+yo7qv4goWvY170+Y6mr6sWwyxB+c2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771258564; c=relaxed/simple; bh=hSrOjPSK3stnYqiWTxKv57EE0sHH31JAVlCoInZuzNU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=cBXpKoBcFspsU4bAz4EWE5JY/2IuoCnpDfUm10F2gzt9UEm5fd10rwcM1vHtTkUhCkY0tQH+F0J/99xeKMxUiVLKMvcJEE6jrtT++DQAc0a1cmPB1ckkRugG+IquT9tWjjFWTjwRjbCL62SOCPsZXfL2cICac7C8bA4QmGPD+PE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t/yFvRzG; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t/yFvRzG" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-436317c80f7so3640776f8f.1 for ; Mon, 16 Feb 2026 08:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771258562; x=1771863362; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=DKJ7LQxP686mUB8k5bHigcsySoErWd50V3vEEJlbK3c=; b=t/yFvRzG6khMcXbjrYSDgLCcQSXLlLbdxSOXNBxdIF27lNKuDmMC5Djeq1pK/4oSVs 3fr39fg9+5RhNPaQ8XlWcbujFMiACK78c+ghuVXgsalADc/sTBfTrZRiCojFaLqBzXlI M7rnKzSGHs1jKyg14DiMCoDVoMs/jQ9TxgxKN+QgPB+7ptG1z3iw6g/p7STq5PNe+9Op KOd6vtDN02eB1dEJrqP44b9eAoCQ3Yzrpbz4uYecL3LDy4oi+Qyz67kvFv7h4ZbPJgst wFOosnecZ6NvbehqWwnHCG6x2XqI99Yu3RX+G6LWZjIMxMqL2+hMulJiHqZwoBOwEt/u JQ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771258562; x=1771863362; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DKJ7LQxP686mUB8k5bHigcsySoErWd50V3vEEJlbK3c=; b=b2zzK5gJuTimQzy7qhc1zSRyTHsm6Be0zMIIzd1ar1MV1HnoHzaOJeS4lHX5W8N2Im otvVzbyAAg42eLObQpjrRSzNU/xsCad3RLx5AgyEhkLsvPYpaZTy8ZBA4lns9EvRYMOu jZERsaLQcmyphJPH7prST9lUvA4khnH8nB7GUy5pJKsvqkStl5M7Xs2pDErizL00wbmD RIW5KbBsRlRrR6IkBYoKr/+JdUUDCXBXTMV1JS5ZmPh+KWEL/Nk7kTepj59UWor6P0mx Iy7RkohsxJAAmXgfa8CklJ+Zr2rebDGcd5O6DXNGk2Eimgk89usMnO0Rb+HVpshpzZ7h HiPQ== X-Forwarded-Encrypted: i=1; AJvYcCVNWYONZ8Lx/P7wbzm7t1tSU5oFRGJk4ZDxm1fBQImyzYlj7m63fhvJ8ZCeeaLrIsKX/XaAq9gVoetNpVk=@vger.kernel.org X-Gm-Message-State: AOJu0YwKKYCV3I8VrQc60CQqHS9o6VfoQRYsxknjNzKuCof2VhOqGVYm dY+mfkYqHwaS3bSgcDENWvROcRjRU/xGMedqdC4H4KAJBpmCRlRAwPPfqDQSVCm0smYspwrwB2B jkRnlxus= X-Gm-Gg: AZuq6aJpJI6Pb3P5VKbS2951JFJ/Y1U5xJX3IBkjUVhO+Pw99MMOTLZuXtUeG/w33by M5hB/qX8YUP39CHvkH2N6U1hM2jYxFqeUBqYtpjAdvW+EgrBamp8sGDUYCLlP1oBsaBJ2K86If/ 2OKcN9vwO02t2UM5ZVU6fzEwPiA75v+nMJZjOyZukbCX9Nt1DrKoKaJDjZbig/E6SEuOSBIoGWM N5xpkfJbLIn6wcmAt1zF36zhARoBPLzyf70MlIr8lttbrQ1jX+KgkNpRuycGMKJa/EmEk5kYyRu BekPmseBy2JpH9S6Zj9xUh6Bjg7llUoPqnop++ef/BkmUUn0bwRKo8qGr6GUqNHKz350ZNapk/8 btGkmvQIqr/meQN8VE1iHhLLUT+4D10+K/C7Ie3LKzDkYNsrhIGnI0r7ttnOy7pO4eIIQ5nSmdb mz6MKLfWgXfKr1CvMFdaRdpDPR6w5jVxLWvaoo4RLflTbvkdDa0w2bNUjVOqT5V+pRhXK3SYJsF YkprQ== X-Received: by 2002:a05:6000:228a:b0:430:fd0e:a502 with SMTP id ffacd0b85a97d-4379d61a68amr14266998f8f.22.1771258561718; Mon, 16 Feb 2026 08:16:01 -0800 (PST) Received: from ?IPV6:2a01:e0a:106d:1080:80b4:8b51:72a6:9e2a? ([2a01:e0a:106d:1080:80b4:8b51:72a6:9e2a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a5ac87sm30128089f8f.3.2026.02.16.08.16.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Feb 2026 08:16:01 -0800 (PST) Message-ID: <8e3416cc-4221-4ff2-91ef-9bd55e6bdf0e@linaro.org> Date: Mon, 16 Feb 2026 17:16:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v1 5/5] drm/panel: r61307/r69328: convert to devm_mipi_dsi_attach To: Svyatoslav Ryhel , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260215085140.20499-1-clamor95@gmail.com> <20260215085140.20499-6-clamor95@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260215085140.20499-6-clamor95@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/15/26 09:51, Svyatoslav Ryhel wrote: > Switch to device managed version of mipi_dsi_attach. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/gpu/drm/panel/panel-renesas-r61307.c | 7 +------ > drivers/gpu/drm/panel/panel-renesas-r69328.c | 7 +------ > 2 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-renesas-r61307.c b/drivers/gpu/drm/panel/panel-renesas-r61307.c > index 70bda074dd0d..d8185cc1b5d6 100644 > --- a/drivers/gpu/drm/panel/panel-renesas-r61307.c > +++ b/drivers/gpu/drm/panel/panel-renesas-r61307.c > @@ -261,7 +261,7 @@ static int renesas_r61307_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&priv->panel); > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(dev, dsi); > if (ret) { > drm_panel_remove(&priv->panel); > return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); > @@ -273,11 +273,6 @@ static int renesas_r61307_probe(struct mipi_dsi_device *dsi) > static void renesas_r61307_remove(struct mipi_dsi_device *dsi) > { > struct renesas_r61307 *priv = mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret = mipi_dsi_detach(dsi); > - if (ret) > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > > drm_panel_remove(&priv->panel); > } > diff --git a/drivers/gpu/drm/panel/panel-renesas-r69328.c b/drivers/gpu/drm/panel/panel-renesas-r69328.c > index 0ed143f77e50..bfe2787f8f53 100644 > --- a/drivers/gpu/drm/panel/panel-renesas-r69328.c > +++ b/drivers/gpu/drm/panel/panel-renesas-r69328.c > @@ -217,7 +217,7 @@ static int renesas_r69328_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&priv->panel); > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(dev, dsi); > if (ret) { > drm_panel_remove(&priv->panel); > return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); > @@ -229,11 +229,6 @@ static int renesas_r69328_probe(struct mipi_dsi_device *dsi) > static void renesas_r69328_remove(struct mipi_dsi_device *dsi) > { > struct renesas_r69328 *priv = mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret = mipi_dsi_detach(dsi); > - if (ret) > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > > drm_panel_remove(&priv->panel); > } Reviewed-by: Neil Armstrong Thanks, Neil