From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920AbcHXGkf (ORCPT ); Wed, 24 Aug 2016 02:40:35 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:48651 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753854AbcHXGkd (ORCPT ); Wed, 24 Aug 2016 02:40:33 -0400 Subject: Re: [PATCH v2 1/2] input: misc: Add generic input driver to read encoded GPIO lines To: Dmitry Torokhov , "Andrew F. Davis" References: <20160823061649.3394-1-vigneshr@ti.com> <20160823061649.3394-2-vigneshr@ti.com> <949d92f3-4510-ada5-d3d6-a29544465fd6@ti.com> <20160823200335.GC6712@dtor-ws> CC: Rob Herring , Mark Rutland , Tony Lindgren , Russell King , Arnd Bergmann , Daniel Hung-yu Wu , Grant Grundler , S Twiss , Moritz Fischer , Jorge Ramirez-Ortiz , John Stultz , , , , , From: Vignesh R Message-ID: <8e38becb-137f-7346-258d-1c4dbb890643@ti.com> Date: Wed, 24 Aug 2016 12:09:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160823200335.GC6712@dtor-ws> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 24 August 2016 01:33 AM, Dmitry Torokhov wrote: > On Tue, Aug 23, 2016 at 10:27:59AM -0500, Andrew F. Davis wrote: >> On 08/23/2016 01:16 AM, Vignesh R wrote: >>> Add a driver to read group of GPIO lines and provide its status as a >>> numerical value as input event to the system. This will help in >>> intefacing devices, that can be connected over GPIOs, that provide input >>> to the system by driving GPIO lines connected to them like a rotary dial >>> or a switch. >>> >>> For example, a rotary switch can be connected to four GPIO lines. The >>> status of the GPIO lines reflect the actual position of the rotary >>> switch dial. For example, if dial points to 9, then the four GPIO lines >>> connected to the switch will read HLLH(0b'1001 = 9). This value >>> can be reported as an ABS_* event to the input subsystem. >>> >>> Signed-off-by: Vignesh R >>> Acked-by: Rob Herring >>> --- >>> >>> v2: Use decoder,max-value instead of gpio-decoder,max-value. > > That's not what Rob asked for. "decoder-max-value", not "decoder" vendor > prefix. > Sorry.. Will fix this in v3. -- Regards Vignesh