From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5744837D12E for ; Thu, 20 Aug 2026 18:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787250993; cv=none; b=N3e0EB37n1rDZRXPeNZsQPPiMX4oyfusj6DiVx2cpaV9o0bKDtBlZvCo67Du633KzuVrrBD01oe8i4dfV3jrTjGaCwghVHi8B5quAvvhpunjXVkZQPyQsAl1ayoLZEKt07PRghvDv6k4ugOP+ERCqssBThyXFyJl8P0en8IVg6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787250993; c=relaxed/simple; bh=L5nqpu3ZqFlUyLUMsvX3rrVYOr33g0gJgBhNDeFcm2o=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qQMBqPK7oQanRRU6oz1h9dfAYL3wLkTqINcqeYusNRkggrXg+QGrxfexg55uqwJCwBJwfmLb4aqPsI7oGVCAU3LjEC6IC/5c/z0kqUsCJOXAJbp0bxGib068T/h1UbNapr6lMUv0pVvIUWWnsZkYUtYJlQlLW5tiwK/9TaNZJEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dnur50nz; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yadvn/gx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dnur50nz"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yadvn/gx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787250991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L5nqpu3ZqFlUyLUMsvX3rrVYOr33g0gJgBhNDeFcm2o=; b=dnur50nzRkeiYnfgiHEWjL9ddl22/cCppf7Do3BIwZ0sFa7+Gt2T3GbDS01yuNYBMFxqvC pFPTB63TYSppCapmkq+6Iw55/1Iv99rB3K8OVpzumpjtxTc3ACvVBECk6Raeafcyed+c/z o/N75eBv6soh+JXhpCLfJH7sZgOHvk0= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-jcfFoBaSNPeGJx7uULlG0A-1; Thu, 20 Aug 2026 14:36:18 -0400 X-MC-Unique: jcfFoBaSNPeGJx7uULlG0A-1 X-Mimecast-MFC-AGG-ID: jcfFoBaSNPeGJx7uULlG0A_1787250978 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52ce64c41efso2078371cf.3 for ; Thu, 20 Aug 2026 11:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787250978; x=1787855778; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=L5nqpu3ZqFlUyLUMsvX3rrVYOr33g0gJgBhNDeFcm2o=; b=Yadvn/gxC0nF/LLYZEjR7gI5narInatUztbRwjdXXnUB+HTRWqWlsfpZDLQqiaxLHO nWCWnB6wA9uNNAN6jdQzomrw07bxy60KuaqUm5xHWMLOSmVszcItoAghjQFpNDuSOgW1 VLX4BJf7nNRGpHRrczyRaG8LviI4QikhZ24/qpTb07IRukVKPmsrCrPRVmhEJg1nGqF9 41afUzHWVcs31RLdlzqOAzcLOgnoHrGBEcnIicC4NgVunYdvVscSZoxU2VB81hM5tpQ4 f5NF1FPLV0NddYsIpKh5iAmAzbaIbr0Zg8TtYak/4d4igedfKCzLcfZh1u3aVVAjmeQf RwBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787250978; x=1787855778; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L5nqpu3ZqFlUyLUMsvX3rrVYOr33g0gJgBhNDeFcm2o=; b=qaTXfoEuIcuSNrQ6ykOaMX9hUYMyP4g1uwXblWEass71qlghqox6BvMElv3IIThj3i skZuCxoLp8yJb7B8PDhMWYGJX1mxUDdIPFG4dp+SC0VlVkPSIFleT51Wg+IrfcKcIpPW yw2u1zFveTUR76h/k48qo08a4PSdsl4Q72KyTKYls4Nt6yHa6hP1Xs5sPzgyavIaS5L+ gCbly36z42dyIz8f7PldChGcP/d7HYMfzAVDiXUiycwEB8fH5sfi1fxRVXhTnYrg/jix A3x1Kt/hFugR5X8IQG2t6NU8DbOu6ahx7wciyXCM4Dju7IbuNjVjEbwL1B0wsCChrs3G B40Q== X-Forwarded-Encrypted: i=1; AHgh+RpI71PVN2HWQcId5f4aHLVkD9/U2izJ5dFKlqMqt6mKa0adAhdaqLBNujcHE79iTFBFcmu5BVboTCZ5rsA=@vger.kernel.org X-Gm-Message-State: AOJu0YwL8WA3GP0wtYqyKM45f4ud7pB1IOMLayM2zO6aNyxjdFAuKsXu Fo7pY6LXudY/PjPOUI76fdqRWm3NEZrXSBph3SPKATGd/eVE25gVKdnFHtW5vzxLBZ/VaG9FeMy D+3XYgrnHxNRxOOKOfc1JTiRM0Vpv7sD3FvhVaBwnuexiXBS2PjozH58OyiwfVD7Dpw== X-Gm-Gg: AR+sD13QfzUQMbU3ZTnCwCXWUnUcCjaRC28HUjVbQBDCjoers8fi2iCoc4Ks/SeedMP cuXGRB15hdhDmPVOFM3vr95qpPlKaniCEcxUapddBQtnP0kfkm0M/bcb6hO8Ry1qSRhKkmrRrr8 d0+5ExSyA2xz/eZZ7Iwb+SmIZthpiJnGdpoYz5E2EqRyTY4MH7EIhhUqRW2l+kZxqOMkAceUOGY IP1uR8tKD62uEisSWtG4ebC+xRvEQ9+pBqfkE+NiryKq446DzGqdZHm28Np7boAj35uSeYstM4k suftUV8Ye3W9ArlVQarGDcQCKJcdSVBs11S/WcIEEi+VJT2j+FYmbGSSPx86wLlfs1rmdUc7 X-Received: by 2002:a05:622a:1925:b0:52d:9637:5546 with SMTP id d75a77b69052e-52df5a4f8aamr3812211cf.33.1787250978257; Thu, 20 Aug 2026 11:36:18 -0700 (PDT) X-Received: by 2002:a05:622a:1925:b0:52d:9637:5546 with SMTP id d75a77b69052e-52df5a4f8aamr3811731cf.33.1787250977830; Thu, 20 Aug 2026 11:36:17 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c5edb4f75sm43971916d6.1.2026.08.20.11.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 11:36:17 -0700 (PDT) Message-ID: <8e39067b5dd30b8e345c55bbf156d897322c6e70.camel@redhat.com> Subject: Re: [PATCH 2/3] drm/nouveau: cancel the DP IRQ work before freeing the connector From: lyude@redhat.com To: Marek Czernohous , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: sashiko-bot@kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich , David Airlie , Simona Vetter Date: Thu, 20 Aug 2026 14:36:16 -0400 In-Reply-To: <178682657122.3795552.6920623796751043528@gmail.com> References: <178682366001.3748010.7798811159846779765@gmail.com> <178682366002.3748010.4096452389040554615@gmail.com> <20260815201130.7BDDF1F000E9@smtp.kernel.org> <178682657122.3795552.6920623796751043528@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-08-15 at 22:42 +0200, Marek Czernohous wrote: > But the wider question the bot is asking is fair, and my cover letter > answered it too confidently.=C2=A0 It says "there is no fourth patch here= " > on the strength of drm->hpd_work being drained in > nouveau_display_fini().=C2=A0 Having looked again after the bot's mail: t= hat > drain runs at nouveau_display.c:600 under "if (!runtime && > !drm->headless)", and disp->fini() drains it a second time under the > same condition (dispnv50/disp.c:2686, dispnv04/disp.c:72, which I had > not spotted when I wrote the cover).=C2=A0 Both of those are before > drm_mode_config_cleanup() reaches nouveau_connector_destroy().=C2=A0 So a > late irq_work really can re-arm hpd_work after every drain, and nothing > drains it again.=C2=A0 Whether that is reachable in practice I do not kno= w: > nvif_event_block() on conn->irq has already run by then, so it needs > work that was queued before the block and has not run yet. Actually - after rereading this again, nah - this isn't an issue. So long as the connector IRQs are blocked at that point, it should be good. MST connectors aren't, but that's also fine - they use the IRQ notify thingies of the non-MST connectors, so they're indirectly blocked by that.