From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 6/7] xen/events: modify internal [un]bind interfaces
Date: Tue, 14 Nov 2023 13:45:02 +0000 [thread overview]
Message-ID: <8e3a25c3-e355-47d4-a9ce-d38e8a9375d4@epam.com> (raw)
In-Reply-To: <20231016062831.20630-7-jgross@suse.com>
On 16.10.23 09:28, Juergen Gross wrote:
Hello Juergen
> Modify the internal bind- and unbind-interfaces to take a struct
> irq_info parameter. When allocating a new IRQ pass the pointer from
> the allocating function further up.
>
> This will reduce the number of info_for_irq() calls and make the code
> more efficient.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
I didn't spot obvious issues with current patch, other than just the
fact that patch needs rebasing (some hunks cannot be applied because of
"e64e7c74b99e xen/events: avoid using info_for_irq() in
xen_send_IPI_one()" went in).
I was going to ask why "pirq_query_unmask()/pirq_from_irq()" wasn't
converted to take a struct irq_info parameter as well, but looking at
the rest I noticed this was already done in subsequent commit.
With proper rebasing:
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
[snip]
next prev parent reply other threads:[~2023-11-14 13:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 6:28 [PATCH 0/7] xen/events: do some cleanups in events_base.c Juergen Gross
2023-10-16 6:28 ` [PATCH 1/7] xen/events: fix delayed eoi list handling Juergen Gross
2023-11-13 13:51 ` Oleksandr Tyshchenko
2023-10-16 6:28 ` [PATCH 2/7] xen/events: remove unused functions Juergen Gross
2023-11-13 14:20 ` Oleksandr Tyshchenko
2023-10-16 6:28 ` [PATCH 3/7] xen/events: reduce externally visible helper functions Juergen Gross
2023-11-13 15:53 ` Oleksandr Tyshchenko
2023-10-16 6:28 ` [PATCH 4/7] xen/events: remove some simple helpers from events_base.c Juergen Gross
2023-11-13 17:35 ` Oleksandr Tyshchenko
2023-11-14 8:28 ` Juergen Gross
2023-10-16 6:28 ` [PATCH 5/7] xen/events: drop xen_allocate_irqs_dynamic() Juergen Gross
2023-11-14 8:20 ` Oleksandr Tyshchenko
2023-11-14 8:35 ` Juergen Gross
2023-11-14 18:29 ` Oleksandr Tyshchenko
2023-10-16 6:28 ` [PATCH 6/7] xen/events: modify internal [un]bind interfaces Juergen Gross
2023-11-14 13:45 ` Oleksandr Tyshchenko [this message]
2023-10-16 6:28 ` [PATCH 7/7] xen/events: remove some info_for_irq() calls in pirq handling Juergen Gross
2023-11-14 18:16 ` Oleksandr Tyshchenko
2023-11-15 7:41 ` Juergen Gross
2023-11-13 7:14 ` [PATCH 0/7] xen/events: do some cleanups in events_base.c Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e3a25c3-e355-47d4-a9ce-d38e8a9375d4@epam.com \
--to=oleksandr_tyshchenko@epam.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®