From: Kishon Vijay Abraham I <kishon@ti.com>
To: Alexandre Bailon <abailon@baylibre.com>, <david@lechnology.com>,
<b-liu@ti.com>, <balbi@kernel.org>
Cc: <khilman@baylibre.com>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <nsekhar@ti.com>
Subject: Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY
Date: Thu, 3 Nov 2016 23:20:16 +0530 [thread overview]
Message-ID: <8e3c9209-9db0-c288-5b3d-3d29f1571e47@ti.com> (raw)
In-Reply-To: <73d3cf2c-2653-15a3-9fa6-755bed419ec2@baylibre.com>
Hi,
On Thursday 03 November 2016 10:56 PM, Alexandre Bailon wrote:
> On 11/03/2016 05:34 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote:
>>> The USB PHY is able to operate in OTG, host or peripheral.
>>> Some board may be wired to work act only as host or peripheral.
>>> In such case, the dr_mode property of controller must be set to
>>> host or peripheral. But doing that will also configure the PHY
>>> in host or peripheral mode whereas OTG is able to detect which
>>> role the USB controller should take.
>>> The PHY's host or peripheral mode are actually only useful when
>>> hardware doesn't allow OTG to detect it's role.
>>>
>>> Add the usb20_force_mode property to force the PHY to operate
>>> in host or peripheral mode.
>>
>> I think we do just that if we populate dr_mode with host or peripheral. Why do
>> we need another property to control dr_mode property?
> Because the phy doesn't work correctly when it is in host or
> device mode.
That would be the same even with usb20_force_mode property. How does
usb20_force_mode property help?
Thanks
Kishon
>>> When usb20_force_mode is used, dr_mode should also be configured
>>> to host or peripheral.
>>> The controller uses dr_mode to configure itself, but the phy use
>>> it to get the mode to use to configure the PHY mode.
>>>
>>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
>>> ---
>>> Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
>>> index c26478b..9fc87fb 100644
>>> --- a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
>>> +++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
>>> @@ -4,6 +4,11 @@ Required properties:
>>> - compatible: must be "ti,da830-usb-phy".
>>> - #phy-cells: must be 1.
>>>
>>> +Optional properties:
>>> +- usb20-force-mode: Force the phy to operate in same mode than the USB OTG controller.
>>> + It should only be defined if the hardware is not capable correctly
>>> + detect the role of USB by using VBUS and ID pin.
>>
>> From what I understand from the previous patch, if VBUS sense and the session
>> end comparator is enabled, the controller can work in host mode or device mode.
> I but VBUS sense and and session end comparator only seems to work when
> the phy is in otg mode.
> In host mode, the phy stop to work after the first disconnect.
> In device mode, the phy never detect a disconnect.
> In otg mode, these issues go away.
> I'm working on workaround for both of them but I think it is
> better to keep the phy in otg when it is possible.
>>
>> Thanks
>> Kishon
>>
> Thanks,
> Alexandre
>
next prev parent reply other threads:[~2016-11-03 17:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 15:26 [PATCH v3 0/5] usb: musb: da8xx: Fix few issues Alexandre Bailon
2016-11-03 15:26 ` [PATCH v3 1/5] usb: musb: da8xx: Call earlier clk_prepare_enable() Alexandre Bailon
2016-11-03 15:26 ` [PATCH v3 2/5] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround Alexandre Bailon
2016-11-03 17:00 ` David Lechner
2016-11-03 15:26 ` [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY Alexandre Bailon
2016-11-03 16:34 ` Kishon Vijay Abraham I
2016-11-03 17:26 ` Alexandre Bailon
2016-11-03 17:50 ` Kishon Vijay Abraham I [this message]
2016-11-04 11:07 ` Alexandre Bailon
2016-11-03 16:53 ` David Lechner
2016-11-03 17:33 ` Alexandre Bailon
2016-11-03 17:53 ` David Lechner
2016-11-03 15:26 ` [PATCH v3 4/5] phy: da8xx-usb: Use usb20_force_mode property to configure the phy mode Alexandre Bailon
2016-11-03 15:26 ` [PATCH v3 5/5] usb: musb: da8xx: Remove set_mode callback Alexandre Bailon
2016-11-03 17:18 ` David Lechner
2016-11-03 17:27 ` Bin Liu
2016-11-03 17:42 ` Alexandre Bailon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e3c9209-9db0-c288-5b3d-3d29f1571e47@ti.com \
--to=kishon@ti.com \
--cc=abailon@baylibre.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=david@lechnology.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®