From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD09CC433F5 for ; Wed, 6 Apr 2022 10:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240568AbiDFK6z (ORCPT ); Wed, 6 Apr 2022 06:58:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348349AbiDFK5I (ORCPT ); Wed, 6 Apr 2022 06:57:08 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96C62519D40; Wed, 6 Apr 2022 00:18:30 -0700 (PDT) X-UUID: e222855c284d4624a897c4833d159510-20220406 X-UUID: e222855c284d4624a897c4833d159510-20220406 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 340841123; Wed, 06 Apr 2022 15:13:19 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Apr 2022 15:13:19 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Apr 2022 15:13:18 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 6 Apr 2022 15:13:18 +0800 Message-ID: <8e3db8a1285e43dcd397eee444b15957074106ab.camel@mediatek.com> Subject: Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c From: Rex-BC Chen To: , , , , , , CC: , , , , , , Date: Wed, 6 Apr 2022 15:13:18 +0800 In-Reply-To: <1648727917-3099-3-git-send-email-xinlei.lee@mediatek.com> References: <1648727917-3099-1-git-send-email-xinlei.lee@mediatek.com> <1648727917-3099-3-git-send-email-xinlei.lee@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote: > From: Xinlei Lee > > Add the compatible because use different .data in mt8186. > > Signed-off-by: Xinlei Lee > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 4554e2de1430..6fac146cf1fb 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = { > .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), > }; > > +static const struct mtk_dpi_conf mt8186_conf = { > + .cal_factor = mt8183_calculate_factor, > + .reg_h_fre_con = 0xe0, > + .max_clock_khz = 150000, > + .output_fmts = mt8183_output_fmts, > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), > +}; > + Hello Xinlei, Could you move 8186 between 8183 and 8192? > static int mtk_dpi_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] > = { > { .compatible = "mediatek,mt8192-dpi", > .data = &mt8192_conf, > }, > + { .compatible = "mediatek,mt8186-dpi", > + .data = &mt8186_conf, > + }, ditto BRs, Rex > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);