From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A83A44A725 for ; Thu, 7 May 2026 15:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168105; cv=none; b=K0XMPxRUxZ0nvfkfG4wrAfjdXzPMZHInVPoG8R3o5CbbcDX2giVmbyqsG3CpO6hxKKpf0kmxaP3ifObzMo4FmHimWfj5lY6FslknZxiVfM3x0Y3nxCouEw+a+NVqB4CZP4jSAsxLfsTXufPqlGJqYguibGRTOoyWXE3uxl9CwWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168105; c=relaxed/simple; bh=Qg23k9XVwDZisiszcYvsrLBtTslL6oLv4SrJJnApHUg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=gzH1YRuYsNIIra4alF09YYMvr1d8F325Hzw9/27c25KVWkjz7DiP79MdUML70mWpJxwMilailSBzuzsRSOrDE5iyEaq6otl9p/ZAmahJqrT9SIlCsQV+xWCtMH9+Ro+tsbe4FtRCdS1+2jc++Epo/0LHNS1WsxwNxXx6OCG1QT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LqMlT9S8; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LqMlT9S8" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so8810155e9.0 for ; Thu, 07 May 2026 08:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168101; x=1778772901; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=qviuCjYgg89dp4Zj0iDLZr+bYb7DPV34z48Pa7dHTMc=; b=LqMlT9S8Rftt/7O3rIi98suDwfpDnOdAcCyJBaTfF0bELdbrGdIOPuZPL8tx3S5QWv QtEtmwnY0i1Jqh2tv8lTz3oFCs+isEkyEBs+SNXQ/DbdiDjHejGFMAzHLqy+OcKWP4Of QUeLoHOMKykKAkToc2JOxMvwYktcnfGi8gqhcVOmYRrl10Jg7ldTohG5m0GbxS8/3/eq jkXzGcOyDQTxGigmVKRaJpE10fPS8Oeoik5YeNonsdd6SMQNOQeDnf7LiBSh3vkDf0Hn CZKesfCh/nsTZZqHbwOMsw6g3M+CbhYXOJoTLgA8Au332BhEfhTGRYbF8dQsKsk+Q9Ao go2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168101; x=1778772901; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qviuCjYgg89dp4Zj0iDLZr+bYb7DPV34z48Pa7dHTMc=; b=josqdUhGrYvz72+45l+osDvrbXYIV0bL8NHh7IH5CeZAYWymifFwcV/8O/0o9EjXk1 YYnl/IG68LD4/aImXzxvfzs8PNsoqeyz0u/rsS37k5aNVKQXQMNX6/EcMIJ8/g62EeN3 WUAkuvD+XTGC82r8XvgBLbJ7+KLtsSG6zQL8ySLlTSYq7UaX/J4QjM9aE3QHy5XRnlU8 Cvibu7VIHNb0JEOb+3bG1BcQNzElCZGhq/URmMOG48fI8/0nWKacsxmOhk1uiOrXIyTo TiZLJMT4p6877Z56NEs87HsdxM9sNHpMph6LFOt1mCBv4wwKdHcPhekhFnRRSxHMcSn1 ResA== X-Forwarded-Encrypted: i=1; AFNElJ+kL4nReOEPd869Eq26XzzWR9VHc7VzYwb1dKFXSp09GPi/gx2cXbCFrD6Svq+kFkFV6B2H9pElNmhCibE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyp6V81KRVJRz2nmp06W9yEVx9myGHPVimXuLMyfUq5sUrCumeG oJd9+msNwPZC5WCmVGjyHwyAAbrMBEm6cyw+t2kuEwTGCfVeVdw1Jx5FWCdm1J/EM3o= X-Gm-Gg: AeBDievfLzIQNOZjWdFDys/C8Z6mwUSV79rbbmK9Uz6xW6fnWEgBoQK8URvpDtN/y4A r8GLS1QRY7jsMwvvCU/Almbai0jYD43Cm6nr/H7f7EAjS90bqJrSQ0EjlyL/V9aBlJ2YjtLUlJg rbsrQ+9oLERTkXiTsIr9OctjHCHYyb3F+fahQX4W2AdylZbOoTnZCbHAU/HkRprLuowEfJ+yUhc o9g4tXp5u48K8Mc+fT9PP4McfMnpAtrjUTqMSq8Wa60+3VeRfyPsXHl9nx2Pkfki2MkxYjMHDA7 UccHGaQdJWm2gm9KbXmkXTj+lZhsP8ImLUpD8+GunvKOsL2aN/ucFfk/h8+/pmylAiZHj/DUHSW mjYW5tc1qjrWwiaXSgo7ETAcDyrOHRwChq+xF9NX/wFeLSm5JM03bN8E/BG0veNGSZWKs6bD5Xy sXzw7SRO+1t7obv0GbEaBWc5rEJaxAWmpHDsC+WqYNRS/sDZF4c7k7ITDGsyMUb1XAxzMo75+S4 QQ9aHuvNLne52oGtQ== X-Received: by 2002:a05:600c:a110:b0:488:9e43:9690 with SMTP id 5b1f17b1804b1-48e51e17746mr108372715e9.10.1778168101138; Thu, 07 May 2026 08:35:01 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e538a8159sm140909335e9.6.2026.05.07.08.35.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:35:00 -0700 (PDT) Message-ID: <8e401d8a-728d-447a-b647-b21da6849ea7@linaro.org> Date: Thu, 7 May 2026 17:35:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 02/10] drm/panel/samsung-s6e63m0: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-2-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-2-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c > index ea241c89593b6..997115b1e541d 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c > @@ -677,9 +677,13 @@ int s6e63m0_probe(struct device *dev, void *trsp, > u32 max_brightness; > int ret; > > - ctx = devm_kzalloc(dev, sizeof(struct s6e63m0), GFP_KERNEL); > - if (!ctx) > - return -ENOMEM; > + ctx = devm_drm_panel_alloc(dev, __typeof(*ctx), panel, > + &s6e63m0_drm_funcs, > + dsi_mode ? DRM_MODE_CONNECTOR_DSI : > + DRM_MODE_CONNECTOR_DPI); > + > + if (IS_ERR(ctx)) > + return PTR_ERR(ctx); > > ctx->transport_data = trsp; > ctx->dsi_mode = dsi_mode; > @@ -712,10 +716,6 @@ int s6e63m0_probe(struct device *dev, void *trsp, > return PTR_ERR(ctx->reset_gpio); > } > > - drm_panel_init(&ctx->panel, dev, &s6e63m0_drm_funcs, > - dsi_mode ? DRM_MODE_CONNECTOR_DSI : > - DRM_MODE_CONNECTOR_DPI); > - > ret = s6e63m0_backlight_register(ctx, max_brightness); > if (ret < 0) > return ret; > Reviewed-by: Neil Armstrong Thanks, Neil