From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Markus Elfring <Markus.Elfring@web.de>,
Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
linux-sh@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: dma-sysfs: add missing put_device() in dma_create_sysfs_files()
Date: Sat, 20 Dec 2025 15:11:06 +0100 [thread overview]
Message-ID: <8e412a9834ced553c4eb757362a122d26f16213f.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <8552e5b2-16ea-42d9-978e-5d26ad0b1f15@web.de>
Hi Markus,
On Sat, 2025-12-20 at 14:56 +0100, Markus Elfring wrote:
> > If device_register() fails, call put_device() to drop the device
> > reference. Also, call device_unregister() if device_create_file()
> > fails.
>
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc1#n659
>
>
> You propose to complete the exception handling for two cases.
> Is there a need to indicate such a detail in the summary phrase accordingly?
Maybe I'm completely missing something here, but I find the description short
and reasonable. As the SH maintainer, I haven't started reviewing these patches
themselves yet, I definitely interested to understand what the problem is.
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2025-12-20 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 6:28 Haoxiang Li
2025-12-20 13:56 ` Markus Elfring
2025-12-20 14:11 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e412a9834ced553c4eb757362a122d26f16213f.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=Markus.Elfring@web.de \
--cc=dalias@libc.org \
--cc=gregkh@linuxfoundation.org \
--cc=kay.sievers@vrfy.org \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®