From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0F82D6400 for ; Thu, 9 Oct 2025 09:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760001735; cv=none; b=hsRyjoAF+WvEqycYhJoinx1IOy9xqtgjnVaw+iuztkxCfDZWdylXPVCLZiC6GNWzHjdoAd+NO0+hZp/XDOd/ywPUKXnAqYYiNgxYS8/CrnuLPrA+tSrGMlNY3CeoPyzcjp9N+vNR5STptoTYCBO1D0fb/YTblZhDIUQ0X165nXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760001735; c=relaxed/simple; bh=m7sGX8LqCBcYJzEU1J2asHkmcl3RgvVNGFVvSyqxM80=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TXPgSQnj7VxQ7frqElH9Jd827baFVQgYARpdE8C00Z+lrzjzOYogHCkc+gamlYB/yjK66v37dq4e/kKPkHZBVBc0fecFkhzKE5Rit95MtNxEULbLz/bg7LX5SJEcxLHzt9xe+bqRspkxEj87rzu2yujviolpIMP99IihHwZ8xdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VnUtvOoY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VnUtvOoY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5996F4vo006539 for ; Thu, 9 Oct 2025 09:22:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3T3F6rzbdmMoNWAMnngme3yze4tyxfjIoIeOdL7FrsY=; b=VnUtvOoYef6BeyDh OTKFhLq3V9F1shdLdIxD8fVMC0o1z3NstclYDBqMCIa9xqApxl5ZnvvfcGw3rRbJ 4u+iRhtnm5EwIaa6N48mDdYFeq7Y46G/0MhaEMvncRhLyTqFMPPjEopLkN5UTmvw xHUXJ8Qoe0vYCkDQW05hrZW2XK5rwxsz+EFGE0jIsIpwgSVM6mGUf1aLSbs8xX5D b6Ei8IzzW1+80we+b9r1oTPsGAqIDSQTc8E0RwJ9E40IPZDZRiGIdZK3wccJkLLa LqdnQ+XdphUDyLpiVTgDE2mZ4aeL3p8B8g3Z3V7OeqmNj8Dx78pfYHB/X3lbKM7E nZIsRg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49nv4u27jn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 09 Oct 2025 09:22:13 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-819d2492a75so41159285a.1 for ; Thu, 09 Oct 2025 02:22:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760001732; x=1760606532; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3T3F6rzbdmMoNWAMnngme3yze4tyxfjIoIeOdL7FrsY=; b=sIolqjDl0suv7hZZANoTjcZAA3JdgV7X5Z932kTGW2ff7mGVQqL2jz/U9bQIU4QGOs OE5RF0EL5G4q6IoSWfRy5S5h9YHhhqUviwbqJiCewplKNBDz+sp9BRcuXZDM14OXDXJe nAjInN/nE1S2yVFnS43L6iTw39ITeQpnwf+/BDdEw8eHpIf/0dRsTNntrh3ScrDuaSJL OTEjll7IafdqJmey7MC+FaQ9xtICSlhLNKpC3ksrG7VzuYXfwfbnol9z7nmo8d6d+KM3 HSYHFgIRjzrG749navPkb9ckH67fvurdKuKajvD/6FO2TFo/pTHKgNWFJrtl4mUGe86/ gDjg== X-Forwarded-Encrypted: i=1; AJvYcCXtXX27i0CEm0d+1RvzoxTl4wPvhZUIHpTv99EHcpIjAamC1M+MZmLWSZAoB+WtCkLIWPnjmKhRNmf0IwU=@vger.kernel.org X-Gm-Message-State: AOJu0YydXIVnisS5EBxpsm0VJyyiYxClbfdB6T6kRb5cSUbcAHXsf8co rOGo/9YEAS7FUmXHuiOfS6sW6qbxReM2xGJIcUg/0P1x+hw3Lov4JvgRFl0fwH79PZNXeSAh6H/ SvmQdX0xomIK+2Ek/VkPEAGLAmCyhIj2wQXnhMaIlglSuOs15urvLOBXLLIbudnnQDFM= X-Gm-Gg: ASbGncvoE+O0UfLK/mVuIAXQCL+kGsdHT1zih8sNeMFZYyxPvBd3IPUI1hpzs14g9Ng w0PreJCC6qG+ISOQkgmIRZVFf73B9AEIQ/HxfK/7gaEZoU7QlXy854ZK8K5bBdgozqdg8PSEPQ4 ljGesbiB1hwgCAIge27kVEwLZptMf68aZsUZvSTOd9z++Ehvic6/s7bPjjMyMPNVrqdghhdKtWY G2ecuLlHsgInsI83L0hjxCFe4p2N/PXwHnQHMwYvsOBzUoxe/xGYckf1Q8OL3i6BIUXuodY5u/m gPeYh1aLH3QBZ3lkvFSWWobzWMey1MG8VBmQ1corrXbPpmE1dVVVEO4KORycnec0ZgrzVBKEZqE 6bCEzdnBlE+1jbe/U6s/fkqtY/Wg= X-Received: by 2002:ac8:5991:0:b0:4dd:1a2f:4881 with SMTP id d75a77b69052e-4e6eacb81b2mr64073811cf.6.1760001731540; Thu, 09 Oct 2025 02:22:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2X7icy3lg+xeOQgJOky5fWzmyU3gLm0qGfVSTXdz1EXkq1QfNAExgoimdotZtxhJlPB+i0g== X-Received: by 2002:ac8:5991:0:b0:4dd:1a2f:4881 with SMTP id d75a77b69052e-4e6eacb81b2mr64073621cf.6.1760001731041; Thu, 09 Oct 2025 02:22:11 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-639f2d60816sm1934249a12.0.2025.10.09.02.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 02:22:10 -0700 (PDT) Message-ID: <8e452e51-3a95-49e6-91e3-53aa46fcfe2e@oss.qualcomm.com> Date: Thu, 9 Oct 2025 11:22:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] arm64: dts: qcom: qcm6490-fairphone-fp5: Add VTOF_LDO_2P8 regulator To: Luca Weiss , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250930-sc7280-dts-misc-v1-0-5a45923ef705@fairphone.com> <20250930-sc7280-dts-misc-v1-2-5a45923ef705@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vrcuwu2n c=1 sm=1 tr=0 ts=68e77ec5 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=6H0WHjuAAAAA:8 a=-BH9GnAZmLL9hDugqCUA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: cFuW71tUF0YprtwKC3DAVU2yV5cT0Xtl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA4MDEyMSBTYWx0ZWRfX9v76kbCVOirc buHjIqOQAlLkWanx3jUsbP5mwwFIbdoks7JP6eQypU0TkSy+EhSeQWfVvJa0c9TJX6EsDxMbYri C0KT3YkwlHr07SulEAmR/FrQCJmyVfIZQ/4n/GhkshNZUazIMT0HsixHneM9uw0G6To9H/5TVI1 aqwDEFyCwmL58zWiRwHJH8bsEGlIMHT19+Iom1OPCTzTd41uLP+toYMQKqxWae2DX99+f3ItrNc WlM61PPystF8KSOryY+905L9KFHf6/nvdR5DheaXHzA1o63RPmIZlXJWjN79aMuWVKa23lt+XO1 0pDuy7DMYbfnmdbN/wPrus877VJSIfpBrZTvTa4p7jvansbV+kHAWULLxDzpIpomzac5c3CaRKA IQrwb/ClxcSWOont228cDV91fHHtvQ== X-Proofpoint-ORIG-GUID: cFuW71tUF0YprtwKC3DAVU2yV5cT0Xtl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-09_03,2025-10-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 clxscore=1015 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510080121 On 10/9/25 11:16 AM, Luca Weiss wrote: > Hi Konrad, > > On Wed Oct 1, 2025 at 10:30 AM CEST, Konrad Dybcio wrote: >> On 9/30/25 3:57 PM, Luca Weiss wrote: >>> Describe yet another regulator-fixed on this board, powering the ToF >>> sensor. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >>> index 36d5750584831d66b4c2faf6042e4cbb3274eca7..0a64e5721e092d1f3e4bb7329335704eee567761 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >>> @@ -195,6 +195,19 @@ vreg_usb_redrive_1v8: regulator-usb-redrive-1v8 { >>> pinctrl-names = "default"; >>> }; >>> >>> + vreg_vtof_ldo_2p8: regulator-vtof-ldo-2p8 { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "VTOF_LDO_2P8"; >>> + regulator-min-microvolt = <2800000>; >>> + regulator-max-microvolt = <2800000>; >>> + regulator-enable-ramp-delay = <233>; >>> + >>> + gpio = <&tlmm 141 GPIO_ACTIVE_HIGH>; >> >> You may want to define the pincfg/mux config for this gpio too > > While I wouldn't say it's not good to have it, there's plenty of GPIOs > that have no pinctrl for it. Downstream doesn't set anything for gpio141 > either. > > I honestly wouldn't even know what the 'default' for a GPIO is in the > first place, or could I query the runtime state from the kernel? Is > /sys/kernel/debug/pinctrl/f100000.pinctrl/pinconf-groups trustworthy to > solidify this in the dts? I normally use /sys/kernel/debug/gpios > > 141 (gpio141): input bias disabled, output drive strength (2 mA), output enabled, pin output (0 level) but this seems to be formatted very similarly if not identically Generally it reads out HW state, via (among other things) msm_config_group_get() Konrad