From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Yuvaraj Ranganathan <yuvaraj.ranganathan@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: kernel@quicinc.com, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] firmware: qcom: scm: add trace events for the SMC call interface
Date: Thu, 21 May 2026 14:03:34 +0200 [thread overview]
Message-ID: <8e465091-a50b-47be-a276-4436f8886fe0@oss.qualcomm.com> (raw)
In-Reply-To: <20260506-scm-tracepoints-v1-1-4bc983264014@oss.qualcomm.com>
On 5/6/26 12:37 PM, Yuvaraj Ranganathan wrote:
> The SCM SMC call path is opaque at runtime. Stalls caused by firmware
> congestion, QCOM_SCM_WAITQ_SLEEP/RESUME cycles, and EBUSY retry loops
> are invisible without recompiling the kernel with temporary printk
> statements or attaching a hardware debugger.
[...]
> + TP_fast_assign(
> + __entry->wq_ctx = wq_ctx;
> + __entry->smc_call_ctx = smc_ctx;
nit: these tabs-before-assignments seem forced
otherwise I think this looks good
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-05-21 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 10:37 [PATCH 0/2] firmware: qcom: scm: add tracepoints " Yuvaraj Ranganathan
2026-05-06 10:37 ` [PATCH 1/2] firmware: qcom: scm: add trace events " Yuvaraj Ranganathan
2026-05-21 12:03 ` Konrad Dybcio [this message]
2026-05-06 10:37 ` [PATCH 2/2] firmware: qcom: scm: instrument SMC call path with tracepoints Yuvaraj Ranganathan
2026-05-21 12:03 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e465091-a50b-47be-a276-4436f8886fe0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuvaraj.ranganathan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®