From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE0D23E2AC9 for ; Tue, 25 Aug 2026 08:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787646679; cv=none; b=TP2kTswSxzwhaelDao5yVNdr4WCUPNeI6PqCJPL5bmcSymLakHwVsgoXMYKE9DMe6DMfkfi/7gN/q5On5Vgde8uewM0/ZfPQuFU83TBl0VwN6i5KA3jMnHBK1+gOZ1nmbo4fqdCbPGnep1BwxMQpy6XSbIjqwtgned/vJoFdqyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787646679; c=relaxed/simple; bh=1OcT/+68aFgiyGo/IZHJDt9O/nR3cz/ZEzkgZtmV+50=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oUWUP/AA3AKv1+5raKdBYTQ/UCYVg1XkoSky58x6tMZweKhPOkqI/CglX83CuYElYdCU5jq7xcQY9RODDEkzzZjzeq9RtW08cuI77c07tPQ6UqAnVdp9iyW/995Sc0aeIGjfnlRLElTVrxmFXaKLPWnvh3Xi/y0VDuEgB4tqn0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KDApZ35E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PvS6iV4u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KDApZ35E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PvS6iV4u" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P88IfD1706717 for ; Tue, 25 Aug 2026 08:31:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0XQbf5evE2zhZ7gWH4294Whbd+Ksxk5D6CkMg8YLsEs=; b=KDApZ35E37DJ2vhp 7Muf78TYL43ahPAlTa/ldTntpZQtdZdPgPJqu9+PuV78ZRj4e6J/DD2+tyBaOPH9 QqcZZT02Z3QNRFXwZeWJW1Ek+aIaHqWtpCFfLCFlUeo6/ishkljVg9a8yKxGYHuR q1vrCaoqGvxQBlNn+U1PtP+L6+qBbKTDaQK1oI0ri+jU4nozheNKVThig+eVWO9C odUfQc3GjX+gRsct+EUqBhluIMRKtNwSyj9rYdUwMymvJw07wCQcKWzli4ud7KUf zQqmLenGMy9h1lPdJKqn9NXQK9RKDMe6vZtdwu0IC0TcAmiBgx9UaYeFILbwCRO0 g1RIew== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g93kvryhs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 08:31:16 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cbee5bab340so6125954a12.2 for ; Tue, 25 Aug 2026 01:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787646676; x=1788251476; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0XQbf5evE2zhZ7gWH4294Whbd+Ksxk5D6CkMg8YLsEs=; b=PvS6iV4uj/ZMhjyRAmWWbE8JWcgL5PRjmIp+h6GwgBqelAw42TiS2/tukoaguaOIuV QZBxbmV6ytwCIeRgV66KDxlDws3tUzf7OrUCvU+cVxr4dq9XMRXmychkLBFBpbrqcama XQ1yA+mVhvG3pqcRG4MD5ySJFH8BrBimKMQiAh86dtWv5GNDWuDPfQnTAfPJvx4QLIti zY2uwJZujCaf8e9VhSyPEaX7s6DKxeK9TKFtwsRFRyfES/iZdx3DBHVdTnFN0H8QccwO 3N6LrnBIoLwxpuGn/CjekKb2yil+PmdH/SjSqAkNpGaEYCwE9N6AIxUFxZAQp83LDw1j SJCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787646676; x=1788251476; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0XQbf5evE2zhZ7gWH4294Whbd+Ksxk5D6CkMg8YLsEs=; b=kCrwhPNk3ogAqkgGyZ2MUc5PGCZZEz7wCIlbe+bFgSlPcdYekSO2MhkE4GV9AdCili 6yx6fUiMeX9Vs5EORpVqDoPfhdQCTNfCb8uLvVL0dUS3E7gsnSaWXb/X8S0DeH8Luy9/ 1x9902U3ErQcVy66zm/TgkF15H7S3dzuMBRJaUYq5Y4VqnJrtI6v5/npaLxnQyYeCVch xXmFNaTsDIh1PYiJxwEbBO9tm0+4paecbYZWo1NHELJw1teL0RI3LsDAM7rEL0n7Eo2B Vbg/sa3IFslPhDZgp/8h2sdxd16tAPT+hFWU1oTySN/x77NCzqn004SM+e8XfIw3s96Y 29cQ== X-Forwarded-Encrypted: i=1; AHgh+RoipnJEUlTxkfCAkHVUbq/p03IPvo6RJykidCjS1nXCgngpqs+6NXEx+8xEXchN6IJf4pwUDbSPZMYFUuk=@vger.kernel.org X-Gm-Message-State: AFuF++lKL18sZCOC3+dgPXfByAoCmk+zny40Qj1onLuYhTBFy2upYLwM OD4yTBLILrAc02cIKASJ/yOejHNtFF3De6jaPZ5c++u6sJgvx9XhMotOgeM7zCLFz6vExPVAMLN XAYGxpNhDcJghpe2ztvqr85SXaGofWf9eAKgZzPBJARFARGpIv6SeHWNHMlchYB6NpRg= X-Gm-Gg: AR+sD12MB4sIeWX8PW7aV6NbDHQAfabLtkYC+QgRHD3Ef+T9WL+gjLGEdWlHdYoJ2GN BZ3+sx5hhO31+LlnYvnJRcunZbY3gUYNUbZGImBR5uk0W8NcQDKxZI+vLH5blxV8rnJtAUd7ZXU lbms/ZRDv4SqpEybg2wKOkdd4975g5rblgj+IFtnjRkfUl16joI+xKagYtQHcMWD0VbCol+fOMd PBnX4hr6bvk+DqJpMqX1blfvA1TKGpDaraERd2VpbNh4RATNP/ClRv6mnS7UohoMl3gUuLjPUhE AEUSA4U6b8hnnxpcxxXZLGl8Zj9AVbBFrbXqUhAb9oqNCv0zcwa/96OCDcg8RjUgusxHZ8vDbQk jy50Wh74TGU/m75xyN4dYVW7nSo5qtP6hFwI= X-Received: by 2002:a17:902:e943:b0:2d6:3c2f:69b with SMTP id d9443c01a7336-2d64af6f8cemr618485525ad.8.1787646675690; Tue, 25 Aug 2026 01:31:15 -0700 (PDT) X-Received: by 2002:a17:902:e943:b0:2d6:3c2f:69b with SMTP id d9443c01a7336-2d64af6f8cemr618484565ad.8.1787646675240; Tue, 25 Aug 2026 01:31:15 -0700 (PDT) Received: from [10.217.218.158] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d6767ac8c6sm25061425ad.34.2026.08.25.01.31.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 01:31:14 -0700 (PDT) Message-ID: <8e4684d0-d130-4c75-8b28-11fd98fc4a29@oss.qualcomm.com> Date: Tue, 25 Aug 2026 14:01:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spi: qcom-geni: rename setup_fifo_params() to setup_spi_params() and make it void To: Viken Dadhaniya , Mark Brown Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260824-spi-qcom-geni-cleanup-setup-fifo-params-v1-1-bdf98ae62953@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260824-spi-qcom-geni-cleanup-setup-fifo-params-v1-1-bdf98ae62953@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA3MSBTYWx0ZWRfX1y3AcpvivqXB OjQBUQmA0wbmEv/o3/HjyTR7R7JLCSBBcghZE+q6gNGrIkWjspGrd1rD3uCSyegJolfnOBaRwBN sqG6JqaB/hUPDhGp4CFoWRu3aaifdge2CjGhbkJdNQKvBca+3orqdfqH9h0CNVQjwtTL0KtDFAc BHfY3asYhVEhED/jL/PtFWO42/COY2ytfPPjU1wNeqUmYDbnE+20wgw3jaBEwiFGisxQAK9jEyk OPLt9P54hE9icaEqnkhEfy3xAYFBqyXJLFvKNC/8qv85rXZCbu1OurbMWz5hI5Ujq53QwCcYnGk x/LUygQ8fiz9+OHKSnyxDutjB9VKj/sp8dXmpjiRO5mbd+HVKndQDRbykktkTbCtwY33OJjbUFX 5ioLY/DBOPQDAc+17//6XbNcfzhSQA7ElqIYNHZFv93gLlpBDHCCdnZQ2u6KFTtgitURxK84VlT Pn46AYuMnVnpwHbh4qw== X-Authority-Analysis: v=2.4 cv=aPHAb79m c=1 sm=1 tr=0 ts=6a8d52d4 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=pkmFLQsO-xIKxrFyL9MA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA3MSBTYWx0ZWRfX/JC/7s6SfCgH 8ArIpGbNmiWCB3orZp9BYr+qjWZuRUX66bOBWJbPdzYkVTegepJrn14NibvZHBZaTWCk4CypaWg voTNTshkz2BZgpo3iUiMP3qy8R+Q5vE= X-Proofpoint-ORIG-GUID: OP3s2L_zeyjZgJc8ByuZEdeFEuIDCakq X-Proofpoint-GUID: OP3s2L_zeyjZgJc8ByuZEdeFEuIDCakq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_02,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250071 On 8/24/2026 3:43 PM, Viken Dadhaniya wrote: > The function always returned 0 and had no error paths, so change its > return type to void. Drop the now-dead ret variable and error check > in spi_geni_prepare_message(). > > setup_fifo_params() is called for both GENI_SE_FIFO and GENI_SE_DMA > modes, so the "fifo" in the name is misleading. Rename it to > setup_spi_params() to better reflect its purpose of configuring SPI > mode parameters (CS, CPHA, CPOL, loopback, LSB-first). > > No functional change. > > Signed-off-by: Viken Dadhaniya > ---Reviewed-by: Mukesh Kumar Savaliya