From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61AB63939B3 for ; Tue, 4 Aug 2026 19:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785873106; cv=none; b=iqvEjjFpuUriBs0QyDl0RBmEsmGFxYCcuZuhUyro83ZPGjYMCSrwgNX4a9LKNOkXo7viLFn2tCOVr/u9qVlGHBJDR8yL2mFOBAPN7DgEqQp+PPXRnIGZIdbmM0TvOP+mw7eLXa2h+ZS/aDSG5EFDO4ocA+n3E5wHxSUn35xMXPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785873106; c=relaxed/simple; bh=2ORcQRiALFGn5k9IpC8jVNbcok1zmKXNEbSlb+uyjm8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bf93apKijiAHQMhB8STU/WYK0qQDUSHv60qpAQ3maIPV0Uzb96bFNMTZL4B5jcbJMVpVYT4+uLSpyuTSCybAgMxj3Lg3NQgNvzZjR1UfPUMFSVMXsp7/EJMQODrnRw6/95UivVT/kSiLvGfrIX5zvWRDLgAjnF46lPBqCShJ104= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L8/nMWpX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L8/nMWpX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF01F1F000E9; Tue, 4 Aug 2026 19:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785873105; bh=EZo39pDphjEUJ4S5dknllWZz/LVuNMPSlxO0HEwHOXw=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=L8/nMWpX/ejhBaqajLD7Sq/XlkXCgWMOiOBSk9aD2LmVzkEkWj+0p4f6R3XxhX20q wiaiMltxoTFFVzYL1iWMU3Zet3dLdWbr68TX/xm+Qx5fIF0Q9NWFZJMNCnnxsI4/Wy jA0v9nObS+8RHMx+6o16RB9SqZzEbc6YnNb4EqTi8pRWx6mNd+sHbR0AKZPdmYJYL8 e4wlWrAszosuzWVVbMM7xyQn3kJE70Ny6yurvzT104wwZj22OvhwQsMMjPWHbr99/J Ws01C+Ojdvb+HmBSJpuaeyD+j5UX7coQG2h+2DL3Pf3opTqD1eUgXJAmadqOyr3uIX RjYyl5pHbfIDg== Message-ID: <8e48c288-2183-4d58-b69d-5f78344b5da5@kernel.org> Date: Tue, 4 Aug 2026 21:51:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/5] Only free healthy pages in high-order has_hwpoisoned folio To: "Vlastimil Babka (SUSE)" , William Roche , Jiaqi Yan , linmiaohe@huawei.com, ljs@kernel.org, ziy@nvidia.com Cc: osalvador@kernel.org, harry.yoo@oracle.com, willy@infradead.org, osalvador@suse.de, jackmanb@google.com, hannes@cmpxchg.org, nao.horiguchi@gmail.com, tony.luck@intel.com, wangkefeng.wang@huawei.com, jane.chu@oracle.com, akpm@linux-foundation.org, muchun.song@linux.dev, liam@infradead.org, rientjes@google.com, duenwen@google.com, jthoughton@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rppt@kernel.org, shuah@kernel.org, surenb@google.com, mhocko@suse.com, boudewijn@delta-utec.com References: <20260705180714.3708947-1-jiaqiyan@google.com> <85cb7ea8-8116-4092-8310-69b61eb8602c@kernel.org> <1dea7b3c-7740-474d-b9d4-cd2baf47f181@kernel.org> <168ad406-f6b5-4623-adac-9f894e410e48@kernel.org> <8f787434-5326-4a8f-92d0-467e817a23b4@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <8f787434-5326-4a8f-92d0-467e817a23b4@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/28/26 19:18, Vlastimil Babka (SUSE) wrote: > On 7/27/26 16:20, David Hildenbrand (Arm) wrote: >> On 7/22/26 10:27, Vlastimil Babka (SUSE) wrote: >>> >>> Would it truly fix the issue, or rather there would still be a race window >>> left where we check that there's no hwpoison flag in the re-enabled check, >>> and only then someone sets it? >> >> Why are we checking PageHWPoison at all then in check_new_page()? > > We check all kinds of unexpected state, when that's enable. PageHWPoison > could have been considered unexpected too, when the checks were made more > and more optional (first by Mel and then me). > > But indeed it seems the PageHWPoison check is supposed to be load-bearing > (hi, Lorenzo!). It's intentionally handled before bad_page() (with a taint) > in check_new_page_bad(). Commits 2a7684a23e9c and f4c18e6f7b5b are also a hint. > >> I think we created a mess. > > Yes, the PageHWPoison handling was made part of debugging sanity check and > then not recognized properly as load-bearing later. BTW, I'd assume we can check for PageHWPoison at free time fairly efficiently, as we touch all page flags already. Something along the lines of: diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 520ebd2fa40b5..57f89f8684168 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1321,6 +1321,7 @@ static __always_inline bool __free_pages_prepare(struct page *page, bool init = want_init_on_free(); bool compound = PageCompound(page); struct folio *folio = page_folio(page); + unsigned int hwpoisoned = 0; if (fpi_flags & FPI_PREPARED) return true; @@ -1347,21 +1348,6 @@ static __always_inline bool __free_pages_prepare(struct page *page, count_vm_events(UNEVICTABLE_PGCLEARED, nr_pages); } - if (unlikely(PageHWPoison(page)) && !order) { - /* Do not let hwpoison pages hit pcplists/buddy */ - reset_page_owner(page, order); - page_table_check_free(page, order); - pgalloc_tag_sub(page, 1 << order); - - /* - * The page is isolated and accounted for. - * Mark the codetag as empty to avoid accounting error - * when the page is freed by unpoison_memory(). - */ - clear_page_tag_ref(page); - return false; - } - VM_BUG_ON_PAGE(compound && compound_order(page) != order, page); /* @@ -1395,8 +1381,26 @@ static __always_inline bool __free_pages_prepare(struct page *page, } } tail_page->flags.f &= ~PAGE_FLAGS_CHECK_AT_PREP; + hwpoisoned += PageHWPoison(tail_page); } } + hwpoisoned += PageHWPoison(page); + + if (unlikely(hwpoisoned)) { + /* Do not let hwpoison pages hit pcplists/buddy */ + reset_page_owner(page, order); + page_table_check_free(page, order); + pgalloc_tag_sub(page, 1 << order); + + /* + * The page is isolated and accounted for. + * Mark the codetag as empty to avoid accounting error + * when the page is freed by unpoison_memory(). + */ + clear_page_tag_ref(page); + return false; + } + if (folio_test_anon(folio)) { mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); folio->mapping = NULL; diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile Of course, we could also fallback for order>0 to do some smart splitting. Checking on allocation efficiently is indeed a bit more tricky. For compound pages prep_compound_page() will already walk all pages. Having hwpoison logic to just sync with the buddy when setting hwpoison flags would be nicer. Then we could (maybe) have the rule that no hwpoisoned page can enter the buddy, and no page can become hwpoisoned while in the buddy. Consequently, no hwpoisoned page can leave the buddy (except weird races while allocating, but then it's just an allocated page). Maybe. -- Cheers, David