From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83A4720C313 for ; Fri, 25 Oct 2024 17:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729878110; cv=none; b=roQxf8AW3e9IyimVr0eHrvhqf0656pemdKlStzzMD80gIM+ZyVCclpCekIPIASsAaYkR1sSjWyGAO4GtEv6yzxwYMLIi9HxUcjMoHuk3IAFUL/C4FgBSqTKJmLPL2ovoOjQ1S+sc6iBvO5GDn6/1If7hSngHSN7Hqr7CHooXgE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729878110; c=relaxed/simple; bh=JFUudwqmv14JueSq6ucl5OfPdZQpWR7y3jLotykLqV8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S8Xu8y6Gghm0tXQi+j8YAoY5X6k9S+lbhMy8sVJ+OMKoO7lPDR+IRg90c4B3m5aZyrWtR+I7h1vAWzEbIxMFiPQVtlfP9ymCii+Ge7dTDEFKUgB0V3X9sY1QmGE9b4yImlo3f1ddmk8vvSiKclaWMHM6MF93TXwMBzE/Brvzwqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KSlBfm+O; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KSlBfm+O" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49PG3Iex020204 for ; Fri, 25 Oct 2024 17:41:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FHu7Dsvv0DBV1i9mgCw48KlX1tl0tTx9s/NTZdtmkws=; b=KSlBfm+OEuHMMrMA aI6TnejfhH2w7Ou7w4JWf4YOVdp6MO7A0/f3ZNoVL+AracM2p1BocSBoQJ7FYiPX 3Hpw3HHW4GemWzP4aqEl6J/EIqac9unHt5Lrs+CHXw0iyVYTWZb6iwZli9JHcWNu m9wygjLS4PlMS2SkEF4SAD4dtMO+tr6Rfi/5YzkeUaBKhLHyneokwpSz+9UUjm/o 8zNh8nAsjHnrfhY5Z2rFyPF/yB+vbXP8yVgFQWx9T73f06Sv2rzXXrs7pS0OwAPM 4/l3ymLe+mhfvAzETrpfmvFdse0DlBvp4gdan2j9V2Un53NKa5Y0ii0A9IllqgSr 5bDhuw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42g6y91tt2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Oct 2024 17:41:47 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6cda6fd171bso5042086d6.3 for ; Fri, 25 Oct 2024 10:41:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729878106; x=1730482906; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FHu7Dsvv0DBV1i9mgCw48KlX1tl0tTx9s/NTZdtmkws=; b=kxWVfePsyiGM6g2U/78a1mbjB4CKDyYrdt4kz2plXZPBmtg5hK6Q6XzQbsazXH+lAS NeEXaFtHIrDhAVmJNteLBldWZ5g0CzQnszn9++KRzyObpAp0PnT/PK/4WTWhK3jufAl0 Raa6+1VE5vTYnL+eFTn8wyTgEaGCSbZ7BQLqLNtXyO5thTefx70h2YuKpQfO2UW3Zs+F 9SAqjSaH8om75iPo4Y0JgV8jsW4y5rv46pW0sJMsjr0SnekNAQ+7gfK77DfTJiAIKGGc 1x1P4Q05BhPB/4NfdEATfE0R+YOBWQck785T/7SzbE2uF3Pfz4nBYCzeZG1ZGbTlAzjZ eM2Q== X-Forwarded-Encrypted: i=1; AJvYcCXpEhe3+7/h9rvxtsfv+ZhhNL9YK5+ozEHwiqtlJPzqoO54oAvgzE+75IzsDDalBiOCp6eK3wL8KIirysA=@vger.kernel.org X-Gm-Message-State: AOJu0YzvjD51mpKnh78FvHNFlZeffJ06wjKy7NilxcNSxoYAk1ZBzaFG 3cPFl2vtrEA2mlv0rT0yew2J1NmFSy+/MkWcui34FSU9+5xmL0c+ZCX4ef3/nmnaToSXX3VogqQ 4SqnQf8ZLoP8hi1jxLoQ68bSFCzxSmtVXQNYiwUq0cV9kuFSrrMWKgbdLE/y2/t0= X-Received: by 2002:ad4:5cc1:0:b0:6cb:4e9f:7370 with SMTP id 6a1803df08f44-6d185862964mr1286646d6.12.1729878106036; Fri, 25 Oct 2024 10:41:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhW4SFYE0P93aiXTyZ6Wv8eX/yrl4zliE5iVX82/C3QvC8L++dxHQwOPeBNcTiVrDp7AoBWA== X-Received: by 2002:ad4:5cc1:0:b0:6cb:4e9f:7370 with SMTP id 6a1803df08f44-6d185862964mr1286446d6.12.1729878105708; Fri, 25 Oct 2024 10:41:45 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cbb6347f20sm816629a12.86.2024.10.25.10.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Oct 2024 10:41:45 -0700 (PDT) Message-ID: <8e49de35-59dc-4308-b93a-19791e6b05e2@oss.qualcomm.com> Date: Fri, 25 Oct 2024 19:41:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] soc: qcom: llcc: Add LLCC configuration for the QCS8300 platform To: Jingyi Wang , Bjorn Andersson , Konrad Dybcio , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: quic_tengfan@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com References: <20241010-qcs8300_llcc-v2-0-d4123a241db2@quicinc.com> <20241010-qcs8300_llcc-v2-2-d4123a241db2@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241010-qcs8300_llcc-v2-2-d4123a241db2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: rJPjFfMUNsCuQ7KV_hL98wULT7mh3qij X-Proofpoint-ORIG-GUID: rJPjFfMUNsCuQ7KV_hL98wULT7mh3qij X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410250135 On 10.10.2024 12:08 PM, Jingyi Wang wrote: > Add LLCC configuration for the QCS8300 platform. There is an errata on > LB_CNT information on QCS8300 platform, override the value to get the > right number of banks. > > Signed-off-by: Jingyi Wang > --- > drivers/soc/qcom/llcc-qcom.c | 72 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > index a470285f54a8..d867b1596725 100644 > --- a/drivers/soc/qcom/llcc-qcom.c > +++ b/drivers/soc/qcom/llcc-qcom.c > @@ -2225,6 +2225,56 @@ static const struct llcc_slice_config sm8650_data[] = { > }, > }; > > +static const struct llcc_slice_config qcs8300_data[] = { This part looks good and in line with the data I have [...] > > + /* LB_CNT information is wrong on QCS8300, override the value */ > + if (of_device_is_compatible(dev->of_node, "qcom,qcs8300-llcc")) { > + num_banks = 4; > + drv_data->num_banks = 4; > + } This, please rebase on <20241025-sar2130p-llcc-v2-0-7455dc40e952@linaro.org> and reuse the thing added there Konrad