From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"M.h. Lian" <minghuan.lian@nxp.com>,
"Z.q. Hou" <zhiqiang.hou@nxp.com>
Subject: Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
Date: Tue, 26 Jun 2018 15:21:47 +0000 [thread overview]
Message-ID: <8e4b85b7-f75f-aa9c-1baa-837f66906cee@nxp.com> (raw)
In-Reply-To: <86efgt7g0z.wl-marc.zyngier@arm.com>
Hi Marc,
On 26.06.2018 17:56, Marc Zyngier wrote:
> On Tue, 26 Jun 2018 15:37:12 +0100,
> Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
>>
>> Update the effective affinity mask to fix this warning issued by the
>> generic irq handling code:
>>
>> "genirq: irq_chip MSI did not update eff. affinity mask of irq x"
>>
>> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>> ---
>> drivers/irqchip/irq-ls-scfg-msi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
>> index 1ec3bfe56693..d81d5b016438 100644
>> --- a/drivers/irqchip/irq-ls-scfg-msi.c
>> +++ b/drivers/irqchip/irq-ls-scfg-msi.c
>> @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data,
>> }
>>
>> cpumask_copy(irq_data->common->affinity, mask);
>> + irq_data_update_effective_affinity(irq_data, mask);
>>
>> return IRQ_SET_MASK_OK;
>> }
>
> It has already been addressed here:
>
Thanks for the obviously much better & complete fix.
Will take care to keep my local repo more up-to-date.
---
Best Regards, Laurentiu
prev parent reply other threads:[~2018-06-26 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 14:37 Laurentiu Tudor
2018-06-26 14:56 ` Marc Zyngier
2018-06-26 15:21 ` Laurentiu Tudor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4b85b7-f75f-aa9c-1baa-837f66906cee@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=minghuan.lian@nxp.com \
--cc=tglx@linutronix.de \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®