Re: [PATCH v2 1/6] media: uvcvideo: Remove nodrop parameter

[Hans de Goede <hansg@kernel.org>]

Hi,

On 19-Nov-25 8:37 PM, Ricardo Ribalda wrote:
> We announced the deprecation intentions one year ago in the commit
> commit 40ed9e9b2808 ("media: uvcvideo: Announce the user our deprecation
> intentions").
> 
> We have not hear any complains, lets remove the nodrop parameter.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Thanks patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Since this is independent of the rest of the series I've merged this into my local
uvc/for-next branch which I will push out later today.

Regards,

Hans




> ---
>  drivers/media/usb/uvc/uvc_driver.c | 19 -------------------
>  drivers/media/usb/uvc/uvc_queue.c  | 25 -------------------------
>  drivers/media/usb/uvc/uvcvideo.h   |  1 -
>  3 files changed, 45 deletions(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index ee4f54d6834962414979a046afc59c5036455124..71563d8f4bcf581694ccd4b665ff52b629caa0b6 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -32,7 +32,6 @@
>  
>  unsigned int uvc_clock_param = CLOCK_MONOTONIC;
>  unsigned int uvc_hw_timestamps_param;
> -unsigned int uvc_no_drop_param = 1;
>  static unsigned int uvc_quirks_param = -1;
>  unsigned int uvc_dbg_param;
>  unsigned int uvc_timeout_param = UVC_CTRL_STREAMING_TIMEOUT;
> @@ -2468,24 +2467,6 @@ MODULE_PARM_DESC(clock, "Video buffers timestamp clock");
>  module_param_named(hwtimestamps, uvc_hw_timestamps_param, uint, 0644);
>  MODULE_PARM_DESC(hwtimestamps, "Use hardware timestamps");
>  
> -static int param_set_nodrop(const char *val, const struct kernel_param *kp)
> -{
> -	pr_warn_once("uvcvideo: "
> -		     DEPRECATED
> -		     "nodrop parameter will be eventually removed.\n");
> -	return param_set_bool(val, kp);
> -}
> -
> -static const struct kernel_param_ops param_ops_nodrop = {
> -	.set = param_set_nodrop,
> -	.get = param_get_uint,
> -};
> -
> -param_check_uint(nodrop, &uvc_no_drop_param);
> -module_param_cb(nodrop, &param_ops_nodrop, &uvc_no_drop_param, 0644);
> -__MODULE_PARM_TYPE(nodrop, "uint");
> -MODULE_PARM_DESC(nodrop, "Don't drop incomplete frames");
> -
>  module_param_named(quirks, uvc_quirks_param, uint, 0644);
>  MODULE_PARM_DESC(quirks, "Forced device quirks");
>  module_param_named(trace, uvc_dbg_param, uint, 0644);
> diff --git a/drivers/media/usb/uvc/uvc_queue.c b/drivers/media/usb/uvc/uvc_queue.c
> index 790184c9843d211d34fa7d66801631d5a07450bd..3bc54456b4d98ed50b1ea250ce8501e67141e1ef 100644
> --- a/drivers/media/usb/uvc/uvc_queue.c
> +++ b/drivers/media/usb/uvc/uvc_queue.c
> @@ -331,34 +331,9 @@ struct uvc_buffer *uvc_queue_get_current_buffer(struct uvc_video_queue *queue)
>  	return nextbuf;
>  }
>  
> -/*
> - * uvc_queue_buffer_requeue: Requeue a buffer on our internal irqqueue
> - *
> - * Reuse a buffer through our internal queue without the need to 'prepare'.
> - * The buffer will be returned to userspace through the uvc_buffer_queue call if
> - * the device has been disconnected.
> - */
> -static void uvc_queue_buffer_requeue(struct uvc_video_queue *queue,
> -		struct uvc_buffer *buf)
> -{
> -	buf->error = 0;
> -	buf->state = UVC_BUF_STATE_QUEUED;
> -	buf->bytesused = 0;
> -	vb2_set_plane_payload(&buf->buf.vb2_buf, 0, 0);
> -
> -	uvc_buffer_queue(&buf->buf.vb2_buf);
> -}
> -
>  static void uvc_queue_buffer_complete(struct kref *ref)
>  {
>  	struct uvc_buffer *buf = container_of(ref, struct uvc_buffer, ref);
> -	struct vb2_buffer *vb = &buf->buf.vb2_buf;
> -	struct uvc_video_queue *queue = vb2_get_drv_priv(vb->vb2_queue);
> -
> -	if (buf->error && !uvc_no_drop_param) {
> -		uvc_queue_buffer_requeue(queue, buf);
> -		return;
> -	}
>  
>  	buf->state = buf->error ? UVC_BUF_STATE_ERROR : UVC_BUF_STATE_DONE;
>  	vb2_set_plane_payload(&buf->buf.vb2_buf, 0, buf->bytesused);
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> index ed7bad31f75ca474c1037d666d5310c78dd764df..9a86d7f1f6ea022dace87614030bf0fde0d260f0 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -659,7 +659,6 @@ static inline struct uvc_fh *to_uvc_fh(struct file *filp)
>  #define UVC_WARN_XU_GET_RES	2
>  
>  extern unsigned int uvc_clock_param;
> -extern unsigned int uvc_no_drop_param;
>  extern unsigned int uvc_dbg_param;
>  extern unsigned int uvc_timeout_param;
>  extern unsigned int uvc_hw_timestamps_param;
>