From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9139938D011 for ; Mon, 29 Jun 2026 10:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729258; cv=none; b=mJCw3iqYe79HBZ5YKQm5v1y7EvKS/bQZy6zMcBssCfpM9dU+vB3EiS67+f6PU1nU7azQK1WIB/SmP0OSt0WxJy58yesggkdLMSe/94t8scM6Feb/XyEyP8iUkb3UdfwZRXZa7DtZclIjMx+xc+tTkJcSmn+3pBruRd+gLr2QWV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729258; c=relaxed/simple; bh=O7k+YKlCUgne8sQca2M+WCEzkz5Cqo5yJXcu0TM/sGw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HUvwNBTCBK7A4NNCPL3W9V8tQxbGzwC3gP4LsKO2iI+8r0Ankgy7MY9VR2V9Fkh3X5ljLXeXMs4FepCbZGbKdwt91LPlyXXfqJdN6hdhr6LaNjvI2wKdCYt9tJnV72dXdtJQOf8bG9PREIuvro5iQz/HNnbMAWgTnirgpZWO6/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T9DISo9J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h/qlPO38; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T9DISo9J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h/qlPO38" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TATKPc2656139 for ; Mon, 29 Jun 2026 10:34:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= We8IfLXw172gbAFTQlf72mWB2mC4Z1ZwwihA6fagoqk=; b=T9DISo9J7j6psLNv 9DiNxp8vZleQfl3RhHDR60iFKwo45IIdPImrtT4bK9GpYfGsZ8u2EsybeHTD/GvE bHDoD5g8hHCwUDhu98o7J5vh86Ge45FPbJY0+p9vwJH7SuY+yOm3krw1O4ncgoJ4 /og6Gj6WJ3cLm2Mc7SBCyA7wqtDxX72X9iUZ8Qxs9jyjFywBID2v47xNfnO4TNd3 75hCcxyqd3mkICakMK/kpM28A3j2FgTctGuh+RMQjoeK+Mstkl5x6EfL6R0eVGvB T4vNXIJaWigJ86LWKBRUUKMejzVvXlfx1UeupSLAR+XYfhDZfh4dKNrTB1xMiItB ERyEyQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3np7gcc9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 10:34:16 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7359eba94f2so123576137.3 for ; Mon, 29 Jun 2026 03:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782729256; x=1783334056; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=We8IfLXw172gbAFTQlf72mWB2mC4Z1ZwwihA6fagoqk=; b=h/qlPO38fVN7pZGU12/Z8pH6nbt8pWthZfyWeijTwt6cw3xywYJ1SahGCYr1aAuKpm BsJhlHCp/n4ZT38TW3P1XFocvuPvPzoU566cEzOuoKHMDjv6nMailUOG6hslIOpWafW1 RSqNxBqvCd56tRVbbg/00JvEMCBNnt64ebtmqvySoABCokMFzvHvUGnoCa2nRJG5tigg II15I8rTY3Zfm6SVDJ/aWypeoSH87YRKSP+A3XDwg6/z3sOLJ0sfPMAKL61ksFlL3K5o tnXq2ePWuGPczDv6kXIqu9Cx3QNwC2Vf/IJow5zPQeK1jEx26rbwfZ8ppxEPgIYvVemE iF0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782729256; x=1783334056; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=We8IfLXw172gbAFTQlf72mWB2mC4Z1ZwwihA6fagoqk=; b=htYtLev/mD9tsc66BIr6oFgWuh0tDPcmWqydNGZVZ9qlHPSO64j9cSf3lgZ3tZ9MJU DJbAxtFhG+NO7jvVzGhcIl31KWyAgVppIFbEzTekk7MY0Jqy2CcRV7tjT3K3L29gC2wy 6On8HZotjgJr/qVBWGTsB3AhaR2kmIh1WrXHoJa581AN3Xqz5vt+mZIuuHku3LWPj/JE Xaspf65Oci9vaKMXFZKtI4ALCaKNl+KpsUQ1A4e9hX1u8vaguXl4ZQrsuNEKjZkb9byI dfb3hQ1vwxUmoqNKPFp/8MFpB9L24lXHC9OnjJUDjsut3lU3ZeJXpHJjSXX6+7xY+iI7 mW6g== X-Forwarded-Encrypted: i=1; AHgh+Rpl9wuRbYMGOs2plPsmZcT0M8ubcyqu2fRwfA1OvRxaxx84SBQ7SZgqyl3/HxyJoTysd2DujT56Q8bWdkg=@vger.kernel.org X-Gm-Message-State: AOJu0YxPiSI8ag9iS2WuZBQwO3sfsGW0d/fnAv+Q6NXkMfsHb/eUFekr /8RGP5neLosZgXOmGGcNMTBv61vl/9ZMUzii1fjEsdQadrEfR/yiDWbsA+OO6yHYWH3s46mVTiR ahyn+1vZvpL9shYsaRLnAn2skUQfeneIXVaYuEatJNSUVaCeVJQvkmBSdJV1A2V1LFYI= X-Gm-Gg: AfdE7clj3n8rSiAy3NO34DIMemnrCJoH7nnStodpiObNx4mpuXkZ42qccH1ivI2lU60 RlxHTnOkV9MB63RMCBoramz8xkBhJF5qA16+Qb60CxNQRn0GepRdX1eyZWCinklNtagsk9nogaT 7QydSD/tp4IpBmMEQhAF6St+zbboEt4NE0Saw6W4wYMebVjf2n8ea+Hh5qDLPI8z/65N8ss5IGc GrhuGKb57sO2h+xT29MRt+FRQdue6pxK2gSVWLNuDnzcra0oC5WAFbQwWmxFa0rmO/JGAgbVt8B lXyB5g34ZEJ6caorQ6alRsROysrwQWr1OTenhioJFosQMCQj/pt24vkVwKGETjw5GkrnuG8LUgy X/s8dsoyXg0CUTQG6MCN4wsESSrm7pCMzaDE= X-Received: by 2002:a05:6102:cd3:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-734366bedd7mr2311960137.5.1782729255780; Mon, 29 Jun 2026 03:34:15 -0700 (PDT) X-Received: by 2002:a05:6102:cd3:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-734366bedd7mr2311943137.5.1782729255151; Mon, 29 Jun 2026 03:34:15 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-697f3aeb509sm6698546a12.10.2026.06.29.03.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 03:34:14 -0700 (PDT) Message-ID: <8e4ea76e-f1c0-4dfd-8477-35e01ac0ba0d@oss.qualcomm.com> Date: Mon, 29 Jun 2026 12:34:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR To: Qiang Yu Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-7-c939c22ded0c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA4NSBTYWx0ZWRfXzJix8YkeeoZ3 i4WUgPmAtNzL1mtdSnfOArTB/LXm5rzgKFz36ZpkfZd4xS80szVHzpjmEYv/mIOrQrswHdCQzrx UdFOSTyPSOXSYDQCu+hm8qhpwOqEaz0BlfokpXWkd/YcCg4Z6sSnTsLijMmjkPDjUp9i4N2Skyp n8e7Ja3uia2QFJ5UjgfRRYFx4Pp7+Fa+RUDS93BJGvZU+svCHO3klOX8WYPM9cGGokz8zyjAwEO n15qdwAQqFCFy9OmWfx4ojEGRjz+JdTJS02OjiGqzUTLP2lOkaeNENd2GOU3q+pPyc1YQqJmWVs Wq3BlmaLgjmOpPAm2AwOmknqRuzQtDafqOxcnyZE3tCmdpXPKutpwQRE2X5TWv/7AVHCcl+iNNM B//ri3MO2UEqdGk6wbuaAEq497G3DO8vb5n0wjeIMYYTpMomaZVuiwti1eMA13qspDU5imwW+a9 i9q60ZKaamb+qXUeh9w== X-Proofpoint-GUID: _y0HFZa_QT-HHBAQ3WE3OMK0INANSrEp X-Proofpoint-ORIG-GUID: _y0HFZa_QT-HHBAQ3WE3OMK0INANSrEp X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA4NSBTYWx0ZWRfX3wccA/rHxk2J OvsRYLSwitpG4YlKUNuwtIBprvj3Bhh3beFGt6O2Ep4UpGbJrFUhIyqvcFOdcV5nKyJHZobpU7m zwnCq3cNvddojd47eOEc1z2e1Trzu/g= X-Authority-Analysis: v=2.4 cv=OcWoyBTY c=1 sm=1 tr=0 ts=6a424a28 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=h4iy993FS52baA_BjO4A:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290085 On 6/22/26 3:31 PM, Qiang Yu wrote: > On Mon, Jun 22, 2026 at 02:18:54PM +0200, Konrad Dybcio wrote: >> On 6/22/26 7:11 AM, Qiang Yu wrote: >>> Mahua has a different PCIe QREF topology from glymur. Override the TCSR >>> compatible to qcom,mahua-tcsr in mahua.dtsi, and wire up the required >>> LDO supplies for the PCIe clkref paths on the CRD board. >>> >>> Signed-off-by: Qiang Yu >>> --- >>> arch/arm64/boot/dts/qcom/mahua-crd.dts | 15 +++++++++++++++ >>> arch/arm64/boot/dts/qcom/mahua.dtsi | 4 ++++ >>> 2 files changed, 19 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/mahua-crd.dts b/arch/arm64/boot/dts/qcom/mahua-crd.dts >>> index 9c8244e892dd..8b42f5174b31 100644 >>> --- a/arch/arm64/boot/dts/qcom/mahua-crd.dts >>> +++ b/arch/arm64/boot/dts/qcom/mahua-crd.dts >>> @@ -19,3 +19,18 @@ / { >>> model = "Qualcomm Technologies, Inc. Mahua CRD"; >>> compatible = "qcom,mahua-crd", "qcom,mahua"; >>> }; >>> + >>> +&tcsr { >>> + vdda-qrefrpt0-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrpt1-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrpt2-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrpt3-0p9-supply = <&vreg_l1f_e1_0p82>; >>> + vdda-qrefrpt4-0p9-supply = <&vreg_l2h_e0_0p72>; >>> + vdda-qrefrpt5-0p9-supply = <&vreg_l2h_e0_0p72>; >>> + vdda-qrefrx1-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrx2-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrx3-0p9-supply = <&vreg_l2h_e0_0p72>; >>> + vdda-qreftx1-0p9-supply = <&vreg_l1f_e1_0p82>; >>> + vdda-refgen3-0p9-supply = <&vreg_l1f_e1_0p82>; >>> + vdda-refgen3-1p2-supply = <&vreg_l4f_e1_1p08>; >> >> The supplies are correct, but QREF uses refgen4 on Mahua >> > > The instance is REFGEN4, but its regulator name is refgen3_xxx. Do you > think rename the supplies as vdda-refgen4-0p9-supply is better? Ah, I overlooked this. Maybe 4 could be better here, since the supplies that end up being assigned there match what we call refgen4 on Glymur. But there's no good answer, both options are terrible. Let's add a comment somewhere (in bindings?) describing this mess, perhaps like: # On Mahua, the REFGEN4 block is supplied through pads named REFGEN3 Konrad