From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
alsa-devel@alsa-project.org, fabio.estevam@nxp.com,
mail@maciej.szmigiero.name, caleb@crome.org, lgirdwood@gmail.com
Subject: Re: [PATCH 04/10] ASoC: fsl_ssi: Refine all comments
Date: Mon, 4 Dec 2017 22:04:57 -0600 [thread overview]
Message-ID: <8e5229a8-5f3f-d55f-95dc-2b33657b9c9a@tabi.org> (raw)
In-Reply-To: <1512420403-10164-5-git-send-email-nicoleotsuka@gmail.com>
On 12/4/17 2:46 PM, Nicolin Chen wrote:
> This patch refines the comments by:
> 1) Removing all out-of-date comments
> 2) Removing all not-so-useful comments
> 3) Unifying the styles of all comments
> 4) Simplifying over-descriptive comments
> 5) Adding comments to improve code readablity
> 6) Moving all register related comments to fsl_ssi.h
> 7) Adding comments to all register and field defines
>
> Even after adding dozens of lines in fsl_ssi.h, this patch reduces
> 100 lines totally.
I'll review the other patches later, but I'm not keen on your removal of
some of the comments in this patch. I don't see why line count is so
important, and you're removing some informative text. I can see
removing trivial comments and outdated ones, but "no-so-useful" and
"over-descriptive" are subjective.
next prev parent reply other threads:[~2017-12-05 4:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:46 [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-04 20:46 ` [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device Nicolin Chen
2017-12-05 13:04 ` Mark Brown
2017-12-05 19:39 ` Nicolin Chen
2017-12-04 20:46 ` [PATCH 02/10] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-04 20:46 ` [PATCH 03/10] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-04 20:46 ` [PATCH 04/10] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-05 4:04 ` Timur Tabi [this message]
2017-12-05 4:36 ` Nicolin Chen
2017-12-04 20:46 ` [PATCH 05/10] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-04 20:46 ` [PATCH 06/10] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-04 20:46 ` [PATCH 07/10] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-04 20:46 ` [PATCH 08/10] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-04 20:46 ` [PATCH 09/10] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen
2017-12-04 20:46 ` [PATCH 10/10] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-05 13:01 ` [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level Maciej S. Szmigiero
2017-12-05 19:33 ` Nicolin Chen
2017-12-06 1:01 ` Maciej S. Szmigiero
2017-12-06 1:23 ` Nicolin Chen
2017-12-12 23:32 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e5229a8-5f3f-d55f-95dc-2b33657b9c9a@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mail@maciej.szmigiero.name \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®