From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94C327F18B for ; Mon, 26 Jan 2026 16:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769445299; cv=none; b=etCsc5MY6tmr2Vi3VVeXIRt6qG+nDFeNBMIn/YV2pvTyXVSfOZxJsBIQfxMj162jVgMpHZkiXYRmUj+DBsKjgAz2dWJ35wyqrpRwGauEAWaEacMn6VRTZqQ43K1+mYjVBepR6I6zdwA7CypqWexn+G7z+A5Zcrt7LB9VQ4KgvNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769445299; c=relaxed/simple; bh=ZyeCEnRJjBRKG7NXS66982Tk6HBV6hiwXRGWLHqwKpI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HAuxgeZ0tBKFHJ3t3YuLTMQnfhlw1kw3smz/iOTqYPN7W3p/fPYlrvjqpnjDk3xbC1s3yQ6JpwDRq3y7xgEVjT9SpUwd3+PIeiGsY6/FcGZVuXF7gbQp5PEm9i/10G0OLNny0OE0STYgG1BG0sMnsXIawmC4gh/l5MwCCdJbmtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=E66wUZxi; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="E66wUZxi" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7d11e2ee188so2323303a34.1 for ; Mon, 26 Jan 2026 08:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769445296; x=1770050096; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BNGg+szk5GN7k1/fr737eGbbjOqTigabkUA45rZV/8A=; b=E66wUZxiiAgfz7m+tVuJA/9izTvlkE0JDzwabHNfuRRm//F8f76q8eU478427/R0Mb uunZ/rOLSAUhd2TTEhpVLooA0ZWqq/xaQqwb+b3r7frW9uJyCe/ql28+avjFEooFwEt5 KY1o/JlvQKZwvdwj+cla93FRXMEMy38tG+1lnbeshBB4kfhLM6n4DoqTMZ9FCe/eM1Mg xfm66UzeldhXntYUR2hoOcU34g3YfpYyISxa9vk9xQqais5p2/kbF3g55F0wb66riGa1 ZMY14tA0gpX5d0H7QyJMU7GYvNJiHO+TCeVRsTnYQP/IaxxAsKsBH8aLjOiAfwOXifAD vAKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769445296; x=1770050096; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BNGg+szk5GN7k1/fr737eGbbjOqTigabkUA45rZV/8A=; b=OdxzfyOd1ucmrRjrGjwrabZ2jlJTSP0OhLLyLC7yqsjRyR44j9xTbTB/6F4qHiaY8Q RsjSvllBIQ/J/hNzV8LL16xMYYb+IZiWgRSvxIB1Wkclo/C+xsViWr9eES1AfdHe7UUR IjQqXHQs8/MQk2n5uG/NVgOlZcthvqiJE1qzeRxo0tri900xkMPUFvu8/YSVimabsb7i wboNwjVxSL3vdPBTX0FRO4WwdC2yJkstl6Hb6rVcws8WmEyzPl+MxV3PCC5otBeggND3 H07v3/o/Ps+IPT/+QXENn4X8++4kevHAX+VJWwk3TBdxEa7oe+mkK++hQ7LAktRwV17h vxzw== X-Gm-Message-State: AOJu0YwgNr+DAhP31IqjP8oKbyPakRRXG5Q1zQOGN16GEIAfSt4edrPK 7SV5moJxDaEda7HvxxBobQInEmkIL3IjTqRW3gxH+XEQe5yDiJ4Z1gpxEp4xMBJgFmo= X-Gm-Gg: AZuq6aLTRQulg3HXt407ppJWMRnbtJDGKsbdWt2M7lNfcHr2HnXdru2S9s015Jsel8v Psg5hlxQYRHkFoCxYO3BbV/U7Pyem+aBXZ/2gUmT328p+y174JLYPQa2mYNwDN8AgFfnOG7nLSK FOJBdihyz/QtVLJdfKq9t8PLdT6cVtxLHY4MV9AacARtVJ0NCwpAFRWD7kW9qsrmRRihSP6PAGE gUmk3q09pDmTJ8dQoY9OLFgAK/7m8zRHnaSa9o4uzYUrt8IsZuqUIGMnsLuBUqjpuTUcu0R6s+C 36+MCgP0p9eBsjmMfG0aYo3MgPdXAmUpmV7LOSIPt+50L42Y+aYH6NeM34ySB7xxWfAb0gbrC4B eFdCUYDuHyTmXH4ZJh83ZdPADvjWfk43OSbqDS4dQahMqdtNQUIjzu9WT0Mu3nLl7+sOFTzZ1KB NziMBUXKlPUW4b7Jg9m/tYHyo61eP2ieIgIrzFIyRU+FLgIVx8MnQYDlOl9aFp X-Received: by 2002:a05:6830:2810:b0:7c7:6063:8e0f with SMTP id 46e09a7af769-7d17021ec7cmr2337382a34.15.1769445295763; Mon, 26 Jan 2026 08:34:55 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:37c6:d863:90ba:c4c5? ([2600:8803:e7e4:500:37c6:d863:90ba:c4c5]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d15b36db91sm7936018a34.13.2026.01.26.08.34.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 08:34:55 -0800 (PST) Message-ID: <8e560227-3596-4bf8-9fd8-b843a4738940@baylibre.com> Date: Mon, 26 Jan 2026 10:34:54 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/21] iio: Use IRQF_NO_THREAD To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Thomas Gleixner , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org References: <20260123113708.416727-1-bigeasy@linutronix.de> <20260123113708.416727-20-bigeasy@linutronix.de> <20260126080903.B0_vWRKy@linutronix.de> Content-Language: en-US From: David Lechner In-Reply-To: <20260126080903.B0_vWRKy@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/26/26 2:09 AM, Sebastian Andrzej Siewior wrote: > On 2026-01-23 14:56:32 [-0600], David Lechner wrote: >>> -static irqreturn_t ad7766_irq(int irq, void *private) >>> -{ >>> - iio_trigger_poll(private); >>> - return IRQ_HANDLED; >>> -} >>> - >> >> Replacing this with iio_trigger_generic_data_rdy_poll() seems like a >> separate improvement that should be in a separate patch. >> >> At a minimum, the commit message should explain this change. But I expect >> the reason will make it obvious it should be a separate patch. > > The other use iio_trigger_generic_data_rdy_poll() as the handler except > this one. Which uses a wrapper around it. It looked to easier to add > this hunk. > What do you want (split or keep)? > I would still expect a separate patch to replace the duplicate function with iio_trigger_generic_data_rdy_poll(). That change stands on it's own, so deserves a separate patch.