From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-1-19.ptr.blmpb.com (sg-1-19.ptr.blmpb.com [118.26.132.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF7D1FCF41 for ; Sat, 8 Nov 2025 10:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.26.132.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762596132; cv=none; b=MZHMaVQ7vo8lM2U4DasBdRstyEBmRVdj0hKervHn22amvIaZpwAKO5grcFAQveItbglL9UFvuXmrHDcuwWkeyJv54fqD1vnPjjUaUxjwWzaaLejmPqJix31BrgYRkD1KWJ3r9i0r1q5JlZ5xAt+ZB3mm5uUNrC1XYXFp1dkm/x0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762596132; c=relaxed/simple; bh=9Hgl357mNt2GG/CIuXhbcPB4M+phwxb6IBIO2FyiNXI=; h=In-Reply-To:To:Cc:From:Message-Id:References:Content-Type:Subject: Date:Mime-Version; b=UdCI8udEdexl1xQIdpzssaZ2iyHWlyWh5VZDIVpLC5ai8dIC4F33uXCujASiZ0Ws4bZoi0FLwirq0vrHHdawU8z+Q8rXuRG4BWk6vTzQY3lJEPhgc+ZB43gV2kh9f2C49OfgambbXBRninV5aSipC6o5LV0FXV59V6arLxyxguk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com; spf=fail smtp.mailfrom=fnnas.com; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b=b0qVN2En; arc=none smtp.client-ip=118.26.132.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=fnnas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b="b0qVN2En" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fnnas-com.20200927.dkim.feishu.cn; t=1762596123; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=rYPdsycX/7NnC/4/QzWKifIGYh4RhCN2Wv2r2vLsVN0=; b=b0qVN2EnszWwjInBiQi1qAVGXBEbu6B/NO4NfDByxSfG7cZ/GfwjK9nP6nfFzXorYLLMJi f99pXDzboTSgGjbsonYX9/ZHsBC6ojdNJ+/mDdaYzFlI4cJxudezwqWhIRHw0iNN+fuHHR xr3x5Jb28dp+eRSJkkMj6XcIm4VafaTxJ0ZkJbjQvygsyN399tUVkP1DOM0gz23KtIroU6 61EPdxNIPxXr4eG8uH7A4NTkNV5XDg+VJJGt5w7nhRI/1PzjHUPUDql24i1kC8JCGZUIM4 YWb0aqsP6/awiEv7WonQK81qxul6LGZ/JnYFofFpchSBrqWQMuP7hmroXQ3qTQ== Content-Transfer-Encoding: quoted-printable In-Reply-To: <20251106115935.2148714-2-linan666@huaweicloud.com> X-Original-From: Yu Kuai To: , , , Cc: , , , , , From: "Yu Kuai" User-Agent: Mozilla Thunderbird Message-Id: <8e564dcc-8bdf-4fc7-a8f0-4c0c7d3547cb@fnnas.com> References: <20251106115935.2148714-1-linan666@huaweicloud.com> <20251106115935.2148714-2-linan666@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Organization: fnnas X-Lms-Return-Path: Reply-To: yukuai@fnnas.com Subject: Re: [PATCH v2 01/11] md/raid1: simplify uptodate handling in end_sync_write Date: Sat, 8 Nov 2025 18:02:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Received: from [192.168.1.104] ([39.182.0.168]) by smtp.feishu.cn with ESMTPS; Sat, 08 Nov 2025 18:02:01 +0800 =E5=9C=A8 2025/11/6 19:59, linan666@huaweicloud.com =E5=86=99=E9=81=93: > In end_sync_write, r1bio state is always set to either R1BIO_WriteError > or R1BIO_MadeGood. Consequently, put_sync_write_buf() never takes the > 'else' branch that calls md_done_sync(), making the uptodate parameter > have no practical effect. > > Pass 1 to put_sync_write_buf(). A more complete cleanup will be done in > a follow-up patch. > > Signed-off-by: Li Nan > --- > drivers/md/raid1.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) LGTM Reviewed-by: Yu Kuai