From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2C5E361946; Tue, 13 Oct 2026 23:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791933900; cv=none; b=OrJlRnxtnYlXwD55HIk+trrSuFNLiS3VIsoHrZx4O5WdP+Alj4UkCBOBtMHO5iscbHjYW6zArJs8fYh3+a2x+jP/9haLLMbrPHKYHkbC1amjKQ+Zh3mlsV++hVabJdUt8tByelIyCsKWFRnE/gY8D4SZPVSLeD3t3MlTq0m0/ok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791933900; c=relaxed/simple; bh=Df5euMZ7GRB7lzj9XqtNsgNgiWwI0LnGkjQxrVqI2go=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pzwmK+HioYMa6MCM6tAOmTBocN4nl0vUUyP+PkYYC7RlKII8ySH1/HEOrRE9aqVllaNyCr4LS7sL4s6t29WiVhMK/2tI4H6ql2c/sE+VvK0PcMLhEJbCr98Xe13SxznEy7MrFxPfL58LFnwXf9aSrordmoEy480vyHBGFw5lNeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=HQt/oFwp; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="HQt/oFwp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; bh=bNPAQuPoxBsX/MPcYdsx2mO9t/aLPKwgxQnaOfUiNwY=; b=HQt/oFwp+PyaBAylMssyA1epl6ynuap1P1RHFrUiyECg84Pv/ky6dXmrYkucVT bew0rbQp9HKUyHfLOmBCit3VY9DjbT2A5BUnlYNmcAfsZzf4o6BpY+0KlIP/qUA8 nbem5WFMYt2R38BoktLRa914LfQ9UAJE2JUlBBgiGWQmw= Received: from [IPV6:2409:8900:1a87:d0a0:9d82:6fdf:5e33:6bcb] (unknown []) by gzsmtp4 (Coremail) with SMTP id PygvCgDXBES2vc5q3HPQEQ--.29313S2; Wed, 14 Oct 2026 07:24:39 +0800 (CST) Message-ID: <8e59b334-696a-4e7c-8acd-625ad18239b6@163.com> Date: Wed, 14 Oct 2026 07:24:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ntfs: report block device flush failures from fsync To: DaeMyung Kang , Namjae Jeon , Hyunchul Lee Cc: ntfs@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20261013145846.56415-1-charsyam@gmail.com> <20261013145846.56415-2-charsyam@gmail.com> Content-Language: en-US From: liubaolin In-Reply-To: <20261013145846.56415-2-charsyam@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:PygvCgDXBES2vc5q3HPQEQ--.29313S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF48WF13Cw1UurWUJF4rGrg_yoW8XF1Upw sxCryrJ39YvF1UK3Z0kF4jgFWFvFZ7t342gF9xuw1Sgr45J3WDWFWrtw1Fqas5trykArW8 Gr4DWFZ0ya4UArJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U2iiDUUUUU= X-CM-SenderInfo: xolxutxrol0iasrtmqqrwthudrp/xtbC6RfqtWrOvbepDQAA3r 在 2026/10/13 22:58, DaeMyung Kang 写道: > ntfs_file_fsync() calls blkdev_issue_flush() after writeback but discards > its return value. If the device cannot flush its write cache, fsync() > reports success even though the file is not guaranteed to be durable. > > Reproduce this with QEMU blkdebug failing flush_to_disk with -EIO. > On ntfs-next at 04fb910da2c8, a kretprobe recorded -EIO from > blkdev_issue_flush() while fsync() returned 0. With this change, > fsync() returns -EIO and logs the failure. The syncfs() path already > reports this error. > > Fixes: 9c87959601e8 ("ntfs: update file operations") > Cc: stable@vger.kernel.org > Signed-off-by: DaeMyung Kang > --- > fs/ntfs/file.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c > index 58afd310d57b..afc2efb4b699 100644 > --- a/fs/ntfs/file.c > +++ b/fs/ntfs/file.c > @@ -417,14 +417,14 @@ int ntfs_file_fsync(struct file *filp, loff_t start, loff_t end, > err = sync_blockdev(vi->i_sb->s_bdev); > if (unlikely(err && !ret)) > ret = err; > + if (!ret) > + ret = blkdev_issue_flush(vi->i_sb->s_bdev); > if (likely(!ret)) > ntfs_debug("Done."); > else > ntfs_warning(vi->i_sb, > "Failed to f%ssync inode 0x%llx. Error %u.", > datasync ? "data" : "", ni->mft_no, -ret); > - if (!ret) > - blkdev_issue_flush(vi->i_sb->s_bdev); > return ret; > } > Looks good to me. Reviewed-by: Baolin Liu