From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FBF84F0535 for ; Wed, 14 Oct 2026 11:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791975752; cv=none; b=VF4s8PGf05IKNbWD9O4Y9yg3AEQ6WEKsz0BDvZWGdDtnsvQkPN+sFjmZzMIOrxi8kl79V41xkI2dvDFESj/PtNd65sgHqnUyR1SOoNX+8W+6Wn7uLfoHG59c2Y77dOmjmdA3ixGyNCF55kNkKrlGIGRnNta33iBUoIHGfc0inho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791975752; c=relaxed/simple; bh=lqtmMOq9NyJHWkCTixF/EfRvdzo9ti4x7BRbdW0dvpo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=buXCWNNLVJpC1B6Thc8QzJYpeR5FmMtVgDxrRowELpYBsSwmbb9hQ18uG+tt4OgmSoZPMNznSPiXk6uvlCPPfnBN1tftluoGHj+KOl63n5SfFDEHUQi/qI4f7KNJaMqS1tAeutDCX+tOVkanS3uyWalf7nHwtQcMDH0Gmb+XYNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BbcPzze0; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BbcPzze0" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4a061a13884so34064155e9.3 for ; Wed, 14 Oct 2026 04:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791975744; x=1792580544; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BooWm7URUcyrH2E2qkRWxlx7KQoz7GWFpr53v56Fl9k=; b=BbcPzze0G7sm+U5rosix6MrInL+KqWVYUz/mHVM3BMQP/SryDr3Py7OMsHqeLXd+3P jEqNiRD2Z0O0iKhJhpjmu+LkcLNRcavskjQ27c1dKeaoXy0cdhkn7cqoJ22a6fcfg1aY InWRYCOFBvzFPkF3C6E9yoDQi3oTwwOyTSYcAw5ZCpcbIYhJWr6xKtKo+xI4CbKc8Fu2 RoCfZ7KOs3Ym91wo+zsy6kem38FW2wYmwShp9T60G2ARGP6+X5Qkj2RaVx+F8FQ0lHqU im0hTpkNBRcsw7wP8BxUAja02M9pv0ztPpDmuuWutnfrwHZJdLoJiMQOXyBfiLA5F3HZ vsJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791975744; x=1792580544; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BooWm7URUcyrH2E2qkRWxlx7KQoz7GWFpr53v56Fl9k=; b=f2WESFSDc+mSMTirQw6nvazFU5/DDDBLyT6cfQeRP52cPwe14sE4kn0aamQtcOeJ1y EAPR+kblicGSSoOEIozaVou/d+BonZV/bvHxrqruaDmGHWuItOEXRRtAzfpDWSZJQlBW djvEu+WdrN7Q1neVBZNVYkqyPd3HLHFx0CEW3GR3W7fzVMb6CpvfiQd662kEqeKsa0Qz jSbHr68GIlyFlFdZ1r5m8O0B95VDi8Jx7XJMRB3ZW1doB/++Chtg7QjI0KhNnrWMYzGD IFdesD4GRWLaQhnI1BnxEz64bLXGFY+CVAfoqGHMTwNOdU9VRcPUNaHdcqe4Umlwa875 bFAQ== X-Forwarded-Encrypted: i=1; AKwUvBxujZfNuvzH0+5PdPwMcgxbAFfA3athGYA+dyJRDDJRtb+hrluMI/HSVpFxpf7bEfh9A2xGJagsIiCwc9g=@vger.kernel.org X-Gm-Message-State: AFq9FYLeGFd3WO2/HkSRH65oiDmgrk64lUDiNvxWrbjv/LL4CAjfVwKy Ezu0149nqMQhDP1wZnZBcP7tLffcgydOK4CmibCkQ0Qp1JGvSxa8LdQL X-Gm-Gg: AYBFou2ThkYUXQ11gGo7+NQByJ4dpKQbEfPmfcVtNOEJjWdPxU6tIKt8KMk0zM5wP3J YHU+kpW18u9sraY1O38o8xhBUOZyPjhkZW0ZuLyAW+/R6lKPsZvNeb+RtEH8BGDFnsxJ598z5fB BhVEOmDCza2W/EJc6uhjK9tpL3Pby7PN/XOyC62k8xRuWeH4kPSMlwt5WE64n9FmS+D/1TReDth Z+dyNBQ1L4CYgIpRW+g7waQrmonsIJZl0ujlL60jm7DTKVYwH4gkrPZneOX/814/EY8JrkGoubS 1tafVN9NL+aL6F4oHs4/1Byy5tPw9OMSLW6H0vRABavNtQxXvX4jDPofwRAJtnNXPB3+Ks7QkKK jQdrMdlhMAZhmy6iJQ7B+ggzxy28UNZoS+txJhkxqs6wxG6MNmm85zFLWEhI/YlROUjcHDSwdma KJ+JMF6hXxUjMZ9+chzOlojd2oiVU00szwUHE6xT4ho+YjX/YNXhRyo+6wyYyghtQcdCNxXdrlr LFADa2uiITeTxej6DjUbiyRV1oDI+Lp7VgC6NPYpPpQaA7AQv+ofYbSbbJBNdwAwn/RUmUrSmR3 BA== X-Received: by 2002:a05:600c:a088:b0:4a0:333:253a with SMTP id 5b1f17b1804b1-4a18e49c331mr307406695e9.14.1791975744203; Wed, 14 Oct 2026 04:02:24 -0700 (PDT) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1b45eb78csm38078845e9.2.2026.10.14.04.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 04:02:23 -0700 (PDT) From: Pavel Begunkov To: linux-block@vger.kernel.org Cc: asml.silence@gmail.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Christoph Hellwig , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Jens Axboe , Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Matthew Brost , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev Subject: [PATCH v11 03/13] block: always adjust bi_offset on bio_advance_iter Date: Wed, 14 Oct 2026 12:02:01 +0100 Message-ID: <8e5a67c2f84b6df99ff57a7b3bf7b289999e0468.1791975048.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend bio_no_advance_iter() iteration to also increment the offset. It's not currently needed because the currently listed request types don't have a buffer, but will be useful once we add bios backed by dma-buf, which don't have a bvec but work with a single range. Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Pavel Begunkov --- drivers/md/dm-io-rewind.c | 6 ++++-- include/linux/bio.h | 12 ++++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-io-rewind.c b/drivers/md/dm-io-rewind.c index 04f3fc8aeb6f..b22719c6411c 100644 --- a/drivers/md/dm-io-rewind.c +++ b/drivers/md/dm-io-rewind.c @@ -113,10 +113,12 @@ static inline void dm_bio_rewind_iter(const struct bio *bio, iter->bi_sector -= bytes >> 9; /* No advance means no rewind */ - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size += bytes; - else + iter->bi_offset -= bytes; + } else { dm_bvec_iter_rewind(bio->bi_io_vec, iter, bytes); + } } /** diff --git a/include/linux/bio.h b/include/linux/bio.h index 17944e44b584..892ca469c570 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -113,11 +113,13 @@ static inline void bio_advance_iter(const struct bio *bio, { iter->bi_sector += bytes >> 9; - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size -= bytes; - else + iter->bi_offset += bytes; + } else { bvec_iter_advance(bio->bi_io_vec, iter, bytes); /* TODO: It is reasonable to complete bio with error here. */ + } } /* @bytes should be less or equal to bvec[i->bi_idx].bv_len */ @@ -127,10 +129,12 @@ static inline void bio_advance_iter_single(const struct bio *bio, { iter->bi_sector += bytes >> 9; - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size -= bytes; - else + iter->bi_offset += bytes; + } else { bvec_iter_advance_single(bio->bi_io_vec, iter, bytes); + } } void __bio_advance(struct bio *, unsigned bytes); -- 2.54.0