From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7FCC2BBCF for ; Wed, 16 Dec 2020 10:11:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08F6E2313C for ; Wed, 16 Dec 2020 10:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbgLPKLW (ORCPT ); Wed, 16 Dec 2020 05:11:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgLPKLR (ORCPT ); Wed, 16 Dec 2020 05:11:17 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8333C06138C; Wed, 16 Dec 2020 02:10:09 -0800 (PST) Received: from [IPv6:2a00:5f00:102:0:b08e:75ff:fe3e:2a49] (unknown [IPv6:2a00:5f00:102:0:b08e:75ff:fe3e:2a49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gtucker) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 5F6C51F448B1; Wed, 16 Dec 2020 10:10:07 +0000 (GMT) Subject: Re: linusw/devel bisection: baseline.bootrr.mediatek-mt8173-pinctrl-probed on mt8173-elm-hana To: Linus Walleij Cc: Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , open list , "kernelci-results@groups.io" , Geert Uytterhoeven , Johan Hovold , Enric Balletbo i Serra , Collabora Kernel ML , Sean Wang , "moderated list:ARM/Mediatek SoC support" References: <5fd76cf2.1c69fb81.6f19b.b16a@mx.google.com> <483b08f2-09c3-e753-d2ce-4e34fee627f3@collabora.com> From: Guillaume Tucker Message-ID: <8e5e0251-9450-5c93-cd2e-c44779a72b0c@collabora.com> Date: Wed, 16 Dec 2020 10:10:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/12/2020 12:20, Linus Walleij wrote: > On Mon, Dec 14, 2020 at 11:28 PM Guillaume Tucker > wrote: > >> Please see the bisection report below about the pinctrl driver >> failing to probe on the arm64 mt8173-elm-hana platform. > > That's an excellent, helpful report which helps a lot! > Thank you for doing this! Thanks for the feedback! Glad this helped. >> This is the error message: >> >> [ 0.051788] gpio gpiochip0: Detected name collision for GPIO name '' >> [ 0.051813] gpio gpiochip0: GPIO name collision on the same chip, this is not allowed, fix all lines on the chip to have unique names >> [ 0.051832] gpiochip_add_data_with_key: GPIOs 377..511 (1000b000.pinctrl) failed to register, -17 >> [ 0.051946] mediatek-mt8173-pinctrl: probe of 1000b000.pinctrl failed with error -22 > > It seems we need to teach the core to ignore the name (empty string). OK great, I see you've sent a patch for that. I'll check if we can confirm it fixes the issue (something I'd like to also automate...). Best wishes, Guillaume