From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751062AbdE2Imp (ORCPT ); Mon, 29 May 2017 04:42:45 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750880AbdE2Imo (ORCPT ); Mon, 29 May 2017 04:42:44 -0400 Subject: Re: [PATCH] ubifs: Add freeze support To: Hyunchul Lee References: <1495755004-17036-1-git-send-email-hyc.lee@gmail.com> <20170527082338.GC32125@infradead.org> <20170529004346.GA10215@sebu> <20170529022444.GA11814@sebu> Cc: Artem Bityutskiy , adrian.hunter@intel.com, linux-kernel@vger.kernel.org, kernel-team@lge.com, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig From: Richard Weinberger Message-ID: <8e61baf3-a78e-d17f-ebe2-cd56d6c52259@nod.at> Date: Mon, 29 May 2017 10:42:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170529022444.GA11814@sebu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hyunchul, Am 29.05.2017 um 04:24 schrieb Hyunchul Lee: >>> This is just broken. First ubifs should still properly propagate >>> the errors, and second freezing/unfreezing read only file systems is >>> perfectly valid, >> >> it is right. > > if updating TNC is failed, ubifs might become inconsistant and be switched to > read-only mode. for example, when ubifs_jnl_update is called to create a file, > if inserting a znode for new inode is failed, TNC has only a znode for > new dentry. and this can be only recoverd by replay. > > is it required to fix this? UBIFS is designed to be power-cut tolerant. So, UBIFS must not corrupt in any case. Which failure are you facing? I have the feeling that you try to paper over some other issue. :-) Thanks, //richard