From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a4i518.smtp2go.com (a4i518.smtp2go.com [158.120.82.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5510E3081BE for ; Thu, 25 Jun 2026 19:46:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=158.120.82.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782416766; cv=none; b=HZ0skpRLzEG+LzeU0ZdZWG8rILsKN6o+y1OnixXsfR59In77wz6yOsCWGKC9JngE1ihaqXssh6GX1veaCqcEP918SnYCJbdCsLdyQ7k7ViecT9BdHqYTiJoTlawfCMmqwgUQlKHBdoEr3uqC+V1RAiM/McwLMrn/H0rqrYOwoHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782416766; c=relaxed/simple; bh=2j5YQqRxM90nbieVbcpgi8SSnNBnyvb+NBBBXQwhwbY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h5WHJniRX245TGBwZnydIjc7uyblNQ5Oa2vYSYT6O+d4aIuqAg1uL9MbP8h+GFpCH111jMJFxwTNihcua5ysDc9N6NpJ9ughbMdPiDAakN/yipvdrop8Goja3WtjJxORMSSv9yPOkXfA5XtiacHjrwOh7mCDdjh0iQup2FXmW6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=haghiri.net; spf=pass smtp.mailfrom=em670074.haghiri.net; dkim=pass (2048-bit key) header.d=haghiri.net header.i=@haghiri.net header.b=SmAT+QbM; arc=none smtp.client-ip=158.120.82.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=haghiri.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em670074.haghiri.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=haghiri.net header.i=@haghiri.net header.b="SmAT+QbM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haghiri.net; i=@haghiri.net; q=dns/txt; s=s670074; t=1782416764; h=from : subject : to : message-id : date; bh=4FDASpAZewTAw9aVPec4IBz0vmR8o1gLUU6QhtvS7Ek=; b=SmAT+QbMshkteTjyFV8qscycEznxtoW+84g9x7jSoaQ+cKEMne6SUI0tp+xx7bFfADoDY rBqFHU6S15FbbKFkG2ygen6oAHVzDuWXQlgFw+cmU79ZdDl8NsSlZmv7KRn/4FRPEuX9LyF 4aFvreOK+h6VEyEoxotr4CmR7LgQKukiQGWbk/4VLWxtrfL9MMDnpAFnWQW+hrNDFjuuHJ+ HTUopdquM+VoYAFEGuFwBqj3E1/XUDe2T6l/sXb4DkcjDe4OmIDtcmv1IwUL64NtUwWp4pV SOnAxcmKLNMnd8radIucIP3KqUGZo1YY7gTQ3A/Gu6q5+3nllUMbIFzymdxg== Received: from [10.132.241.142] (helo=[10.161.48.225]) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim 4.99.4) (envelope-from ) id 1wcq1C-4o5NDgrhWwe-hkHe; Thu, 25 Jun 2026 19:45:46 +0000 Message-ID: <8e62f139-1d61-433e-8029-b10025a289d3@haghiri.net> Date: Thu, 25 Jun 2026 15:45:44 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Linux) Subject: Re: [RFC PATCH] drm/amd/display: extend HPD debounce filter to DisplayPort SST To: Ivan Lipski , amd-gfx@lists.freedesktop.org, Alex Deucher Cc: Harry Wentland , Leo Li , Ivan Lipski , Rodrigo Siqueira , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260625150439.330875-1-nick@haghiri.net> <928d4c2a-d8b7-43d7-995e-a3e6996d2952@amd.com> Content-Language: en-US From: Nick Haghiri In-Reply-To: <928d4c2a-d8b7-43d7-995e-a3e6996d2952@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Report-Abuse: Please forward a copy of this message, including all headers, to Feedback-ID: 670074m:670074aX29xAY:670074syjoatcHpi X-smtpcorp-track: xR13CVKCcJ3F.7IuOM44_cyEZ.KFudug9ilAy On 6/25/26 3:15 PM, Ivan Lipski wrote: > I don't think I've encountered a situation when a monitor with DP can > wake a system up from DPMS, so that's interesting. What distro and > desktop environment are you using? I'd like to reproduce this issue > and help with it. openSUSE Tumbleweed, KDE Plasma 6.7 on Wayland (KWin). GPU is an RX 9070 XT (RDNA4), monitor is an MSI MPG 274U over DisplayPort SST. What happens: when the output goes DPMS-off and the monitor drops into deep sleep, it briefly de-asserts and re-asserts HPD. amdgpu forwards that as a hotplug, KWin re-probes and re-enables the output, and the panel comes right back on, so it never actually stays asleep while connected. I suspect the monitor's input auto-scan plays a part, but disabling auto-scan on the monitor did not stop the HPD toggle, so it looks like panel-side behavior on entering deep sleep rather than something the user can turn off. To watch it, enable drm logging: echo 0x16 > /sys/module/drm/parameters/debug then force DPMS-off on the DP output (kscreen-doctor --dpms off, or just let it idle). On the stock driver you get a link_set_dpms_off quickly followed by a spurious detect and a link_set_dpms_on. With the debounce set, the toggle is coalesced and it stays off. I am happy to send the monitor's EDID and a full drm.debug trace off-list if that helps. Its EDID identifies as manufacturer MSI, product code 0x3CF0, i.e. drm_edid_encode_panel_id('M', 'S', 'I', 0x3CF0) for the apply_edid_quirks() switch. > I think generalizing the hpd_debounce_delay for both DP and HDMI would > be better. If you're open to it, I will fold it into a single hpd_debounce_delay_ms that applies to both HDMI and DP SST (eDP and MST still excluded), and rename the internal hdmi_* field, work, and prev_sink to generic hpd_* while I am there. One question on the existing knob: hdmi_hpd_debounce_delay_ms already shipped. Would you rather I keep it as a back-compat alias of the generic one, or just replace it since it is only a couple of cycles old? I will go with whichever you prefer. > Maybe we can also enable hpd_debounce_delay by default for monitors, > that are known to have this issue, using apply_edid_quirks I like that. It could make it work out of the box instead of needing a module param. I can add an apply_edid_quirks() case for the MSI MPG 274U (panel id above) that sets a sane default, and keep the module param as a global override. 1500 ms is what reliably works in the testing I've done, but I can tune that down if you want a smaller default. Thanks for the quick and helpful review. -- Nick Haghiri