From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112F03D4111; Mon, 9 Mar 2026 14:56:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773068166; cv=none; b=g3XmVm2K0Ah2wBIh1N22L7dCDFOTf+ws0T2NsG0UDTsGmiMVoy2g41wn+p4AEkfhGTbHp3//cXWVBtdUSkcPo/to8oVc+MrcsZLKoCHLaj1asKzSKE+WyUgaaWErldnFlZWsUSrxRcIh/AstB3iYKOxaDeyQxM7XyKrNn1klaec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773068166; c=relaxed/simple; bh=a2o6wkGUTzWJts0DBaZ8S7M4ZUDxVHC0KftsZtr0014=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jAuBigjAU8Q1hWICzinXPPLBoD2q3/jFtlmA12jk3gGXelRQXKMwpTQVbzz46WSan3wc0tvbvSPIPENhEFFKnfqlSzPXhwiENV5UU4LRJEFl8s3x0E7qObbo8++T1YS0DrYS3V6fvE9EXKl5u360pezn5lZM2gV90p9yKGEmhsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PErziyp8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PErziyp8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFB45C4CEF7; Mon, 9 Mar 2026 14:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773068165; bh=a2o6wkGUTzWJts0DBaZ8S7M4ZUDxVHC0KftsZtr0014=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=PErziyp8EWKnAsLwFOD0erU62v7JpYOmt1nj65C5hPhy6vnEl9X7e3gz7HIXL5qHj y2RgVxrvtRQmTH6nM9/588kssnzUL0AXCIuR6yUFdwAgu6gpHqVhq3AVQem+fW/Tek ceGw1eoGibgGb9dt86NYS8dax8GN4tKSdAyRPJv8ps97QfRmd8Q2p7Vjq+SXScLEVx 4lD4dDvNvSOrSFpUgbM6I4/nqHAob7K+G8Q3fF+7dPoKhTELdQlIdSFF+jky3JLRAZ t3GruGaNltFxgUH+i3yA3yxK7iMKSCc75E13CbawfEJj0JYrb6N8MLgLL/AJSbpsUT 2TBNNqhGP4RYA== Message-ID: <8e68da17ad8c9584d8082441331d91ab2d6cbb81.camel@kernel.org> Subject: Re: [PATCH v2] vfs: remove externs from fs.h on functions modified by i_ino widening From: Jeff Layton To: Jan Kara Cc: Alexander Viro , Christian Brauner , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 09 Mar 2026 10:56:02 -0400 In-Reply-To: References: <20260307-iino-u64-v2-1-a1a1696e0653@kernel.org> <214341c4753f7ce61d9b01155e9c493e880b7bbd.camel@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-03-09 at 15:46 +0100, Jan Kara wrote: > On Mon 09-03-26 09:27:47, Jeff Layton wrote: > > On Mon, 2026-03-09 at 13:27 +0100, Jan Kara wrote: > > > On Mon 09-03-26 07:53:51, Jeff Layton wrote: > > > > On Mon, 2026-03-09 at 11:02 +0100, Jan Kara wrote: > > > > > On Sat 07-03-26 14:54:31, Jeff Layton wrote: > > > > > > Christoph says, in response to one of the patches in the i_ino = widening > > > > > > series, which changes the prototype of several functions in fs.= h: > > > > > >=20 > > > > > > "Can you please drop all these pointless externs while you'= re at it?" > > > > > >=20 > > > > > > Remove extern keyword from functions touched by that patch (and= a few > > > > > > that happened to be nearby). Also add missing argument names to > > > > > > declarations that lacked them. > > > > > >=20 > > > > > > Suggested-by: Christoph Hellwig > > > > > > Reviewed-by: Christoph Hellwig > > > > > > Signed-off-by: Jeff Layton > > > > > ... > > > > > > -extern void inode_init_once(struct inode *); > > > > > > -extern void address_space_init_once(struct address_space *mapp= ing); > > > > > > -extern struct inode * igrab(struct inode *); > > > > > > -extern ino_t iunique(struct super_block *, ino_t); > > > > > > -extern int inode_needs_sync(struct inode *inode); > > > > > > -extern int inode_just_drop(struct inode *inode); > > > > > > +void inode_init_once(struct inode *inode); > > > > > > +void address_space_init_once(struct address_space *mapping); > > > > > > +struct inode *igrab(struct inode *inode); > > > > > > +ino_t iunique(struct super_block *sb, ino_t max_reserved); > > > > >=20 > > > > > I've just noticed that we probably forgot to convert iunique() to= use u64 > > > > > for inode numbers... Although the iunique() number allocator migh= t prefer > > > > > to stay within 32 bits, the interfaces should IMO still use u64 f= or > > > > > consistency. > > > > >=20 > > > >=20 > > > > I went back and forth on that one, but I left iunique() changes off > > > > since they weren't strictly required. Most filesystems that use it > > > > won't have more than 2^32 inodes anyway. > > > >=20 > > > > If they worked before with iunique() limited to 32-bit values, they > > > > should still after this. After the i_ino widening we could certainl= y > > > > change it to return a u64 though. > > >=20 > > > Yes, it won't change anything wrt functionality. I just think that if= we go > > > for "ino_t is the userspace API type and kernel-internal inode number= s > > > (i.e. what gets stored in inode->i_ino) are passed as u64", then thi= s > > > place should logically have u64... > > >=20 > >=20 > > I think we'll need a real plan for this. >=20 > > =20 > > It certainly wouldn't hurt to make these functions return a u64 type, > > but I worry a little about letting them return values bigger than > > UINT_MAX: > >=20 > > One of my very first patches was 866b04fccbf1 ("inode numbering: make > > static counters in new_inode and iunique be 32 bits"), and it made > > get_next_ino() and iunique() always return 32 bit values.=C2=A0 > >=20 > > At the time, 32-bit machines and legacy binaries were a lot more > > prevalent than they are today and this was real problem. I'm guessing > > it's not so much today, so we could probably make them return real 64- > > bit values. That might also obviate the need for locking in these > > functions too. >=20 > Hum, I think I still didn't express myself clearly enough. I *don't* want > to change values returned from get_next_ino() or iunique(). I would leave > that for the moment when someone comes with a need for more than 4 billio= ns > of inodes in a filesystem using these (which I think is still quite a few > years away). All I want is that in-kernel inode number is consistently > passed as u64 and not as ino_t. So all I ask for is this diff: >=20 > - ino_t iunique(struct super_block *sb, ino_t max_reserved) > + u64 iunique(struct super_block *sb u64 max_reserved) > ... > static unsigned int counter; > - ino_t res; > + u64 res; >=20 > and that's it. I.e., the 'counter' variable that determines max value of > returned number stays as unsigned int. Sure, that's simple enough, though I wonder whether it's the right thing to do: Both these functions return a max values of UINT_MAX, so maybe they should return u32 instead? If you make them return u64, then this limitation isn't evident unless you look at the function itself. I'm also wondering whether we should just go ahead and revamp them to return real 64-bit values. When the collision risk goes away, then we don't need the spinlock in iunique(), for instance. We could just make that use an atomic64_t (or do something creative with percpu values). --=20 Jeff Layton