From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D374C05027 for ; Tue, 14 Feb 2023 18:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232663AbjBNSbE (ORCPT ); Tue, 14 Feb 2023 13:31:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbjBNSbC (ORCPT ); Tue, 14 Feb 2023 13:31:02 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55EBB2C647; Tue, 14 Feb 2023 10:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=txgtixKW7VrUQkrQdJH5MMVOgQ+O3F4VEtjOSuR+WFs=; b=cAF5cDPHDwHYrrTDHykc6PKy2K 0Vdty9nUVhJMreDBwp0A+QelMEkTj+FQgFHmpBA3jdct4C8BHjDIvcGmb3d1pOQ+z2POFvCGNzopk jcStwsIAjRcGUh3x33fJGFLSg0LdDd7duWIsVsyg7zOMQawQeopx2J7GsH6y59pJ+mLur3BH2i06o CDXKnY/GEI6lk5pKVNEWkamnZkVLV9BUdazfeew71ouPgPEfwIVZYTZ/hlJIG3yRPtcxNf1Cc0xI7 ooZO05yGoefN11eQUnn5NN0ywXvPZx5oT2ekRFFaxwO3hchkKxtSp678MrmkDkAkOMM8rC0WBTBpA NrIQPKuQ==; Received: from [2601:1c2:980:9ec0::df2f] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pS04u-003BDQ-2H; Tue, 14 Feb 2023 18:30:56 +0000 Message-ID: <8e6977b8-d256-4e51-82b7-e36d6ca259dc@infradead.org> Date: Tue, 14 Feb 2023 10:30:54 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 0/3] IRQ_DOMAIN: remove all "depends on", use only "select" Content-Language: en-US To: Arnd Bergmann , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi , Donggeun Kim , Marc Zyngier , Philipp Zabel , Peter Rosin , Greg Kroah-Hartman , Geert Uytterhoeven , Rob Herring , Eddie Huang , Sean Wang , Matthias Brugger , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230213041535.12083-1-rdunlap@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/13/23 00:05, Arnd Bergmann wrote: > On Mon, Feb 13, 2023, at 05:15, Randy Dunlap wrote: >> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set >> it directly thru "make *config", so drivers should select it instead >> of depending on it if they need it. >> Relying on it being set for a dependency is risky. >> >> Consistently using "select" or "depends on" can also help reduce >> Kconfig circular dependency issues. >> >> IRQ_DOMAIN is selected 109 times and is depended on 3 times in >> current linux-next. Eliminate the uses of "depends on" by >> converting them to "select". >> >> [PATCH 1/3] extcon: max8997: select IRQ_DOMAIN instead of depending on it >> [PATCH 2/3] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it >> [PATCH 3/3] rtc: mt6397: select IRQ_DOMAIN instead of depending on it > > From a Kconfig perspective, your reasoning makes a lot of sense. > > Looking at the bigger picture, I wonder if we should just remove the > option and make it unconditional. It is enabled in ever architecture > defconfig other than alpha and sparc, and it's selected by a lot of > very common options such as I2C, GENERIC_MSI_IRQ, GENERIC_IRQ_CHIP, > and PCI_HOST_GENERIC. Enabling the option on Alpha grows the kernel > image from 9010KB to 9023KB, or on m68k Coldfire from 3346KB to > 3351KB. Marc, what do you think about this suggestion? Thanks. -- ~Randy