From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: lukas walter <lukas.walter@aceart.de>
Cc: agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org, raymondhackley@protonmail.com,
robh+dt@kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree
Date: Mon, 25 Sep 2023 16:34:44 +0200 [thread overview]
Message-ID: <8e6a41b2-7ad9-4cc6-8f95-93b8c2e4151f@linaro.org> (raw)
In-Reply-To: <9ca32137e42a22b016d8d417ee9e0dc024ef2aa9.camel@aceart.de>
On 25.09.2023 16:28, lukas walter wrote:
> Date: Wed, 20 Sep 2023 16:47:30 +0200
>
>>> +
>>> + reserved-memory {
>>> + reserved@84a00000 {
>>> + reg = <0x0 0x84a00000 0x0 0x1600000>;
>>> + no-map;
>>> + };
>> Do we know what this is for?
>
> This seems to be some QSEE/TrustZone memory required to boot.
> I would name it `qseecom_mem: qseecom@84a00000` like other phones
> currently have it.
>
> `[ 1.162115] QSEECOM: qseecom_probe: secure app region
> addr=0x84a00000 size=0x1900000`
Sounds good!
>
>>> + };
>>> +
>>> + gpio-hall-sensor {
>>> + compatible = "gpio-keys";
>>> +
>>> + pinctrl-0 = <&gpio_hall_sensor_default>;
>>> + pinctrl-names = "default";
>>> +
>>> + label = "GPIO Hall Effect Sensor";
>> I think we can have both hall sensor and V+ under gpio-keys
>>
>> And then I am not sure how useful the label is for the container
>> node, maybe you or somebody else can tell me whether it's used
>> anywhere
>>> +
>>> + event-hall-sensor {
>>> + label = "Hall Effect Sensor";
>>> + gpios = <&tlmm 69 GPIO_ACTIVE_LOW>;
>>> + linux,input-type = <EV_SW>;
>>> + linux,code = <SW_LID>;
>>> + linux,can-disable;
>> Should this not be a wakeup-source btw?
>
> I am not sure how to change this. I would like to leave this as many
> other hall sensors seem to be configured identically.
Krzysztof, opinions?
>
> Is this fine?
> Should I send a V2 with the signoff and reserved-memory changes?
I don't quite get it, what signoff?
Konrad
next prev parent reply other threads:[~2023-09-25 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 13:41 [PATCH 1/2] dt-bindings: arm: qcom: Add Huawei Honor 5X / GR5 (2016) Lukas Walter
2023-09-16 13:41 ` [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree Lukas Walter
2023-09-16 20:39 ` Krzysztof Kozlowski
2023-09-17 13:17 ` lukas walter
2023-09-17 0:22 ` Bryan O'Donoghue
2023-09-17 13:20 ` lukas walter
2023-09-20 14:47 ` Konrad Dybcio
2023-09-25 14:28 ` lukas walter
2023-09-25 14:34 ` Konrad Dybcio [this message]
2023-10-05 14:20 ` lukas walter
2023-09-16 20:38 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Huawei Honor 5X / GR5 (2016) Krzysztof Kozlowski
2023-10-21 14:30 Lukas Walter
2023-10-21 14:30 ` [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree Lukas Walter
2023-10-21 17:34 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e6a41b2-7ad9-4cc6-8f95-93b8c2e4151f@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.walter@aceart.de \
--cc=phone-devel@vger.kernel.org \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®