From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Fabrice Gasnier <fabrice.gasnier@st.com>, <jic23@kernel.org>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>
Cc: <vkoul@kernel.org>, <linux-iio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
Olivier MOYSAN <olivier.moysan@st.com>
Subject: Re: [PATCH v2] iio: adc: stm32-adc: Use dma_request_chan() instead dma_request_slave_channel()
Date: Wed, 8 Jan 2020 10:04:14 +0200 [thread overview]
Message-ID: <8e706545-958d-1c34-9d6d-addd4cb6af25@ti.com> (raw)
In-Reply-To: <5146b085-d92d-7230-9a05-87926711dafa@st.com>
Hi Fabrice,
On 07/01/2020 19.15, Fabrice Gasnier wrote:
> On 1/7/20 12:41 PM, Peter Ujfalusi wrote:
>> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
>> eating up the error code.
>>
>> By using dma_request_chan() directly the driver can support deferred
>> probing against DMA.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> Hi,
>>
>> Changes since v1:
>> - Fall back to IRQ mode only in case of ENODEV
>>
>> Regards,
>> Peter
>
> Hi Peter,
>
> Thanks for the patch,
>
> In case you send another version... I've just a minor suggestion
> regarding the comment (see after). Apart from that, you can add my:
Thanks, I'll take your suggested update and send v3.
> Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>
> Best Regards,
> Fabrice
>
>>
>> drivers/iio/adc/stm32-adc.c | 16 ++++++++++++++--
>> 1 file changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
>> index 3b291d72701c..df5f5d61f9f9 100644
>> --- a/drivers/iio/adc/stm32-adc.c
>> +++ b/drivers/iio/adc/stm32-adc.c
>> @@ -1746,9 +1746,21 @@ static int stm32_adc_dma_request(struct iio_dev *indio_dev)
>> struct dma_slave_config config;
>> int ret;
>>
>> - adc->dma_chan = dma_request_slave_channel(&indio_dev->dev, "rx");
>> - if (!adc->dma_chan)
>> + adc->dma_chan = dma_request_chan(&indio_dev->dev, "rx");
>> + if (IS_ERR(adc->dma_chan)) {
>> + ret = PTR_ERR(adc->dma_chan);
>> + if (ret != -ENODEV) {
>> + if (ret != -EPROBE_DEFER)
>> + dev_err(&indio_dev->dev,
>> + "DMA channel request failed with %d\n",
>> + ret);
>> + return ret;
>> + }
>> +
>> + /* Ignore errors to fall back to IRQ mode */
> ^
> error
> alternate suggestion:
> /* DMA is optional: fall back to IRQ mode */
Makes more sense in the context.
>
>> + adc->dma_chan = NULL;
>> return 0;
>> + }
>>
>> adc->rx_buf = dma_alloc_coherent(adc->dma_chan->device->dev,
>> STM32_DMA_BUFFER_SIZE,
>>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2020-01-08 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 11:41 Peter Ujfalusi
2020-01-07 17:15 ` Fabrice Gasnier
2020-01-08 8:04 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e706545-958d-1c34-9d6d-addd4cb6af25@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alexandre.torgue@st.com \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@st.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®