From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBF0E262FC5 for ; Mon, 23 Jun 2025 15:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750693892; cv=none; b=eGj7QTaj4yGvdXuEe5GFQmNQurJwhwrxFZkwrZgivXIkys8yxXxWBmucI+5df7xrwf4Nvmp6lr+uInAz9Z3kmBxfezdbvvKVY6zGN05O1xexCpfPNOwJN0OeBlkm+YeJ1AeuSlHeFV7bgYLBLmqm1EebDc1bJBxGkXFEKO8aj6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750693892; c=relaxed/simple; bh=Wnm6+7ET2gLRuAI5Dm0HPnfT3cPMqm8XHbu23UksxCE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g2D8bmXsVlsi3Cd/br3yMWI8Dmks/tkWIWWPu/YzleJJ/L5/cz0X7QIVciqSH0cRkwZE8fyw/nwTfUhDSlMgf21cXfCqKco5noHLhAwHkCQ9FjcawpBKaU0J+I1QKTHtoqtvfRQtCLvCIYNKg5wFUJjBYJm7biEs1dC2fATzUSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pivD3wi+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pivD3wi+" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55N990CW027754 for ; Mon, 23 Jun 2025 15:51:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tYYI1PSVSslndP+Y1vEtSWhPe5cDz1pruNBScyDqPIM=; b=pivD3wi+mToh+Aj4 iusKU7MzEl1DNzvcwUV9uWR9giA/Uh4clsHW2ze/6FeHCN7H0NuWti5nsNw0VLB3 JL2BBbjd6H/7iMzJfzCs2dGHh8Fr1Y22bXa90iOa4iyLj3Z/ESJzteuuAS5lifM5 1AG4gil4mmdm76m7GKQ6bUeUHiOHeC+FwBGLZGM/cqfqNksyZj5YbJzgMjGOmyMy 2sQuVLcTHdh3nLZsr1TRMFf2F8i1LXUxhbX/A0x0TU0/brfVFDD5Qtv9+bt5bCL7 e6FCSgjvI5rPKtRp/zkuWiL0zWY2jPRsczMBxc8wmMG9Q/KcNKoPjqJ2s2lfd/UR 7nW+Yw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47ec263dp4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 23 Jun 2025 15:51:30 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b1442e039eeso2927939a12.0 for ; Mon, 23 Jun 2025 08:51:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750693889; x=1751298689; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tYYI1PSVSslndP+Y1vEtSWhPe5cDz1pruNBScyDqPIM=; b=XogxaztlBwuyjqU0XLOtKyzL9G8A6qf6ao/O0GnYtyLyuYeWqX6trutBOJuuH7vb3P xsQKYuN7T3FeEpata0ltLmYW9Xu/FTSNtPD33X73vCjB5DrmB05FVqP/vMZxZWn0BLh/ kKR4JJDy6UcQgvLZbbvdvn1iOt8tqJ+9yA3TbunH5MPASDP0q06zAst0+axr1W5CnmZt 1oLlz3KVjwwUVSvNeYTJffQK4/gc4i6TlM0/kBsxtkaRVctdDjqQaoH33x6jrIwqoGs2 VvIDXjNiYobCCoV/No38B9dl6CvE60856nl6mrFF/f+KN91jW6K2lmnaNe9o63SbzuL7 gRMw== X-Forwarded-Encrypted: i=1; AJvYcCVoEKKWt8KsRc1aqz7rDzefKoeHJT+ArPlMZ7TqubowcHMtJ12/PK8kmAZHnLTh+UyQ0DBde12REwb8luk=@vger.kernel.org X-Gm-Message-State: AOJu0YwRXceMo5MVGsyj+1cmhfx5unA4hZboDHOUG2eZ5jCW2drxSsJL xm7iTTAmx73TEzmO+xd5B9Q31kOk9RQsiw5+ipHXHf/BS2Blw4TP/V0LRr4oFHC7i/3N+yput7C LMZiW0zv1b405OKYrWtx4qn2S+FbBS/gsvP4OSPc7BleqQmljMxWpTos53IuRHB5R8rE= X-Gm-Gg: ASbGnctj8A/ipO2SW4deakL3jvKXsOQD8Rhtjjzc+qKDPRpSfl2BwwwkLP/Kpw8GHiz HHn3HSZLH7ax0Rhe1Is9zMXiRn7UOiGvANrx1YCvW4dvKGpK4RU45WSN7gQLLi537PIC/hL23Fn ydNFdBFBOm61SCopA32HvJpQJPhACr1YwCVqr3vnscQ6YO0ryhMvSdnR/LBK4j3XqCnk0howRnh TOqJCTJ+cL5WUM5djhaHA3Fo7zL3R/q2ZcKhidFa5ObHu/O6rPyx13kgVV3R9jVRKMfUMCBIuFr afn3Zw6/9luE/Luye5SaNUHOsxUy7Zt1BfZmWDbvEmoSr7NF5JaEWkUrLT4Whg== X-Received: by 2002:a05:6a20:3d1a:b0:218:5954:128c with SMTP id adf61e73a8af0-22026f666ecmr17570749637.21.1750693889139; Mon, 23 Jun 2025 08:51:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTB8GCNbc/2fzaaqVs5wa367l84r5Matp1+jHk+iiUoxVmPBfLwYPyatl5Ffn2X2iX0KN87Q== X-Received: by 2002:a05:6a20:3d1a:b0:218:5954:128c with SMTP id adf61e73a8af0-22026f666ecmr17570718637.21.1750693888678; Mon, 23 Jun 2025 08:51:28 -0700 (PDT) Received: from [192.168.29.88] ([49.37.214.199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7490a62633fsm8440158b3a.84.2025.06.23.08.51.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 08:51:28 -0700 (PDT) Message-ID: <8e774154-1594-452c-858a-e16376dee09d@oss.qualcomm.com> Date: Mon, 23 Jun 2025 21:21:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next 0/2] wifi: ath12k: use real noise floor value To: Jeff Johnson , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, Raj Kumar Bhagat References: <20250528-support_real_noise_floor-v1-0-04507bd3bc76@oss.qualcomm.com> <500a10c9-c56e-4192-818e-8e07ef6c51f4@oss.qualcomm.com> Content-Language: en-US From: Aditya Kumar Singh In-Reply-To: <500a10c9-c56e-4192-818e-8e07ef6c51f4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIzMDA5NiBTYWx0ZWRfXx6Fld3W8yaB/ jTgENw6hAiVzp1VE7iSKX0aa0CbUmGxxLSSViSKrdEdYNZECGbKK3G4xLTCW69QsZEqUsx13ife HvQrj0BW+aVIRQf3Y2mtmfE6hqQW96hMn3YJQ9REAFN7L3ILNKZTDzgwp4zrSRfgGwvrjO5qUMO 6THw3Mq+W/RwyBiZO9RbJijSBX/LxUCS0GArraSLuzP2Nq7XhRyVR2REB1qASN76OGuBzmGmy/u /QolJ/bY511SqyBdTdYCH+7MdMPjMxwjN+SZ/h+rRL1NkDm/KbX6kAQlTVRUVWFZoydk6NZR3SJ QyQKxkcPRqJv/E9Xzi6hTe8mfNpkdN4FkQlgEHciWdUCzMcCrrC0pov2tJlFGM5q+spJ9XxQBPq gaIMoRGLeLRDXpJ3qg5hW6wWxAcWm3+jWkZYe0viLWcx0s9VJcX9KjUbItqcbyw4KMEPzZMr X-Authority-Analysis: v=2.4 cv=XPQwSRhE c=1 sm=1 tr=0 ts=68597802 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=wMrS+Y4uhDqG1CA/WHymIw==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=eRXGc6zcnUY8UlbqGOwA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-GUID: VPGv8bbYAzHAw9MjCZ9W2sU9VoE4pEZk X-Proofpoint-ORIG-GUID: VPGv8bbYAzHAw9MjCZ9W2sU9VoE4pEZk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-23_04,2025-06-23_06,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506230096 On 6/23/2025 8:30 PM, Jeff Johnson wrote: > On 5/28/2025 4:23 AM, Aditya Kumar Singh wrote: >> At present, the ATH12K_DEFAULT_NOISE_FLOOR (-95) is used to calculate RSSI >> value, providing an estimated noise floor value. Consequently, the RSSI >> value is also approximate. This works but however, using actual noise floor >> value will enable the reporting of the true RSSI value. >> >> The firmware possesses the necessary data to determine the actual noise >> floor. This data is provided to the host via the WMI event >> WMI_PDEV_RSSI_DBM_CONVERSION_PARAMS_INFO_EVENTID, which includes the >> runtime parameters needed for calculating the real noise floor in dBm. This >> event is triggered by the firmware during channel changes, temperature >> offset adjustments, and hardware chainmask modifications. >> >> Add support to handle and parse this WMI event. Use the received values to >> calculate and store the noise floor value and use at the required places. >> >> --- >> Raj Kumar Bhagat (2): >> wifi: ath12k: handle WMI event for real noise floor calculation >> wifi: ath12k: use real noise floor instead of default value >> >> drivers/net/wireless/ath/ath12k/core.h | 17 +++ >> drivers/net/wireless/ath/ath12k/dp_mon.c | 7 +- >> drivers/net/wireless/ath/ath12k/dp_tx.c | 20 ++- >> drivers/net/wireless/ath/ath12k/mac.c | 14 +- >> drivers/net/wireless/ath/ath12k/wmi.c | 233 ++++++++++++++++++++++++++++++- >> drivers/net/wireless/ath/ath12k/wmi.h | 42 ++++++ >> 6 files changed, 324 insertions(+), 9 deletions(-) >> --- >> base-commit: 3d933084a072fd5fb5da54c06a017abc0412c86f >> change-id: 20250513-support_real_noise_floor-205986936cd3 > > This series no longer applies cleanly on ath/main, please rebase > > Applying: wifi: ath12k: handle WMI event for real noise floor calculation > Using index info to reconstruct a base tree... > M drivers/net/wireless/ath/ath12k/core.h > M drivers/net/wireless/ath/ath12k/mac.c > M drivers/net/wireless/ath/ath12k/wmi.c > M drivers/net/wireless/ath/ath12k/wmi.h > Falling back to patching base and 3-way merge... > Auto-merging drivers/net/wireless/ath/ath12k/wmi.h > CONFLICT (content): Merge conflict in drivers/net/wireless/ath/ath12k/wmi.h > Auto-merging drivers/net/wireless/ath/ath12k/wmi.c > Auto-merging drivers/net/wireless/ath/ath12k/mac.c > Auto-merging drivers/net/wireless/ath/ath12k/core.h > Recorded preimage for 'drivers/net/wireless/ath/ath12k/wmi.h' > error: Failed to merge in the changes. > Patch failed at 0001 wifi: ath12k: handle WMI event for real noise floor calculation Done. Rolled out the rebased next version. -- Aditya