From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Herman van Hazendonk <github.com@herrie.org>,
Antony Kurniawan Soemardi <linux@smankusors.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [RFC PATCH] clk: qcom: hfpll: return lock timeout from enable paths
Date: Tue, 23 Jun 2026 11:43:50 +0200 [thread overview]
Message-ID: <8e7a4cd1-ff17-4052-938b-5cb2ee8576f0@oss.qualcomm.com> (raw)
In-Reply-To: <20260623060517.10889-1-pengpeng@iscas.ac.cn>
On 6/23/26 8:05 AM, Pengpeng Hou wrote:
> The HFPLL enable helper waits for the lock bit but ignores the
> regmap_read_poll_timeout() result. The polling condition is also
> inconsistent with clk_hfpll_init(), which treats the lock bit being set
> as the locked state.
>
> Wait for the lock bit to become set, return timeout errors from the
> helper, and propagate those errors through clk_hfpll_enable() and
> clk_hfpll_set_rate() instead of enabling the output unconditionally.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
This looks good on the surface..
+Herman, Anthony, Dmitry could you please give this a spin on 8x60?
Konrad
next prev parent reply other threads:[~2026-06-23 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 6:05 Pengpeng Hou
2026-06-23 9:43 ` Konrad Dybcio [this message]
2026-06-24 1:57 ` Antony Kurniawan Soemardi
2026-06-24 7:39 ` Konrad Dybcio
2026-06-28 18:07 ` Antony Kurniawan Soemardi
2026-06-29 9:15 ` Konrad Dybcio
2026-06-29 15:14 ` Antony Kurniawan Soemardi
2026-07-01 12:11 ` Konrad Dybcio
2026-07-04 9:02 ` Antony Kurniawan Soemardi
2026-07-06 10:58 ` Konrad Dybcio
2026-07-08 16:04 ` Antony Kurniawan Soemardi
2026-07-17 11:28 ` Konrad Dybcio
2026-07-20 20:18 ` Antony Kurniawan Soemardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7a4cd1-ff17-4052-938b-5cb2ee8576f0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=github.com@herrie.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@smankusors.com \
--cc=mturquette@baylibre.com \
--cc=pengpeng@iscas.ac.cn \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®