From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: Explain PDU in CAN_ISOTP help text
Date: Tue, 13 Oct 2020 18:43:50 +0200 [thread overview]
Message-ID: <8e7bface-eef3-c5eb-a822-aec79c6992ac@hartkopp.net> (raw)
In-Reply-To: <20201013141341.28487-1-geert+renesas@glider.be>
On 13.10.20 16:13, Geert Uytterhoeven wrote:
> The help text for the CAN_ISOTP config symbol uses the acronym "PDU".
> However, this acronym is not explained here, nor in
> Documentation/networking/can.rst.
> Expand the acronym to make it easier for users to decide if they need to
> enable the CAN_ISOTP option or not.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Yes, when you are so deep into it that PDU becomes a word like dog or
cat ;-)
Thanks,
Oliver
> ---
> net/can/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/can/Kconfig b/net/can/Kconfig
> index 224e5e0283a986d9..7c9958df91d353c8 100644
> --- a/net/can/Kconfig
> +++ b/net/can/Kconfig
> @@ -62,8 +62,9 @@ config CAN_ISOTP
> communication between CAN nodes via two defined CAN Identifiers.
> As CAN frames can only transport a small amount of data bytes
> (max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this
> - segmentation is needed to transport longer PDUs as needed e.g. for
> - vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN traffic.
> + segmentation is needed to transport longer Protocol Data Units (PDU)
> + as needed e.g. for vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN
> + traffic.
> This protocol driver implements data transfers according to
> ISO 15765-2:2016 for 'classic' CAN and CAN FD frame types.
> If you want to perform automotive vehicle diagnostic services (UDS),
>
next prev parent reply other threads:[~2020-10-13 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:13 Geert Uytterhoeven
2020-10-13 16:43 ` Oliver Hartkopp [this message]
2020-10-14 6:30 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7bface-eef3-c5eb-a822-aec79c6992ac@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome