From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
eranian@google.com, alexey.budankov@linux.intel.com,
ak@linux.intel.com, mark.rutland@arm.com, megha.dey@intel.com,
frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
kim.phillips@amd.com, linux-kernel@vger.kernel.org,
santosh.shukla@amd.com, ravi.bangoria@amd.com
Subject: Re: [RFC v2] perf: Rewrite core context handling
Date: Tue, 23 Aug 2022 10:27:07 +0530 [thread overview]
Message-ID: <8e8202e2-6e28-61f0-b6b1-d3f782ba90f7@amd.com> (raw)
In-Reply-To: <YwO0Nh5LHZ7uzWvm@worktop.programming.kicks-ass.net>
On 22-Aug-22 10:22 PM, Peter Zijlstra wrote:
> On Tue, Aug 02, 2022 at 11:41:42AM +0530, Ravi Bangoria wrote:
>
>>> @@ -12358,58 +12374,14 @@ SYSCALL_DEFINE5(perf_event_open,
>>> goto err_context;
>>> }
>>>
>>> - event_file = anon_inode_getfile("[perf_event]", &perf_fops, event, f_flags);
>>> - if (IS_ERR(event_file)) {
>>> - err = PTR_ERR(event_file);
>>> - event_file = NULL;
>>> - goto err_context;
>>> - }
>>> -
>>> - if (task) {
>>> - err = down_read_interruptible(&task->signal->exec_update_lock);
>>> - if (err)
>>> - goto err_file;
>>> -
>>> - /*
>>> - * We must hold exec_update_lock across this and any potential
>>> - * perf_install_in_context() call for this new event to
>>> - * serialize against exec() altering our credentials (and the
>>> - * perf_event_exit_task() that could imply).
>>> - */
>>> - err = -EACCES;
>>> - if (!perf_check_permission(&attr, task))
>>> - goto err_cred;
>>> - }
>>> -
>>> - if (ctx->task == TASK_TOMBSTONE) {
>>> - err = -ESRCH;
>>> - goto err_locked;
>>> - }
>>
>> I think we need to keep (ctx->task == TASK_TOMBSTONE) check?
>
> I think so too; in fact the code I have still has it, perhaps it was
> there write before this patch?
>
>>> -
>>> if (!perf_event_validate_size(event)) {
>>> err = -E2BIG;
>>> - goto err_locked;
>>> - }
>>> -
>>> - if (!task) {
>>> - /*
>>> - * Check if the @cpu we're creating an event for is online.
>>> - *
>>> - * We use the perf_cpu_context::ctx::mutex to serialize against
>>> - * the hotplug notifiers. See perf_event_{init,exit}_cpu().
>>> - */
>>> - struct perf_cpu_context *cpuctx =
>>> - container_of(ctx, struct perf_cpu_context, ctx);
>>> -
>>> - if (!cpuctx->online) {
>>> - err = -ENODEV;
>>> - goto err_locked;
>>> - }
>>> + goto err_context;
>>
>> Why did you remove this hunk? We should confirm whether cpu is online or not
>> before creating event. No?
>
> Idem.
>
> Perhaps it is best if we look at the end result of all these patches
> combined and then I'll fold the lot if we're in agreement and then we
> can forget about these intermediate steps.
Let me accumulate all these changes, rebase to v6.0-rc2 and send RFC v3.
Thanks,
Ravi
next prev parent reply other threads:[~2022-08-23 4:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 13:47 Ravi Bangoria
2022-01-17 7:18 ` [perf] f7cf7134e4: WARNING:at_kernel/events/core.c:#__pmu_ctx_sched_out kernel test robot
2022-01-31 4:43 ` [RFC v2] perf: Rewrite core context handling Ravi Bangoria
2022-06-13 14:35 ` Peter Zijlstra
2022-06-13 14:36 ` Peter Zijlstra
2022-06-13 14:38 ` Peter Zijlstra
2022-08-02 6:11 ` Ravi Bangoria
2022-08-22 15:29 ` Peter Zijlstra
2022-08-22 15:43 ` Peter Zijlstra
2022-08-22 16:37 ` Ravi Bangoria
2022-08-23 4:20 ` Ravi Bangoria
2022-08-29 3:54 ` Ravi Bangoria
2022-08-23 6:30 ` Peter Zijlstra
2022-08-29 4:00 ` Ravi Bangoria
2022-08-29 11:58 ` Peter Zijlstra
2022-08-22 16:52 ` Peter Zijlstra
2022-08-23 4:57 ` Ravi Bangoria [this message]
2022-06-13 14:41 ` Peter Zijlstra
2022-08-22 14:38 ` Ravi Bangoria
2022-06-13 14:43 ` Peter Zijlstra
2022-08-02 6:16 ` Ravi Bangoria
2022-08-23 8:57 ` Peter Zijlstra
2022-08-24 5:07 ` Ravi Bangoria
2022-08-24 7:27 ` Peter Zijlstra
2022-08-24 7:53 ` Ravi Bangoria
2022-06-13 14:55 ` Peter Zijlstra
2022-08-02 6:10 ` Ravi Bangoria
2022-08-22 16:44 ` Peter Zijlstra
2022-08-23 4:46 ` Ravi Bangoria
2022-06-17 13:36 ` Peter Zijlstra
2022-08-24 10:13 ` Peter Zijlstra
2022-06-27 4:18 ` Ravi Bangoria
2022-08-02 6:06 ` Ravi Bangoria
2022-08-24 12:15 ` Peter Zijlstra
2022-08-24 14:59 ` Peter Zijlstra
2022-08-25 5:39 ` Ravi Bangoria
2022-08-25 9:17 ` Peter Zijlstra
2022-08-25 11:03 ` Ravi Bangoria
2022-08-02 6:13 ` Ravi Bangoria
2022-08-23 7:10 ` Peter Zijlstra
2022-08-02 6:17 ` Ravi Bangoria
2022-08-23 7:26 ` Peter Zijlstra
2022-08-23 15:14 ` Ravi Bangoria
2022-08-22 14:40 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8202e2-6e28-61f0-b6b1-d3f782ba90f7@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=eranian@google.com \
--cc=frederic@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=megha.dey@intel.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=santosh.shukla@amd.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®