From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Weishi Li <liweishi@kylinos.cn>,
airlied@redhat.com, kraxel@redhat.com,
gurchetansingh@chromium.org, olvaffe@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH RESEND] drm/virtio: fix memory leak of vbuf
Date: Tue, 23 Jul 2024 18:52:25 +0300 [thread overview]
Message-ID: <8e8313d4-b748-460b-bcb8-89d738747211@collabora.com> (raw)
In-Reply-To: <20240509015225.38669-1-liweishi@kylinos.cn>
On 5/9/24 04:52, Weishi Li wrote:
> @@ -356,12 +356,14 @@ static int virtio_gpu_queue_ctrl_sgs(struct virtio_gpu_device *vgdev,
>
> ret = virtqueue_add_sgs(vq, sgs, outcnt, incnt, vbuf, GFP_ATOMIC);
> WARN_ON(ret);
> + if (ret < 0 && ret != -ENOSPC) {
> + free_vbuf(vgdev, vbuf);
Don't see why -ENOSPC shouldn't free buffer. If you trying to fix a
theoretical leak, then not worth doing it, IMO. Not apparent how to test
this error code path and it's not easy to review it.
--
Best regards,
Dmitry
next prev parent reply other threads:[~2024-07-23 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 1:52 Weishi Li
2024-07-23 15:52 ` Dmitry Osipenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-22 9:20 Weishi Li
2024-05-07 3:38 Weishi Li
2024-05-08 23:55 ` kernel test robot
2024-04-02 9:39 [PATCH] " Weishi Li
2024-04-29 3:05 ` [PATCH] [PATCH RESEND] " Weishi Li
2024-04-30 21:34 ` kernel test robot
2024-04-30 22:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8313d4-b748-460b-bcb8-89d738747211@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liweishi@kylinos.cn \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®