From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v2 2/5] dt-bindings: serial: document esp32-uart
Date: Wed, 20 Sep 2023 14:34:34 +0200 [thread overview]
Message-ID: <8e8c479e-3f72-ebcf-dbcc-162b193c2e24@linaro.org> (raw)
In-Reply-To: <20230920022644.2712651-3-jcmvbkbc@gmail.com>
On 20/09/2023 04:26, Max Filippov wrote:
> Add documentation for the ESP32xx UART controllers.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>
Thanks for the changes.
> +properties:
> + compatible:
> + enum:
> + - esp,esp32-uart
> + - esp,esp32s3-uart
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
You need allOf with $ref to serial.yaml# (local serial, not absolute
path). I apologize, I missed this in my previous review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-20 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 2:26 [PATCH v2 0/5] serial: add drivers for the ESP32xx serial devices Max Filippov
2023-09-20 2:26 ` [PATCH v2 1/5] serial: core: tidy invalid baudrate handling in uart_get_baud_rate Max Filippov
2023-09-28 8:17 ` Greg Kroah-Hartman
2023-09-28 15:07 ` Max Filippov
2023-09-20 2:26 ` [PATCH v2 2/5] dt-bindings: serial: document esp32-uart Max Filippov
2023-09-20 12:34 ` Krzysztof Kozlowski [this message]
2023-09-20 2:26 ` [PATCH v2 3/5] drivers/tty/serial: add driver for the ESP32 UART Max Filippov
2023-09-20 7:22 ` Jiri Slaby
2023-09-20 8:34 ` Max Filippov
2023-09-20 2:26 ` [PATCH v2 4/5] dt-bindings: serial: document esp32s3-acm Max Filippov
2023-09-20 12:35 ` Krzysztof Kozlowski
2023-09-20 2:26 ` [PATCH v2 5/5] drivers/tty/serial: add ESP32S3 ACM device driver Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8c479e-3f72-ebcf-dbcc-162b193c2e24@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®