From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9828C64EBC for ; Thu, 4 Oct 2018 15:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 874372084D for ; Thu, 4 Oct 2018 15:31:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 874372084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbeJDWYr (ORCPT ); Thu, 4 Oct 2018 18:24:47 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:52180 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727479AbeJDWYr (ORCPT ); Thu, 4 Oct 2018 18:24:47 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8469C206F42F7; Thu, 4 Oct 2018 23:30:55 +0800 (CST) Received: from [127.0.0.1] (10.202.226.41) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.399.0; Thu, 4 Oct 2018 23:30:48 +0800 Subject: Re: [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch To: , References: <1537801594-207139-1-git-send-email-john.garry@huawei.com> CC: , , From: John Garry Message-ID: <8e8d0006-a887-ddf3-0179-49d2370abc68@huawei.com> Date: Thu, 4 Oct 2018 16:30:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1537801594-207139-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.41] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/09/2018 16:06, John Garry wrote: > This patchset introduces mostly more minor/obscure bugfixes for the > driver. Hi Martin, Can you please consider merging this patchset? Thanks, John > > Also included is an optimisation to use the block layer tag for the IPTT > indexing. This quite a nice optimisation as it means we don't have to > evaluate this in the driver - it was a bit of a bottle-neck. > > However it does block us in future from enabling SCSI MQ in the driver. > This is because the IPTT index must be a unique value per HBA. However, > if we switched to SCSI MQ, the block layer tag becomes unique per queue, > and not per HBA. > > Having said this, testing has shown that performance is better by using > this block layer tag instead of enabling SCSI MQ in the driver. > > Luo Jiaxing (2): > scsi: hisi_sas: Feed back linkrate(max/min) when re-attached > scsi: hisi_sas: Move evaluation of hisi_hba in hisi_sas_task_prep() > > Xiang Chen (5): > scsi: hisi_sas: Fix the race between IO completion and timeout for > SMP/internal IO > scsi: hisi_sas: Free slot later in slot_complete_vx_hw() > scsi: hisi_sas: unmask interrupts ent72 and ent74 > scsi: hisi_sas: Use block layer tag instead for IPTT > scsi: hisi_sas: Update v3 hw AIP_LIMIT and CFG_AGING_TIME register > values > > drivers/scsi/hisi_sas/hisi_sas.h | 3 +- > drivers/scsi/hisi_sas/hisi_sas_main.c | 154 ++++++++++++++++++++++++--------- > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 1 - > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +-- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 15 ++-- > 5 files changed, 130 insertions(+), 54 deletions(-) >