From: Yang Yingliang <yangyingliang@huawei.com>
To: "Sanjuán García, Jorge" <Jorge.SanjuanGarcia@duagon.com>,
"jirislaby@kernel.org" <jirislaby@kernel.org>
Cc: "morbidrsa@gmail.com" <morbidrsa@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jth@kernel.org" <jth@kernel.org>,
"Rodríguez Barbarin,
José Javier" <JoseJavier.Rodriguez@duagon.com>
Subject: Re: [PATCH] mcb: fix error handling for different scenarios when parsing
Date: Thu, 7 Sep 2023 09:31:31 +0800 [thread overview]
Message-ID: <8e8d98a0-9111-86e5-38e5-bfa4beb6d1ba@huawei.com> (raw)
In-Reply-To: <20230906143605.1877335-1-jorge.sanjuangarcia@duagon.com>
On 2023/9/6 22:36, Sanjuán García, Jorge wrote:
> chameleon_parse_gdd() may fail for different reasons and end up
> in the err tag. Make sure we at least make sure we always free
> the mcb_device allocated with mcb_alloc_dev().
>
> If mcb_device_register() fails, make sure to give up the reference
> in the same place the device was added.
>
> Fixes: 728ac3389296 ("mcb: mcb-parse: fix error handing in chameleon_parse_gdd()")
> Reviewed-by: Jose Javier Rodriguez Barbarin <JoseJavier.Rodriguez@duagon.com>
> Signed-off-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
prev parent reply other threads:[~2023-09-07 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 14:36 Sanjuán García, Jorge
2023-09-07 1:31 ` Yang Yingliang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8d98a0-9111-86e5-38e5-bfa4beb6d1ba@huawei.com \
--to=yangyingliang@huawei.com \
--cc=Jorge.SanjuanGarcia@duagon.com \
--cc=JoseJavier.Rodriguez@duagon.com \
--cc=jirislaby@kernel.org \
--cc=jth@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®