From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbdLLI4S (ORCPT ); Tue, 12 Dec 2017 03:56:18 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57126 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbdLLI4N (ORCPT ); Tue, 12 Dec 2017 03:56:13 -0500 Subject: Re: [PATCH] serial: forbid 8250 on s390 To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171212080835.23610-1-borntraeger@de.ibm.com> <20171212084808.GA14030@kroah.com> From: Christian Borntraeger Date: Tue, 12 Dec 2017 09:56:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171212084808.GA14030@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17121208-0020-0000-0000-000003D71861 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17121208-0021-0000-0000-0000426CB577 Message-Id: <8e92cb31-f35a-6f4b-7409-035e87c0818a@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-12_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712120135 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2017 09:48 AM, Greg Kroah-Hartman wrote: > On Tue, Dec 12, 2017 at 09:08:35AM +0100, Christian Borntraeger wrote: >> Using "make kvmconfig" results in a potentially unusable linux image >> on s390. The reason is that both the (default on s390) sclp consoles >> as well as the 8250 console register a ttyS as console. Since there >> will be no 8250 on s390 let's fence 8250. This will ensure that there >> is always a working sclp console. >> >> Reported-by: Alice Frosi >> Signed-off-by: Christian Borntraeger >> Reviewed-by: Hendrik Brueckner >> --- >> drivers/tty/serial/8250/Kconfig | 1 + >> 1 file changed, 1 insertion(+) > > Does this need to be backported to any stable kernels? Or does anyone > who runs them on s390 already have this config option disabled? All shipped s390 kernels have 8250 disabled anyway. A backport of this patch could be helpful to let users who want to use "make kvmconfig" give a working configuration but it is certainly not critical. Christian