From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 915A2EB64D7 for ; Fri, 30 Jun 2023 11:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232883AbjF3LNx convert rfc822-to-8bit (ORCPT ); Fri, 30 Jun 2023 07:13:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232916AbjF3LNj (ORCPT ); Fri, 30 Jun 2023 07:13:39 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F23DA2D4A; Fri, 30 Jun 2023 04:13:14 -0700 (PDT) X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net Received: by mail.gandi.net (Postfix) with ESMTPSA id 00228240004; Fri, 30 Jun 2023 11:13:11 +0000 (UTC) Message-ID: <8e97df981ab8871cf774c6be9e48d6ce3c0e80b7.camel@hadess.net> Subject: Re: [PATCH v2] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed From: Bastien Nocera To: Stuart Hayhurst Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , Filipe =?ISO-8859-1?Q?La=EDns?= Date: Fri, 30 Jun 2023 13:13:11 +0200 In-Reply-To: <20230629214602.987600-1-stuart.a.hayhurst@gmail.com> References: <20230629192422.980071-1-stuart.a.hayhurst@gmail.com> <20230629214602.987600-1-stuart.a.hayhurst@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2023-06-29 at 22:46 +0100, Stuart Hayhurst wrote: > Previously, support for the G502 had been attempted in commit > 27fc32f. > This caused some issues and was reverted by addf338. > Since then, a new version of this mouse has been released (Lightpseed > Wireless), and works correctly. Sorry to do this to you, but you might need to rework the description again. The kernel maintainers are pretty strict when it comes to commit references. "If you want to refer to a specific commit, don't just refer to the SHA-1 ID of the commit. Please also include the oneline summary of the commit, to make it easier for reviewers to know what it is about." https://docs.kernel.org/process/submitting-patches.html#describe-your-changes So 12-character short SHA-1 and the subject of the commit. ./scripts/checkpatch.pl should warn about that. Should be: 27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more supported mice" and addf3382c47c ("Revert "HID: logitech-hidpp: add USB PID for a few more supported mice"") But you'll want to check those :) > > This device has support for battery reporting with the driver > > Signed-off-by: Stuart Hayhurst > --- >  drivers/hid/hid-logitech-hidpp.c | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > logitech-hidpp.c > index 5e1a412fd28f..94a045ef8e50 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4598,6 +4598,8 @@ static const struct hid_device_id > hidpp_devices[] = { >   >         { /* Logitech G403 Wireless Gaming Mouse over USB */ >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) }, > +       { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB > */ > +         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) }, >         { /* Logitech G703 Gaming Mouse over USB */ >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) }, >         { /* Logitech G703 Hero Gaming Mouse over USB */